diff --git a/hadrian/src/Settings/Builders/RunTest.hs b/hadrian/src/Settings/Builders/RunTest.hs index 1cccfd04b5616f0b074eafaeb8850b343bdf457d..c0e7724c9de1f3fcfa9f91ebf2437b15ffb4424d 100644 --- a/hadrian/src/Settings/Builders/RunTest.hs +++ b/hadrian/src/Settings/Builders/RunTest.hs @@ -282,7 +282,7 @@ runTestBuilderArgs = builder Testsuite ? do , arg "-e", arg $ asBool "ghc_with_dynamic_rts=" (hasDynamicRts) , arg "-e", arg $ asBool "config.ghc_with_threaded_rts=" (hasThreadedRts) , arg "-e", arg $ asBool "config.have_fast_bignum=" (bignumBackend /= "native" && not bignumCheck) - , arg "-e", arg $ asBool "target_with_smp=" targetWithSMP + , arg "-e", arg $ asBool "config.target_has_smp=" targetWithSMP , arg "-e", arg $ "config.ghc_dynamic=" ++ show hasDynamic , arg "-e", arg $ "config.leading_underscore=" ++ show leadingUnderscore diff --git a/testsuite/config/ghc b/testsuite/config/ghc index f22fb392e9f932951f9a3789a0b7e2db75263188..01d1fcf14e9dba0e66c92e2dc01871c18f973aad 100644 --- a/testsuite/config/ghc +++ b/testsuite/config/ghc @@ -48,8 +48,7 @@ if config.have_interp: # whether the target supports smp if config.ghc_with_threaded_rts: config.run_ways.append('threaded1') - if target_with_smp: - config.target_has_smp = True + if config.target_has_smp: config.run_ways.append('threaded2') if config.speed == 0: config.run_ways.append('nonmoving_thr') diff --git a/testsuite/driver/testglobals.py b/testsuite/driver/testglobals.py index 9c2d59701dfde4fd885efbfcc67a70e164cfa2e8..5b2e59b7ba5ed1efa6c6a22ba46749e44ab86268 100644 --- a/testsuite/driver/testglobals.py +++ b/testsuite/driver/testglobals.py @@ -154,7 +154,7 @@ class TestConfig: self.ghc_has_smp = True # Does the target have SMP support? - self.target_has_smp = True + self.target_has_smp = False # Is gdb available? self.have_gdb = False diff --git a/testsuite/driver/testlib.py b/testsuite/driver/testlib.py index b7351867968532b1af999355799542238066c6f2..35c97581a2f5cd75727f15eefb07d43cb1eaa2d3 100644 --- a/testsuite/driver/testlib.py +++ b/testsuite/driver/testlib.py @@ -328,11 +328,11 @@ def req_ghc_smp( name, opts ): def req_target_smp( name, opts ): """ Mark a test as requiring smp when run on the target. If the target does - not support smp, then mark the test as an expected fail. Use this when the + not support smp, then skip the test. Use this when the test needs to run with smp support. """ if not config.target_has_smp: - opts.expect = 'fail' + opts.skip = True def req_ghc_with_threaded_rts( name, opts ): if not config.ghc_with_threaded_rts: diff --git a/testsuite/mk/test.mk b/testsuite/mk/test.mk index c3a1ddb0e1b6e3a8948cd5bd0446aca26c48e335..0d8899fe51b9ee36b019c780ce237b00d856af55 100644 --- a/testsuite/mk/test.mk +++ b/testsuite/mk/test.mk @@ -167,9 +167,9 @@ CABAL_PLUGIN_BUILD = --enable-library-vanilla --disable-shared endif ifeq "$(GhcWithSMP)" "YES" -RUNTEST_OPTS += -e target_with_smp=True +RUNTEST_OPTS += -e config.target_has_smp=True else -RUNTEST_OPTS += -e target_with_smp=False +RUNTEST_OPTS += -e config.target_has_smp=False endif ifeq "$(GhcWithRtsLinker)" "YES"