From 7485f848fd4e6a5936a8cb79c62e62e43e5d9a66 Mon Sep 17 00:00:00 2001 From: Bodigrim <andrew.lelechenko@gmail.com> Date: Fri, 16 Jun 2023 22:22:22 +0100 Subject: [PATCH] Bump Cabal submodule This requires changing the recomp007 test because now cabal passes `this-unit-id` to executable components, and that unit-id contains a hash which includes the ABI of the dependencies. Therefore changing the dependencies means that -this-unit-id changes and recompilation is triggered. The spririt of the test is to test GHC's recompilation logic assuming that `-this-unit-id` is constant, so we explicitly pass `-ipid` to `./configure` rather than letting `Cabal` work it out. --- libraries/Cabal | 2 +- testsuite/tests/driver/T4437.hs | 3 +-- testsuite/tests/driver/recomp007/Makefile | 4 ++-- testsuite/tests/driver/recomp007/recomp007.stdout | 4 ++-- 4 files changed, 6 insertions(+), 7 deletions(-) diff --git a/libraries/Cabal b/libraries/Cabal index 4bfd6a0352ec..e71f6f263aa4 160000 --- a/libraries/Cabal +++ b/libraries/Cabal @@ -1 +1 @@ -Subproject commit 4bfd6a0352ecfd71e1ca756a007ca827b68416d5 +Subproject commit e71f6f263aa4d7ce7a145eb5ac417f2f580f2288 diff --git a/testsuite/tests/driver/T4437.hs b/testsuite/tests/driver/T4437.hs index 142c348fca2f..3c07aa56790d 100644 --- a/testsuite/tests/driver/T4437.hs +++ b/testsuite/tests/driver/T4437.hs @@ -37,8 +37,7 @@ check title expected got -- See Note [Adding a language extension] in compiler/GHC/Driver/Session.hs. expectedGhcOnlyExtensions :: [String] expectedGhcOnlyExtensions = - [ "TypeAbstractions", - "ExtendedLiterals" + [ "TypeAbstractions" ] expectedCabalOnlyExtensions :: [String] diff --git a/testsuite/tests/driver/recomp007/Makefile b/testsuite/tests/driver/recomp007/Makefile index caf746ed844d..e38112e84641 100644 --- a/testsuite/tests/driver/recomp007/Makefile +++ b/testsuite/tests/driver/recomp007/Makefile @@ -20,11 +20,11 @@ recomp007: ./b/dist/build/test/test "$(GHC_PKG)" unregister --package-db=$(LOCAL_PKGCONF) a-1.0 $(MAKE) -s --no-print-directory prep.a2 - cd b && ../Setup configure -v0 --with-compiler="$(TEST_HC)" --with-hc-pkg="$(GHC_PKG)" --package-db=../$(LOCAL_PKGCONF) + cd b && ../Setup configure -v0 --with-compiler="$(TEST_HC)" --with-hc-pkg="$(GHC_PKG)" --package-db=../$(LOCAL_PKGCONF) --ipid b cd b && ../Setup build ./b/dist/build/test/test prep.%: - cd $* && ../Setup configure -v0 --with-compiler="$(TEST_HC)" --with-hc-pkg="$(GHC_PKG)" --package-db=../$(LOCAL_PKGCONF) + cd $* && ../Setup configure -v0 --with-compiler="$(TEST_HC)" --with-hc-pkg="$(GHC_PKG)" --package-db=../$(LOCAL_PKGCONF) --ipid $* cd $* && ../Setup build -v0 cd $* && ../Setup register -v0 --inplace diff --git a/testsuite/tests/driver/recomp007/recomp007.stdout b/testsuite/tests/driver/recomp007/recomp007.stdout index cbb1b0670b69..f8d479b0cd94 100644 --- a/testsuite/tests/driver/recomp007/recomp007.stdout +++ b/testsuite/tests/driver/recomp007/recomp007.stdout @@ -1,6 +1,6 @@ "1.0" -Preprocessing executable 'test' for b-1.0.. -Building executable 'test' for b-1.0.. +Preprocessing executable 'test' for b-1.0... +Building executable 'test' for b-1.0... [1 of 2] Compiling B ( B.hs, dist/build/test/test-tmp/B.o ) [A package changed] [3 of 3] Linking dist/build/test/test [Objects changed] "2.0" -- GitLab