GitLab

Matthew Pickering authored Jun 06, 2022 and Marge Bot committed Jun 09, 2022

Fixes #21682

sheaf authored Jun 06, 2022 and Marge Bot committed Jun 09, 2022

This patch refactors hasFixedRuntimeRep_remainingValArgs, renaming it
to tcRemainingValArgs. The logic is moved to rebuildHsApps, which
ensures consistent behaviour across tcApp and quickLookArg1/tcEValArg.

This patch also refactors the treatment of stupid theta for data
constructors, changing the place we drop stupid theta arguments
from dsConLike to mkDataConRep (now the datacon wrapper drops these
arguments).

We decided not to implement PHASE 2 of the FixedRuntimeRep plan for
these remaining ValArgs. Future directions are outlined on the wiki:
  https://gitlab.haskell.org/ghc/ghc/-/wikis/Remaining-ValArgs

Fixes #21544 and #21650

Andreas Klebinger authored Jun 02, 2022 and Marge Bot committed Jun 09, 2022

We used to process the rhs of non-recursive bindings and their body
using the same env. If we had something like
    let x = ... x ...
this caused trouble because the two xs refer to different binders
but we would substitute both for a new binder x2 causing out of scope
errors.

We now simply use two different envs for the rhs and body in cse_bind.
It's all explained in the Note [Separate envs for let rhs and body]

Fixes #21685

Co-Authored-By: Andre Marianiello <andremarianiello@users.noreply.github.com>

It is redundant information and a source of needless version control
conflicts when multiple MRs are changing the deps list.

Just printing the list and not also its length is fine.

Simon Peyton Jones authored Jun 03, 2022 and Marge Bot committed Jun 06, 2022

In the Specialiser, we missed one more call to
bringFloatedDictsIntoScope (see #21391).

This omission led to #21689. The problem is that the call
to `rewriteClassOps` needs to have in scope any dictionaries
floated out of the arguments we have just specialised.

Easy fix.

Aaron Allen authored May 08, 2022 and Marge Bot committed Jun 06, 2022

Replaces uses of `TcRnUnknownMessage` with proper diagnostics
constructors in `GHC.Tc.Gen.Match`, `GHC.Tc.Gen.Pat`, and
`GHC.Tc.Gen.Sig`.

Rinat Striungis authored Apr 27, 2022 and Marge Bot committed Jun 06, 2022

This commit fixes #20312
It deprecates "TypeInType" extension
according to the following proposal:
https://github.com/ghc-proposals/ghc-proposals/blob/master/proposals/0083-no-type-in-type.rst

It has been already implemented.

The migration strategy:
 1. Disable TypeInType
 2. Enable both DataKinds and PolyKinds extensions

Metric Decrease:
    T16875

Finishes what !7467 (closed) started.

Progress towards #17957

Sylvain Henry authored Jun 02, 2022 and John Ericson committed Jun 02, 2022

We have the length already, so we might as well use that rather than
O(n) recomputing it.

As proposed in
!7508 (comment 432877) and
!7508 (comment 434676),
`GHC.HsToCore.Ticks` is about ticks, breakpoints are separate and
backend-specific (only for the bytecode interpreter), and mix entry
writing is just for HPC.

With this split we separate out those interpreter- and HPC-specific
its, and keep the main `GHC.HsToCore.Ticks` agnostic.

Also, instead of passing the reversed list and count around, we use
`SizedSeq` which abstracts over the algorithm. This is much nicer to
avoid noise and prevents bugs.

(The bugs are not just hypothetical! I missed up the reverses on an
earlier draft of this commit.)

The old name made it confusing why disabling HPC didn't disable the
entire pass. The name makes it clear --- there are other reasons to add
ticks in addition.

No need to inline traversing a maybe for `mkModBreaks`. And better to
make each function do one thing and let the caller deside when than
scatter the decision making and make the caller seem more imperative.

Matthew Pickering authored Apr 28, 2022 and Marge Bot committed Jun 01, 2022

This is a follow-up to !7247 (closed) making the inclusion of compact unwinding
sections the default.

Also a slight refactoring/simplification of the flag handling to add
-fno-compact-unwind.

Matthew Pickering authored Feb 17, 2022 and Marge Bot committed Jun 01, 2022

This allows us to see the output of hadrian while it is doing the setup.

Ben Gamari authored Apr 26, 2022 and Marge Bot committed Jun 01, 2022

To current `master`.

(cherry picked from commit fbb59c21)

Ben Gamari authored Apr 27, 2022 and Marge Bot committed Jun 01, 2022

Metric Decrease:
    T5631
Metric Increase:
    T18223

(cherry picked from commit 55fcee30)

Shlomo Shuck authored May 29, 2022 and Marge Bot committed Jun 01, 2022

Fixes ghc/ghc#21675.

Matthew Pickering authored May 30, 2022 and Marge Bot committed Jun 01, 2022

Since we started producing source dists with hadrian we stopped copying
in the files created by ./boot which adds a dependency on python3 and
autoreconf. This adds back in the files which were created by running
configure.

Fixes #21673 #21672 and #21626

Pierre Le Marre authored May 17, 2022 and Marge Bot committed Jun 01, 2022

Switch to a pure Haskell implementation of base:GHC.Unicode, based on the implementation of the package unicode-data (https://github.com/composewell/unicode-data/).

Approved by CLC as per https://github.com/haskell/core-libraries-committee/issues/59#issuecomment-1132106691.

- Remove current Unicode cbits.
- Add generator for Unicode property files from Unicode Character Database.
- Generate internal modules.
- Update GHC.Unicode.
- Add unicode003 test for general categories and case mappings.
- Add Python scripts to check 'base' Unicode tests outputs and characters properties.

Fixes #21375

-------------------------
Metric Decrease:
    T16875
Metric Increase:
    T4029
    T18304
    haddock.base
-------------------------

Matthew Pickering authored May 31, 2022 and Marge Bot committed Jun 01, 2022

Fixes #21619

Rodrigo Mesquita authored Mar 19, 2022 and Marge Bot committed Jun 01, 2022

This commit redefines the structure of Splices in the AST.

We get rid of `HsSplice` which used to represent typed and untyped
splices, quasi quotes, and the result of splicing either an expression,
a type or a pattern.

Instead we have `HsUntypedSplice` which models an untyped splice or a
quasi quoter, which works in practice just like untyped splices.

The `HsExpr` constructor `HsSpliceE` which used to be constructed with
an `HsSplice` is split into `HsTypedSplice` and `HsUntypedSplice`. The
former is directly constructed with an `HsExpr` and the latter now takes
an `HsUntypedSplice`.

Both `HsType` and `Pat` constructors `HsSpliceTy` and `SplicePat` now
take an `HsUntypedSplice` instead of a `HsSplice` (remember only
/untyped splices/ can be spliced as types or patterns).

The result of splicing an expression, type, or pattern is now
comfortably stored in the extension fields `XSpliceTy`, `XSplicePat`,
`XUntypedSplice` as, respectively, `HsUntypedSpliceResult (HsType
Ghc...

Rodrigo Mesquita authored Mar 19, 2022 and Marge Bot committed Jun 01, 2022

UntypedSpliceFlavour was only used in the client-specific `GHC.Hs.Expr`
but was defined in the client-independent L.H.S.Expr.

Progress towards #17957

Because of `CoreM`, I did not move the `DynFlags` and `HscEnv` to other
modules as thoroughly as I usually do. This does mean that risk of
`DynFlags` "creeping back in" is higher than it usually is.

After we do the same process to the other Core passes, and then figure
out what we want to do about `CoreM`, we can finish the job started
here.

That is a good deal more work, however, so it certainly makes sense to
land this now.

Matthew Pickering authored May 30, 2022 and Marge Bot committed May 31, 2022

This reverts commit 699f5935.

Split sections causes segfaults in profiling way with old toolchains
(deb9) and on windows (#21670)

Fixes #21670

Matthew Pickering authored May 26, 2022 and Marge Bot committed May 31, 2022

This helps tracing errors which happen when building stage1

Matthew Pickering authored May 25, 2022 and Marge Bot committed May 31, 2022

These executables (such as hsc2hs) are built using the boot compiler and
crucially, most libraries from the global package database.

We also move other build-time executables to be built in this stage such
as linters which also cleans up which libraries end up in the global
package database. This allows us to remove hacks where linters-common is
removed from the package database when a bindist is created.

This fixes issues caused by infinite recursion due to bytestring adding
a dependency on template-haskell.

Fixes #21634

Matthew Pickering authored May 30, 2022 and Marge Bot committed May 30, 2022

Now #21563 is fixed we can properly enable `-dlint` in CI rather than a
subset of the flags.

Matthew Pickering authored May 26, 2022 and Marge Bot committed May 30, 2022

We originally planned to remove the flag in 9.4 but there's actually no
great rush to do so and it's probably less confusing (forever) to keep
the message around suggesting an explicit profiling option.

Fixes #21545