Skip to content
Snippets Groups Projects
  • Erik de Castro Lopo's avatar
    2951cd01
    Don't use readdir_r if deprecated · 2951cd01
    Erik de Castro Lopo authored
    GNU glibc 2.23 and later deprecate `readdir_r` in favour of plain old
    `readdir` which in some upcoming POSIX standard is going to required to be
    re-entrant.
    
    Eventually we want to drop `readder_r` all together, but want to be
    compatible with older unixen which may not have a re-entrant `readdir`.
    
    Solution is to make systems with *known* re-entrant `readir` use that and
    use `readdir_r` whereever we have it and don't *know* that `readdir` is
    re-entrant.
    
    Closes: https://github.com/haskell/unix/issues/70
    2951cd01
    History
    Don't use readdir_r if deprecated
    Erik de Castro Lopo authored
    GNU glibc 2.23 and later deprecate `readdir_r` in favour of plain old
    `readdir` which in some upcoming POSIX standard is going to required to be
    re-entrant.
    
    Eventually we want to drop `readder_r` all together, but want to be
    compatible with older unixen which may not have a re-entrant `readdir`.
    
    Solution is to make systems with *known* re-entrant `readir` use that and
    use `readdir_r` whereever we have it and don't *know* that `readdir` is
    re-entrant.
    
    Closes: https://github.com/haskell/unix/issues/70
Code owners
Assign users and groups as approvers for specific file changes. Learn more.
HsUnix.c 2.82 KiB
/* -----------------------------------------------------------------------------
 *
 * (c) The University of Glasgow 2002
 *
 * Definitions for package `unix' which are visible in Haskell land.
 *
 * ---------------------------------------------------------------------------*/

#include "HsUnix.h"

#ifdef HAVE_RTLDNEXT
void *__hsunix_rtldNext (void) {return RTLD_NEXT;}
#endif

#ifdef HAVE_RTLDDEFAULT
void *__hsunix_rtldDefault (void) {return RTLD_DEFAULT;}
#endif

#if HAVE_PTSNAME && (__GLASGOW_HASKELL__ < 800)
// On Linux (and others), <stdlib.h> needs to be included while
// `_XOPEN_SOURCE` is already defined. However, GHCs before GHC 8.0
// didn't do that yet for CApiFFI, so we need this workaround here.

char *__hsunix_ptsname(int fd)   { return ptsname(fd);  }
int   __hsunix_grantpt(int fd)   { return grantpt(fd);  }
int   __hsunix_unlockpt(int fd)  { return unlockpt(fd); }
#endif

// push a SVR4 STREAMS module; do nothing if STREAMS not available
int __hsunix_push_module(int fd, const char *module)
{
#if defined(I_PUSH) && !defined(HAVE_DEV_PTC)
    return ioctl(fd, I_PUSH, module);
#else
    return 0;
#endif
}

/*
 * GNU glibc 2.23 and later deprecate `readdir_r` in favour of plain old
 * `readdir` which in some upcoming POSIX standard is going to required to be
 * re-entrant.
 * Eventually we want to drop `readder_r` all together, but want to be
 * compatible with older unixen which may not have a re-entrant `readdir`.
 * Solution is to make systems with *known* re-entrant `readir` use that and use
 * `readdir_r` whereever we have it and don't *know* that `readdir` is
 * re-entrant.
 */

#if defined (__GLIBC__) && (__GLIBC__ >= 2) && (__GLIBC_MINOR__ >= 23)
#define USE_READDIR_R 0
#else
#define USE_READDIR_R 1
#endif

/*
 * read an entry from the directory stream; opt for the
 * re-entrant friendly way of doing this, if available.
 */
int __hscore_readdir( DIR *dirPtr, struct dirent **pDirEnt )
{
#if HAVE_READDIR_R && USE_READDIR_R
  struct dirent* p;
  int res;
  static unsigned int nm_max = (unsigned int)-1;

  if (pDirEnt == NULL) {
    return -1;
  }
  if (nm_max == (unsigned int)-1) {
#ifdef NAME_MAX
    nm_max = NAME_MAX + 1;
#else
    nm_max = pathconf(".", _PC_NAME_MAX);
    if (nm_max == -1) { nm_max = 255; }
    nm_max++;
#endif
  }
  p = (struct dirent*)malloc(sizeof(struct dirent) + nm_max);
  if (p == NULL) return -1;
  res = readdir_r(dirPtr, p, pDirEnt);
  if (res != 0) {
      *pDirEnt = NULL;
      free(p);
  }
  else if (*pDirEnt == NULL) {
    // end of stream
    free(p);
  }
  return res;
#else

  if (pDirEnt == NULL) {
    return -1;
  }

  *pDirEnt = readdir(dirPtr);
  if (*pDirEnt == NULL) {
    return -1;
  } else {
    return 0;
  }
#endif
}

char *__hscore_d_name( struct dirent* d )
{
  return (d->d_name);
}

void __hscore_free_dirent(struct dirent *dEnt)
{
#if HAVE_READDIR_R
  free(dEnt);
#endif
}