compiler/hsSyn/HsDoc.hs · ghc-8.8.1-alpha2 · Xia Li-yao / GHC

Blame

Forked from Glasgow Haskell Compiler / GHC

15273 commits behind, 192 commits ahead of the upstream repository.

7 years ago

69b50efe

Fix deserialization of docs (#15240 ) · 69b50efe

Simon Jakobi authored 7 years ago and

Ben Gamari committed 7 years ago

We were using Map.fromDistinctAscList to deserialize a
(Map Name HsDocString). As the Names' Uniques had changed, we
ended up with an invalid map in which we couldn't lookup certain keys.

Switching to Map.fromList fixed the issue.

Added comments in several places.

Reviewers: alexbiehl, hvr, bgamari

Reviewed By: bgamari

Subscribers: rwbarton, thomie, carter

GHC Trac Issues: #15240

Differential Revision: https://phabricator.haskell.org/D4816

69b50efe

History

Fix deserialization of docs (#15240 )

Simon Jakobi authored 7 years ago and

Ben Gamari committed 7 years ago

We were using Map.fromDistinctAscList to deserialize a
(Map Name HsDocString). As the Names' Uniques had changed, we
ended up with an invalid map in which we couldn't lookup certain keys.

Switching to Map.fromList fixed the issue.

Added comments in several places.

Reviewers: alexbiehl, hvr, bgamari

Reviewed By: bgamari

Subscribers: rwbarton, thomie, carter

GHC Trac Issues: #15240

Differential Revision: https://phabricator.haskell.org/D4816

Code owners

Assign users and groups as approvers for specific file changes. Learn more.

HsDoc.hs 4.35 KiB