Skip to content

GitLab

Glasgow Haskell Compiler
Glasgow Haskell Compiler

Refactoring: Use bindSigTyVarsFV in rnMethodBinds 

`rnMethodBinds` was explicitly using `xoptM` to determine if
`ScopedTypeVariables` is enabled before bringing type variables
bound by the class/instance header into scope. However, this `xoptM`
logic is already performed by the `bindSigTyVarsFV` function. This
patch uses `bindSigTyVarsFV` in `rnMethodBinds` to reduce the number
of places where we need to consult if `ScopedTypeVariables` is on.

This is purely refactoring, and there should be no user-visible
change in behavior.
24 jobs for master in 43 minutes and 36 seconds (queued for 3 seconds)
9afd9251
No related merge requests found.
Status Job ID Name Coverage
  Lint
passed #328160
lint
lint-linters

00:00:44

failed #328163
lint allowed to fail
lint-submods

00:00:11

passed #328164
lint
lint-submods-branch

00:00:17

passed #328161
lint
lint-testsuite

00:00:46

passed #328162
lint
typecheck-testsuite

00:00:15

 
  Quick Build
passed #328165
x86_64-linux
hadrian-ghc-in-ghci

00:10:57

 
  Build
failed #328166
x86_64-linux
validate-x86_64-linux-deb9-hadrian

00:31:08

 
  Full Build
skipped #328169
aarch64-linux allowed to fail
validate-aarch64-linux-deb9
skipped #328170
armv7-linux
validate-armv7-linux-deb9
skipped #328171
x86_64-linux
validate-i386-linux-deb9
skipped #328178
new-x86_64-windows test allowed to fail
validate-i386-windows
skipped #328168
x86_64-darwin
validate-x86_64-darwin
skipped #328172
x86_64-linux
validate-x86_64-linux-deb9-debug
skipped #328174
x86_64-linux
validate-x86_64-linux-deb9-dwarf
skipped #328173
x86_64-linux
validate-x86_64-linux-deb9-integer-simple
skipped #328167
x86_64-linux
validate-x86_64-linux-deb9-unreg-hadrian
skipped #328175
x86_64-linux
validate-x86_64-linux-fedora27
skipped #328177
new-x86_64-windows test allowed to fail
validate-x86_64-windows
skipped #328176
new-x86_64-windows test allowed to fail
validate-x86_64-windows-hadrian
 
  Cleanup
passed #328179
x86_64-darwin
cleanup-darwin

00:00:12

 
  Packaging
skipped #328180
x86_64-linux allowed to fail
doc-tarball
 
  Testing
skipped #328181
x86_64-linux allowed to fail manual
hackage
skipped #328182
x86_64-linux
perf-nofib
 
  Deploy
skipped #328183
x86_64-linux allowed to fail
pages
 
Name Stage Failure
failed
lint-submods Lint 
Entering 'libraries/unix'
Entering 'libraries/xhtml'
Entering 'nofib'
Entering 'utils/haddock'
Entering 'utils/hsc2hs'
Authenticating with credentials from job payload (GitLab Registry)
$ git fetch "$CI_MERGE_REQUEST_PROJECT_URL" $CI_MERGE_REQUEST_TARGET_BRANCH_NAME
fatal: No path specified. See 'man git-pull' for valid url syntax
ERROR: Job failed: exit code 1
failed
validate-x86_64-linux-deb9-hadrian Build 
hadrian/build-cabal --flavour=validate -j4 --broken-test= binary-dist failed
Running after script...
$ .gitlab/ci.sh clean
Running make --quiet clean...
Running rm -Rf _build...
Uploading artifacts...
WARNING: junit.xml: no matching files              
ERROR: No files to upload                          
ERROR: Job failed: exit code 1