Skip to content
  • Ryan Scott's avatar
    Change isClosedAlgType to be TYPE-aware, and rename it to pmIsClosedType · 4f1f9868
    Ryan Scott authored
    Summary:
    In a267580e, I somewhat awkwardly
    inserted a special case for `TYPE` in the `EmptyCase` coverage checker.
    Instead of placing it there, @mpickering noted that `isClosedAlgType` would
    be a better fit for it. I do just that in this patch.
    
    I also renamed `isClosedAlgType` to `pmIsClosedType`, reflecting the fact that
    `TYPE` technically isn't an algebraic type (it's a primitive one), and that its
    behavior is pattern-match coverage checking-oriented. I also moved it to
    `Check`, which is a better home for this function than `Type`. Luckily,
    the only call sites for `isClosedAlgType` were in the pattern-match coverage
    checker anyways, so this change is simple enough.
    
    Test Plan: ./validate
    
    Reviewers: mpickering, austin, goldfire, bgamari
    
    Reviewed By: goldfire
    
    Subscribers: rwbarton, thomie, mpickering
    
    GHC Trac Issues: #14086
    
    Differential Revision: https://phabricator.haskell.org/D3830
    4f1f9868