Commit 3ee4fc04 authored by Sergei Trofimovich's avatar Sergei Trofimovich Committed by Sergei Trofimovich

rts: drop unused global 'blackhole_queue'

Commit 5d52d9b6 removed
global 'blackhole_queue' in favour of new mechanism:
when TSO hits blackhole TSO blocks waiting for
'MessgaeBlackhole' delivery.

Patch removed unused global and updates stale comments.
Noticed by Yuras Shumovich.
Signed-off-by: default avatarSergei Trofimovich <siarheit@google.com>

Test Plan: build test

Reviewers: simonmar, austin, Yuras, bgamari

Reviewed By: Yuras, bgamari

Subscribers: thomie

Differential Revision: https://phabricator.haskell.org/D1953
parent 890e2bb7
...@@ -230,7 +230,7 @@ void dirty_STACK (Capability *cap, StgStack *stack); ...@@ -230,7 +230,7 @@ void dirty_STACK (Capability *cap, StgStack *stack);
---------------------------------------------------------------------- ----------------------------------------------------------------------
NotBlocked END_TSO_QUEUE runnable_queue, or running NotBlocked END_TSO_QUEUE runnable_queue, or running
BlockedOnBlackHole the BLACKHOLE blackhole_queue BlockedOnBlackHole MessageBlackHole * TSO->bq
BlockedOnMVar the MVAR the MVAR's queue BlockedOnMVar the MVAR the MVAR's queue
......
...@@ -462,7 +462,6 @@ extern StgWord rts_breakpoint_io_action[]; ...@@ -462,7 +462,6 @@ extern StgWord rts_breakpoint_io_action[];
// Schedule.c // Schedule.c
extern StgWord RTS_VAR(blocked_queue_hd), RTS_VAR(blocked_queue_tl); extern StgWord RTS_VAR(blocked_queue_hd), RTS_VAR(blocked_queue_tl);
extern StgWord RTS_VAR(sleeping_queue); extern StgWord RTS_VAR(sleeping_queue);
extern StgWord RTS_VAR(blackhole_queue);
extern StgWord RTS_VAR(sched_mutex); extern StgWord RTS_VAR(sched_mutex);
// Apply.cmm // Apply.cmm
......
...@@ -97,7 +97,6 @@ extern volatile StgWord recent_activity; ...@@ -97,7 +97,6 @@ extern volatile StgWord recent_activity;
/* Thread queues. /* Thread queues.
* Locks required : sched_mutex * Locks required : sched_mutex
*/ */
extern StgTSO *blackhole_queue;
#if !defined(THREADED_RTS) #if !defined(THREADED_RTS)
extern StgTSO *blocked_queue_hd, *blocked_queue_tl; extern StgTSO *blocked_queue_hd, *blocked_queue_tl;
extern StgTSO *sleeping_queue; extern StgTSO *sleeping_queue;
......
...@@ -1046,7 +1046,6 @@ dirty_TVAR(Capability *cap, StgTVar *p) ...@@ -1046,7 +1046,6 @@ dirty_TVAR(Capability *cap, StgTVar *p)
// Setting a TSO's link field with a write barrier. // Setting a TSO's link field with a write barrier.
// It is *not* necessary to call this function when // It is *not* necessary to call this function when
// * setting the link field to END_TSO_QUEUE // * setting the link field to END_TSO_QUEUE
// * putting a TSO on the blackhole_queue
// * setting the link field of the currently running TSO, as it // * setting the link field of the currently running TSO, as it
// will already be dirty. // will already be dirty.
void void
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment