This project is mirrored from Pull mirroring failed .
Repository mirroring has been paused due to too many failed attempts. It can be resumed by a project maintainer.
Last successful update .
  1. 30 Oct, 2017 2 commits
  2. 29 Oct, 2017 2 commits
    • Joachim Breitner's avatar
      Implement a dedicated exitfication pass #14152 · 0e953da1
      Joachim Breitner authored
      The idea is described in #14152, and can be summarized: Float the exit
      path out of a joinrec, so that the simplifier can do more with it.
      See the test case for a nice example.
      The floating goes against what the simplifier usually does, hence we
      need to be careful not inline them back.
      The position of exitification in the pipeline was chosen after a small
      amount of experimentation, but may need to be improved. For example,
      exitification can allow rewrite rules to fire, but for that it would
      have to happen before the `simpl_phases`.
    reports these nice performance wins:
          Nofib allocations
          fannkuch-redux    78446640  - 99.92%      64560
          k-nucleotide     109466384  - 91.32%    9502040
          simple            72424696  -  5.96%   68109560
          Nofib instruction counts
          fannkuch-redux  1744331636  -  3.86% 1676999519
          k-nucleotide    2318221965  -  6.30% 2172067260
          scs             1978470869  -  3.35% 1912263779
          simple           669858104  -  3.38%  647206739
          spectral-norm    186423292  -  5.37%  176411536
      Differential Revision:
    • Joachim Breitner's avatar
      simplNonRecJoinPoint: Handle Shadowing correctly · 97ca0d24
      Joachim Breitner authored
      Previously, (since 33452dfc), simplNonRecJoinPoint would do the wrong
      thing in the presence of shadowing: It analyzed the RHS of a join
      binding with the environment for the body. In particular, with
          foo x =
            join x = x * x
            in x
      where there is shadowing, it renames the inner x to x1, and should
          foo x =
            join x1 = x * x
            in x1
      but because the substitution (x ↦ x1) is also used on the RHS we get the
          foo x =
            join x1 = x1 * x1
            in x1
      Fixed this by adding a `rhs_se` parameter, analogous to `simplNonRecE`
      and `simplLazyBind`.
      Differential Revision:
  3. 28 Oct, 2017 1 commit
  4. 27 Oct, 2017 5 commits
    • Bartosz Nitka's avatar
      Make tagForCon non-linear · faf60e85
      Bartosz Nitka authored
      Computing the number of constructors for TyCon is linear
      in the number of constructors.
      That's wasteful if all you want to check is if that
      number is smaller than what fits in tag bits
      (usually 8 things).
      What this change does is to use a function that can
      determine the ineqaulity without computing the size.
      This improves compile time on a module with a
      data type that has 10k constructors.
      The variance in total time is (suspiciously) high,
      but going by the best of 3 the numbers are 8.186s vs 7.511s.
      For 1000 constructors the difference isn't noticeable:
      0.646s vs 0.624s.
      The hot spots were cgDataCon and cgEnumerationTyCon
      where tagForCon is called in a loop.
      One alternative would be to pass down the size.
      Test Plan: harbormaster
      Reviewers: bgamari, simonmar, austin
      Reviewed By: simonmar
      Subscribers: rwbarton, thomie
      Differential Revision:
    • Ben Gamari's avatar
      relnotes: Fix a few minor formatting issues · acd355a8
      Ben Gamari authored
    • Simon Marlow's avatar
      ApplicativeDo: handle BodyStmt (#12143) · 41f90559
      Simon Marlow authored
      It's simple to treat BodyStmt just like a BindStmt with a wildcard
      pattern, which is enough to fix #12143 without going all the way to
      using `<*` and `*>` (#10892).
      Test Plan:
      * new test cases in `ado004.hs`
      * validate
      Reviewers: niteria, simonpj, bgamari, austin, erikd
      Subscribers: rwbarton, thomie
      GHC Trac Issues: #12143
      Differential Revision:
    • Simon Peyton Jones's avatar
      Fix an exponential-blowup case in SpecConstr · 7d7d94fb
      Simon Peyton Jones authored
      Trac #14379 showed a case where use of "forcing" to do
      "damn the torpedos" specialisation without resource limits
      (which 'vector' does a lot) led to exponential blowup.
      The fix is easy.  Finding it wasn't.  See Note [Forcing
      specialisation] and the one-line change in decreaseSpecCount.
    • Simon Peyton Jones's avatar
  5. 26 Oct, 2017 4 commits
  6. 25 Oct, 2017 19 commits
    • Tobias Dammers's avatar
      Factor out readField (#14364) · dbd81f7e
      Tobias Dammers authored
      Improves compiler performance of deriving Read instances, as suggested
      in the issue.
      Additionally, we introduce `readSymField`, a companion to `readField`
      that parses symbol-type fields (where the field name is a symbol, e.g.
      `(#)`, rather than an alphanumeric identifier. The decision between
      these two functions is made a compile time, because we already know
      which one we need based on the field name.
      Reviewers: austin, hvr, bgamari, RyanGlScott
      Reviewed By: bgamari
      Subscribers: RyanGlScott, rwbarton, thomie
      Differential Revision:
    • Douglas Wilson's avatar
      base: Enable listToMaybe to fuse via foldr/build · 4c06ccb7
      Douglas Wilson authored
      Test Plan: Consider whether this is a good idea.
      Reviewers: austin, hvr, bgamari, nomeata
      Reviewed By: bgamari, nomeata
      Subscribers: nomeata, rwbarton, thomie
      GHC Trac Issues: #14387
      Differential Revision:
    • Ben Gamari's avatar
      user-guide: Clarify default optimization flags · 2c23fff2
      Ben Gamari authored
      Begins to fix #14214.
      [skip ci]
      Test Plan: Read it.
      Reviewers: austin
      Subscribers: rwbarton, thomie
      GHC Trac Issues: #14214
      Differential Revision:
    • Alec Theriault's avatar
      Fix a bug in 'alexInputPrevChar' · 821adee1
      Alec Theriault authored
      The lexer hacks around unicode by squishing any character into a 'Word8'
      and then storing the actual character in its state. This happens at
      That is all and well, but we ought to be careful that the characters we
      retrieve via 'alexInputPrevChar' also fit this convention.
      In fact, #13986 exposes nicely what can go wrong: the regex in the left
      context of the type application rule uses the '$idchar' character set
      which relies on the unicode hack. However, a left context corresponds
      to a call to 'alexInputPrevChar', and we end up passing full blown
      unicode characters to '$idchar', despite it not being equipped to deal
      with these.
      Test Plan: Added a regression test case
      Reviewers: austin, bgamari
      Reviewed By: bgamari
      Subscribers: rwbarton, thomie
      GHC Trac Issues: #13986
      Differential Revision:
    • Daishi Nakajima's avatar
      Implement `-Wpartial-fields` warning (#7169) · f7f270eb
      Daishi Nakajima authored
      Warning on declaring a partial record selector.
      However, disable warn with field names that start with underscore.
      Test Plan: Added 1 test case.
      Reviewers: austin, bgamari, simonpj
      Reviewed By: bgamari, simonpj
      Subscribers: goldfire, simonpj, duog, rwbarton, thomie
      GHC Trac Issues: #7169
      Differential Revision:
    • Tobias Dammers's avatar
      Performance improvements linear regAlloc (#7258) · df636682
      Tobias Dammers authored
      When allocating and potentially spilling registers, we need to check
      the desired allocations against current allocations to decide where we
      can spill to, cq. which allocations we can toss and if so, how.
      Previously, this was done by walking the Cartesian product of the
      current allocations (`assig`) and the allocations to keep (`keep`),
      which has quadratic complexity. This patch introduces two improvements:
      1. pre-filter the `assig` list, because we are only interested in two
      types of allocations (in register, and in register+memory), which will
      only make up a small and constant portion of the list; and
      2. use set / map operations instead of lists, which reduces algorithmic
      Reviewers: austin, bgamari
      Reviewed By: bgamari
      Subscribers: rwbarton, thomie
      Differential Revision:
    • Douglas Wilson's avatar
      Fix space leak in BinIface.getSymbolTable · 1c15d8ed
      Douglas Wilson authored
      Replace a call to mapAccumR, which uses linear stack space, with a
      gadget that uses constant space.
      Remove an unused parameter from fromOnDiskName.
      The tests T1292_imports and T4239 are now reporting imported names in a
      different order. I don't completely understand why, but I presume it is
      because the symbol tables are now read more strictly. The new order
      seems better in T1792_imports, and equally random in T4239.
      There are several performance test improvements.
      Test Plan: ./validate
      Reviewers: austin, bgamari
      Reviewed By: bgamari
      Subscribers: alexbiehl, rwbarton, thomie
      Differential Revision:
    • Tamar Christina's avatar
      Windows: Update the mirror script to generate hashes and use mirror fallback · 980e1270
      Tamar Christina authored
      This fixes the mirror script so it correctly queries and if
      packages aren't found check
      Also the mirror functionality now generates the md5 hashes after a
      mirror fetch that can be placed in the md5sums file.
      Test Plan:
       mk/ fetch mirror
       and ./validate
      Reviewers: austin, bgamari
      Reviewed By: bgamari
      Subscribers: rwbarton, thomie
      Differential Revision:
    • Tobias Dammers's avatar
      Make layLeft and reduceDoc stricter (#7258) · 2a4c24e4
      Tobias Dammers authored
      Making the pretty-printer based assembly output stricter in
      strategically chosen locations produces a minor performance improvement
      when compiling large derived Read instance (on the order of 5-10%).
      Reviewers: austin, bgamari
      Reviewed By: bgamari
      Subscribers: rwbarton, thomie
      Differential Revision:
    • Andreas Klebinger's avatar
      Add info about Github pull requests. · bd53b488
      Andreas Klebinger authored
    • Ben Gamari's avatar
      typecheck: Clarify errors mentioned in #14385 · bf83435b
      Ben Gamari authored
    • Joachim Breitner's avatar
      Make language extensions their own category in the documentation · 61f1b46e
      Joachim Breitner authored
      I.e. instead of
          .. ghc-flag:: -XUnboxedTuples
              :shortdesc: Enable the use of unboxed tuple syntax.
              :type: dynamic
              :reverse: -XNoUnboxedTuples
      one simply writes
          .. extension:: UnboxedTuples
              :shortdesc: Enable the use of unboxed tuple syntax.
      This allows language extensions to be referenced as
          If :extension:`UnboxedTuples` is enabled, then...
      This directive still creates the entries for the `-XUnboxedTuples` flag,
      so in particular,
          Set :ghc-flag:`-XUnboxedTuples` if you have to.
      still works, and lists of flags in general (e.g. for the manpage)
      include these.
      I also removed lots of links from the shortdesc of the extensions, when
      this link simply points to the section where the extension is defined.
      I removed the list of `-X` flags from the flag reference table, but added a
      table of extension under “10.1. Language options”
      Lots of text in the manual now refers to “extension `Foo`” rather than
      “flag `-XFoo`”.
      I consider `-XFoo` a historic artifact that stems from when language
      extensions were really just flags. These days, the use of `-XFoo` is
      (IMHO) deprecated: You should be using `LANGUAGE Foo`, or maybe the
      appropriate field in a `.cabal` file. See 9278994a which did this change
      to error messages already.
      Differential Revision:
    • Tamar Christina's avatar
      Revert "Update Win32 version for GHC 8.4." · b1ad0bb3
      Tamar Christina authored
      This reverts commit 561bdca1.
    • Tamar Christina's avatar
      Revert "ghc-cabal: Inline removed function ..." · 2e16a578
      Tamar Christina authored
      This reverts commit f744261a.
    • Tamar Christina's avatar
    • Tamar Christina's avatar
      Update Win32 version for GHC 8.4. · 561bdca1
      Tamar Christina authored
      Summary: Update to Win32 2.6 which is the expected version release for 8.4
      This bumps the required submodule s as well.
      Test Plan: ./validate
      Reviewers: austin, bgamari
      Reviewed By: bgamari
      Subscribers: rwbarton, thomie
      Differential Revision:
    • Tamar Christina's avatar
      Revert "Windows: Bump to GCC 7.2 for GHC 8.4" · e888a1ff
      Tamar Christina authored
      This reverts commit b62097d1.
    • Tamar Christina's avatar
      Windows: Bump to GCC 7.2 for GHC 8.4 · b62097d1
      Tamar Christina authored
      GHC 8.4 is expected to ship with an updated GCC bindist based on GCC 7.2.
      I am however at this time not updating the crt due to an issue introduced
      in september.
      Unless a favorable fix comes out of the discussion I will just ship the old crt
      with GHC 8.4.
      Test Plan: ./validate
      Reviewers: austin, bgamari
      Subscribers: rwbarton, thomie
      Differential Revision:
    • Tom Sydney Kerckhove's avatar
      Remove the 'legroom' part of the timeout-accurate-pure test. · 3825b7e2
      Tom Sydney Kerckhove authored
      This removes the part of the test that checks whether the timeout happened in
      a 'reasonable' amount of time, because it is flaky.
      In subsequent work, we can turn this into a benchmark.
      Test Plan: This _is_ a test
      Reviewers: nh2, bgamari, Phyx, austin, hvr
      Reviewed By: Phyx
      Subscribers: rwbarton, thomie
      GHC Trac Issues: #8684
      Differential Revision:
  7. 24 Oct, 2017 3 commits
  8. 23 Oct, 2017 4 commits