GitLab

Gabriella439 authored Feb 17, 2016 and Ben Gamari committed Feb 17, 2016

The Eq and Ord instance were previously hand-written and this change
updates them to be automatically derived by the compiler.  The derived
behavior should be equivalent to the original.

Reviewers: hvr, austin, bgamari

Reviewed By: bgamari

Subscribers: thomie

Differential Revision: https://phabricator.haskell.org/D1913

Previously, we looked through synonyms when counting arguments,
but that's a bit silly.

We have to instantiate any invisible arguments to type families
right away. This is now done in tcTyCon in TcHsType.

testcase: typecheck/should_compile/T11246

When renaming a type, now looks for wildcards in bound variables'
kinds.

testcase: dependent/should_compile/T11241

This addresses point (2) from #11513.

Related to the fix to Trac #9611

I discussed it with Richard, but this version is much
simmpler and more efficient.

Since we're not consisently keeping track of which tests should pass
with which compiler versions, there is no point in keeping these
functions.

Update submodules containers, hpc and stm.

Ben Gamari authored Feb 16, 2016 and Ben Gamari committed Feb 16, 2016

We just return an arbitrary value since we are destined to fail due to
the error anyways.

Fixes #11580.

Test Plan: Needs to be tested

Reviewers: austin

Subscribers: thomie

Differential Revision: https://phabricator.haskell.org/D1925

GHC Trac Issues: #11580

Ben Gamari authored Feb 16, 2016 and Ben Gamari committed Feb 16, 2016

This flag was supposed to be removed in 7.10. This finally resolves
Trac #8022.

Test Plan: Read it

Reviewers: austin

Reviewed By: austin

Subscribers: thomie

Differential Revision: https://phabricator.haskell.org/D1922

GHC Trac Issues: #8022

Yuras authored Feb 16, 2016 and Ben Gamari committed Feb 16, 2016

See Trac #9611. In "No instance..." error message we suggest instances
for other types with the same occ name. It is usefull e.g. when we have
two different versions of the same package installed.

Test Plan: typecheck/should_fail/tcfail224

Reviewers: austin, bgamari

Reviewed By: bgamari

Subscribers: thomie

Differential Revision: https://phabricator.haskell.org/D1919

GHC Trac Issues: #9611

Rik Steenkamp authored Feb 16, 2016 and Ben Gamari committed Feb 16, 2016

Reviewers: bgamari, austin

Reviewed By: austin

Subscribers: thomie

Differential Revision: https://phabricator.haskell.org/D1915

Peter Trommler authored Feb 16, 2016 and Ben Gamari committed Feb 16, 2016

On Linux assign F5 and F6 and D3 through D6 to caller-saved registers.

Fixes #11273

Test Plan: validate on powerpc (I validated on powerpc64)

Reviewers: bgamari, erikd, austin

Reviewed By: erikd, austin

Subscribers: thomie

Differential Revision: https://phabricator.haskell.org/D1914

GHC Trac Issues: #11273

Rik Steenkamp authored Feb 16, 2016 and Ben Gamari committed Feb 16, 2016

Replace `NoDataKinds :: PromotionErr` by `NoDataKindsTC` and
`NoDataKindsDC` (just like there is `NoTypeInTypeTC` and
`NoTypeInTypeDC`). This allows for a correct error message when a kind
signature contains a type constructor and `-XDataKinds` is not
specified.

Apply a small fix to `TcError.hs` where instead of "data constructor" we
should say "pattern synonym".

Reviewers: austin, goldfire, bgamari

Reviewed By: bgamari

Subscribers: goldfire, thomie

Differential Revision: https://phabricator.haskell.org/D1909

skvadrik authored Feb 16, 2016 and Ben Gamari committed Feb 16, 2016

There is ambiguty between (1) type constructors and (2) data
constructors in export lists, e.g. '%%' can stand for both of them. This
ambiguity is resolved in favor of (2).

If the exported data constructor is not in scope, but type constructor
with the same name is in scope, GHC should suggest adding 'type' keyword
to resolve ambiguity in favor of (1) and enabling 'TypeOperators'
extension.

The patch only extends the error message.

See Trac #11432.

Test Plan: `make test`

Reviewers: simonpj, bgamari, austin

Reviewed By: simonpj

Subscribers: mpickering, thomie, goldfire, kosmikus

Differential Revision: https://phabricator.haskell.org/D1902

GHC Trac Issues: #11432

Herbert Valerio Riedel authored Feb 16, 2016 and Ben Gamari committed Feb 16, 2016

Starting with GHC 8.0 we rely on GHC's native cabal macro generation.

As a side-effect, this limits the packages in scope when compiling
`ghc-cabal` for all bootstrapping GHCs.

Reviewers: ezyang, austin, thomie, bgamari

Reviewed By: thomie, bgamari

Differential Revision: https://phabricator.haskell.org/D1897

GHC Trac Issues: #11413

Update submodules stm, hpc and unix.

Differential Revision: https://phabricator.haskell.org/D1921

`-dunique-increment` doesn't work inside the file.

Test Plan: I've discovered it doesn't work in D1917.

Reviewers: simonpj, bgamari, austin

Subscribers: thomie, simonmar

Differential Revision: https://phabricator.haskell.org/D1918

GHC Trac Issues: #11361

This reproduces the issue that I encountered in #11362.

Test Plan: this testcase

Reviewers: simonpj, bgamari, austin

Reviewed By: simonpj

Subscribers: thomie, simonmar

Differential Revision: https://phabricator.haskell.org/D1917

GHC Trac Issues: #11362

This bug was revealed by Trac #11362.  It turns out that in my patch
for Trac #11148 (namely 1160dc51), I failed to turn one occurrence of
tvs' into full_tvs.  Sigh.  This is tricky stuff and it cost me
several hours to page it back in and figure out what was happening.

The result was a CoAxiom whose lhs had rhs had different kinds.  Eeek!

Anyway it's fixed.

I also added an ASSERT, in FamInst.newFamInst, that trips on such
bogus CoAxioms.

TcErrors has a system for suppressing some type errors if a more
serious one occurs.  But there was a crucial missing case, which
sometimes resulted in a cascade of irrelevant errors overwhelming
the actual cause. This was Trac #11541.

The fix is simple.  Worth merging to 8.0

When renaming a HsVar it can be converted to a HsRecField. In the
process the location of the enclosed name is converted to a noLoc

Closes #11576

be3d7f66

 added Show
instance for Callstack.

That made a couple of error messages to drift as:

             instance Show Ordering -- Defined in ‘GHC.Show’
             instance Show Integer -- Defined in ‘GHC.Show’
             ...plus 23 others
    -        ...plus 20 instances involving out-of-scope types
    +        ...plus 21 instances involving out-of-scope types
Signed-off-by: Sergei Trofimovich <siarheit@google.com>

- Document that you can use 'forall' in instance decls

- Change the sections a bit, so that big sections (like
  lexically scoped type variables, pattern synonyms,
  implicit parameters) become more visible

No change in behaviour

Reduces un-neede parens.

Also -fprint-typechecker-elaboration now makes type applications
and casts in expressions also appear.  (Previously those were
confusingly controlled by -fprint-explicit-coercions.)

Makes it a slightly more stringent test of record pattern bindings