1. 25 Jun, 2018 2 commits
  2. 24 Jun, 2018 1 commit
  3. 22 Jun, 2018 10 commits
    • Roland Senn's avatar
      Remove -Wamp flag · 33724fc7
      Roland Senn authored
      Test Plan: "ghc -Wamp XXX.hs"  should give "unrecognised warning flag"
      Reviewers: bgamari
      Reviewed By: bgamari
      Subscribers: rwbarton, thomie, carter
      GHC Trac Issues: #11477
      Differential Revision: https://phabricator.haskell.org/D4785
    • SantiM's avatar
      rts/linker/{SymbolExtras,elf_got}.c: map code as read-only · 67c422ca
      SantiM authored
      protect mmaped addresses from writes after being initially manipulated
      Test Plan: ./validate
      Reviewers: bgamari, erikd, simonmar
      Reviewed By: bgamari
      Subscribers: angerman, carlostome, rwbarton, thomie, carter
      GHC Trac Issues: #14069
      Differential Revision: https://phabricator.haskell.org/D4817
    • Ben Gamari's avatar
      rts: Abort if timerfd read fails · c7b1e93b
      Ben Gamari authored
      Currently we belch some output to stderr but fail to abort, resulting in
      a busy loop. Fixes #15292.
      Test Plan:
       * Validate
       * try running program under environment without timerfd capabilities;
      ensure we don't busy-loop
      Reviewers: simonmar, erikd
      Reviewed By: simonmar
      Subscribers: rwbarton, thomie, carter
      GHC Trac Issues: #15929
      Differential Revision: https://phabricator.haskell.org/D4875
    • Tao He's avatar
      Include ghc-heap and libiserv in the "package" file. · 63d474bb
      Tao He authored
      Previously, the `make clean` (as well as `make dist-clean`) doesn't work
      for ghc-heap and libiserv, due to these two libraries are not presented
      in the "packages" file.
      Test Plan: [skip ci]
      Reviewers: bgamari
      Reviewed By: bgamari
      Subscribers: rwbarton, thomie, carter
      Differential Revision: https://phabricator.haskell.org/D4878
    • Andreas Klebinger's avatar
      Explain why opt-cmm is not dumped by ddump-cmm-verbose. · 391b0caf
      Andreas Klebinger authored
      We just update the docs to reflect the state of affairs.
      opt-cmm is run by the NCG backend so not always run.
      ddump-cmm-verbose only dumps passes of the cmm
      pipeline so it's not included there. [skip-ci]
      Test Plan: doc change
      Reviewers: bgamari
      Reviewed By: bgamari
      Subscribers: rwbarton, thomie, carter
      Differential Revision: https://phabricator.haskell.org/D4879
    • Alan Zimmerman's avatar
      TTG for IPBind had wrong extension name · 5f06cf6b
      Alan Zimmerman authored
      The standard[1] for extension naming is to use the XC prefix for the
      internal extension points, rather than for a new constructor.
      This is violated for IPBind, having
          data IPBind id
            = IPBind
                  (XIPBind id)
                  (Either (Located HsIPName) (IdP id))
                  (LHsExpr id)
            | XCIPBind (XXIPBind id)
      Swap the usage of XIPBind and XCIPBind
      [1] https://ghc.haskell.org/trac/ghc/wiki/ImplementingTreesThatGrow#Namingconventions
      Closes #15302
    • Simon Peyton Jones's avatar
    • Simon Peyton Jones's avatar
      Remove unnecessary call to checkReductionDepth · d5459a33
      Simon Peyton Jones authored
      We call checkReductionDepth in chooseInstance, so there's no
      need to call it in selectNextWorkItem too
    • Simon Peyton Jones's avatar
      Refactor try_solve_fromInstance in shortCutSolver · e0653697
      Simon Peyton Jones authored
      This patch just removes the CtLoc parameter from trySolveFromInstance,
      since it can just as easily (and more uniformly) be gotten from the
      CtEvidence it is trying to solve.
    • Simon Peyton Jones's avatar
      Instances in no-evidence implications · 32eb4199
      Simon Peyton Jones authored
      Trac #15290 showed that it's possible that we might attempt to use a
      quantified constraint to solve an equality in a situation where we
      don't have anywhere to put the evidence bindings.  This made GHC crash.
      This patch stops the crash, but still rejects the pogram.  See
      Note [Instances in no-evidence implications] in TcInteract.
      Finding this bug revealed another lurking bug:
      * An infelicity in the treatment of superclasses -- we were expanding
        them locally at the leaves, rather than at their binding site; see
        (3a) in Note [The superclass story].
        As a consequence, TcRnTypes.superclassesMightHelp must look inside
      In more detail:
      * Stop the crash, by making TcInteract.chooseInstance test for
        the no-evidence-bindings case.  In that case we simply don't
        use the instance.  This entailed a slight change to the type
        of chooseInstance.
      * Make TcSMonad.getPendingScDicts (now renamed getPendingGivenScs)
        return only Givens from the /current level/; and make
        TcRnTypes.superClassesMightHelp look inside implications.
      * Refactor the simpl_loop and superclass-expansion stuff in
        TcSimplify.  The logic is much easier to understand now, and
        has less duplication.
  4. 21 Jun, 2018 2 commits
  5. 20 Jun, 2018 15 commits
  6. 19 Jun, 2018 6 commits
  7. 18 Jun, 2018 4 commits
    • Richard Eisenberg's avatar
      Fix typo in comment only · de692fd5
      Richard Eisenberg authored
      [skip ci]
    • Gabor Greif's avatar
      Typofixes in docs and comments [ci skip] · 6ac8a72f
      Gabor Greif authored
    • Simon Peyton Jones's avatar
      Fix typechecking of kind signatures · 30b029be
      Simon Peyton Jones authored
      When typechecking a type like
         Maybe (a :: <kind-sig>)
      with a kind signature, we were using tc_lhs_kind to
      typecheck the signature.  But that's utterly wrong; we
      need the signature to be fully solid (non unresolved
      equalities) before using it.  In the case of Trac #14904
      we went on to instantiate the kind signature, when it
      still had embedded unsolved constraints.  This tripped
      the level-checking assertion when unifying a variable.
      The fix looks pretty easy to me: just call tcLHsKind
      instead.  I had to add KindSigCtxt to
    • Simon Peyton Jones's avatar
      Two small refactorings · 850ae8c5
      Simon Peyton Jones authored
      * Define Type.substTyVarBndrs, and use it
      * Rename substTyVarBndrCallback to substTyVarBndrUsing,
        and other analogous higher order functions.  I kept
        stumbling over the name.