Missing images

added Wiki label

Can I leave this to you, @tdammers?

@bgamari I can't even access the Trac-page you referenced anymore. Maybe redirection should be turned off until some of the major concerns are solved.

@ulysses4ever, which page in particular?

@bgamari https://ghc.haskell.org/trac/ghc/wiki/Commentary/Rts — I assume there is a picture there, which is missing from the gitlab page. But I (and anyone without special access to old Trac) can't even see it anymore. That's why I'm saying maybe the Trac wiki should linger on for a while in the read-only mode.

@ulysses4ever, the Trac wiki and tickets do linger in read-only mode at https://trac.haskell.org/trac/ghc. You can find that particular page at https://trac.haskell.org/trac/ghc/wiki/Commentary/Rts.

I believe I mentioned this in my email a few days ago but email is transient; perhaps I should collect a summary of the current migration status either on the ghc/ghc> Wiki or in the readme of this repository.

@bgamari my bad, thank you for the explanation, Ben!

I've run into this particular page myself IIRC; the issue is a bit convoluted, but roughly this:

We have (or should have) imported all attachments (separately, and directly from the Trac database dump), so the images should all exist in gitlab.
During the ticket import, we also massaged links to attachments, so attachments on tickets should work.
However, the wiki import went through the actual Trac-rendered HTML, and so attachments linked from Wiki pages will still point to the old Trac URLs.

Unfortunately, gitlab mangles attachment filenames a bit, adding some sort of UUID (could also be a hash of the actual file contents), which is good in principle, but unfortunately makes it impossible to infer an attachment's GitLab URL from its Trac URL.

I'm still pondering how to solve this; fixing the import script and re-running the import would lead to plenty of diff noise on the wiki, and potentially undo some changes that have been made post-import, so this is out of the question; if anyone has any good ideas how we could do this in a way that is more elegant and less labor-prone than just manually sifting through the entire wiki and re-uploading all the missing attachments, I'd be grateful. If not, then maybe I'll have to come up with a clever script to somehow find broken image links in gitlab, try to find them in Trac, re-upload, and fix the link URL.

Another approach I've been pondering would be to see if there's a way to list all attachments in a gitlab instance via the API; then we could try to infer the correct URLs based on that list.

There are only 15 images on the entire Wiki:

$ grep '\[Image' *.trac | wc -l
15

I really don't think this is a task worth automating.

Ah yes, fair enough. On it.

(This is not a high-priority.)

Exploring hierarchically, there are a few more targets. However, it is also possible to do it manually.

Files:

find -name "*.trac" -exec grep "\[Image" {} \; -ls | grep "\.trac" |wc -l
36

Image tags:

find -name "*.trac" -exec grep "\[Image" {} \; | wc -l
103

(This is not a high-priority.)

In addition, there is another issue. Some image tags are blank [] in markdown.

.trac

https://trac.haskell.org/trac/ghc/wiki/Commentary/Compiler/Kinds#Kindsubtyping

[[Image(https://docs.google.com/drawings/pub?id=1M5yBP8iAWTgqdI3oG1UNnYihVlipnvvk2vLInAFxtNM&w=359&h=229)]]

.md

https://gitlab.haskell.org/ghc/ghc/wikis/commentary/compiler/kinds#kind-subtyping

[](https://docs.google.com/drawings/pub?id=1M5yBP8iAWTgqdI3oG1UNnYihVlipnvvk2vLInAFxtNM&w=359&h=229)

changed the description

marked the checklist item commentary/rts as completed

marked the checklist item commentary/compiler/kinds as completed

marked the checklist item commentary/compiler/hsc-main as completed

marked the checklist item commentary/compiler/hsc-pipe as completed

marked the checklist item commentary/compiler/key-data-types as completed

marked the checklist item commentary/compiler/stack-areas as completed

Missing images

Full list

Designs

Child items ...

Activity