HTTPS git endpoint broken since upgrade to 11.9
The (now-reverted) upgrade to GitLab 11.9 seems to have broke git access via HTTPS. Specifically accesses fail with:
Mar 25 15:03:31 gitlab.haskell.org unicorn[337]: I, [2019-03-25T15:03:31.610446 #9822] INFO -- : Processing by Projects::GitHttpController#info_refs as */*
Mar 25 15:03:31 gitlab.haskell.org unicorn[337]: I, [2019-03-25T15:03:31.610479 #9822] INFO -- : Parameters: {"service"=>"git-receive-pack", "namespace_id"=>"ghc", "project_id"=>"gh.git"}
Mar 25 15:03:31 gitlab.haskell.org hsanc2s3fk979zxsd2d2m5c74fvhf7hf-unit-script-postgresql-start[8867]: ERROR: column personal_access_tokens.token does not exist at character 142
Mar 25 15:03:31 gitlab.haskell.org hsanc2s3fk979zxsd2d2m5c74fvhf7hf-unit-script-postgresql-start[8867]: STATEMENT: SELECT "personal_access_tokens".* FROM "personal_access_tokens" WHERE (revoked = false AND (expires_at >= NOW() OR expires_at IS NULL)) AND "personal_access_tokens".
"token" = $1 LIMIT $2
Mar 25 15:03:31 gitlab.haskell.org unicorn[337]: I, [2019-03-25T15:03:31.621159 #9822] INFO -- : Completed 500 Internal Server Error in 11ms (ActiveRecord: 4.2ms | Elasticsearch: 0.0ms)
Mar 25 15:03:31 gitlab.haskell.org unicorn[337]: F, [2019-03-25T15:03:31.622989 #9822] FATAL -- :
Mar 25 15:03:31 gitlab.haskell.org unicorn[337]: F, [2019-03-25T15:03:31.623017 #9822] FATAL -- : ActiveRecord::StatementInvalid (PG::UndefinedColumn: ERROR: column personal_access_tokens.token does not exist
Mar 25 15:03:31 gitlab.haskell.org unicorn[337]: LINE 1: ... (expires_at >= NOW() OR expires_at IS NULL)) AND "personal_... Mar 25 15:03:31 gitlab.haskell.org unicorn[337]: ^
Mar 25 15:03:31 gitlab.haskell.org unicorn[337]: : SELECT "personal_access_tokens".* FROM "personal_access_tokens" WHERE (revoked = false AND (expires_at >= NOW() OR expires_at IS NULL)) AND "personal_access_tokens"."token" = $1 LIMIT $2):
Mar 25 15:03:31 gitlab.haskell.org unicorn[337]: F, [2019-03-25T15:03:31.623031 #9822] FATAL -- :
Mar 25 15:03:31 gitlab.haskell.org unicorn[337]: F, [2019-03-25T15:03:31.623051 #9822] FATAL -- : app/models/concerns/token_authenticatable_strategies/insecure.rb:6:in `find_token_authenticatable'
Mar 25 15:03:31 gitlab.haskell.org unicorn[337]: app/models/concerns/token_authenticatable_strategies/digest.rb:11:in `find_token_authenticatable'
Mar 25 15:03:31 gitlab.haskell.org unicorn[337]: app/models/concerns/token_authenticatable.rb:25:in `block in add_authentication_token_field'
Mar 25 15:03:31 gitlab.haskell.org unicorn[337]: lib/gitlab/metrics/instrumentation.rb:161:in `block in find_by_token'
Mar 25 15:03:31 gitlab.haskell.org unicorn[337]: lib/gitlab/metrics/method_call.rb:36:in `measure'
Mar 25 15:03:31 gitlab.haskell.org unicorn[337]: lib/gitlab/metrics/instrumentation.rb:161:in `find_by_token'
Mar 25 15:03:31 gitlab.haskell.org unicorn[337]: app/finders/personal_access_tokens_finder.rb:6:in `find_by_token'
Mar 25 15:03:31 gitlab.haskell.org unicorn[337]: lib/gitlab/metrics/instrumentation.rb:161:in `block in find_by_token'
Mar 25 15:03:31 gitlab.haskell.org unicorn[337]: lib/gitlab/metrics/method_call.rb:36:in `measure'
Mar 25 15:03:31 gitlab.haskell.org unicorn[337]: lib/gitlab/metrics/instrumentation.rb:161:in `find_by_token'
Mar 25 15:03:31 gitlab.haskell.org unicorn[337]: lib/gitlab/auth.rb:162:in `personal_access_token_check'
Mar 25 15:03:31 gitlab.haskell.org unicorn[337]: lib/gitlab/auth.rb:39:in `find_for_git_client'
Mar 25 15:03:31 gitlab.haskell.org unicorn[337]: app/controllers/projects/git_http_client_controller.rb:102:in `handle_basic_authentication'
Mar 25 15:03:31 gitlab.haskell.org unicorn[337]: app/controllers/projects/git_http_client_controller.rb:38:in `authenticate_user'
Mar 25 15:03:31 gitlab.haskell.org unicorn[337]: ee/app/controllers/ee/projects/git_http_controller.rb:48:in `authenticate_user'
Mar 25 15:03:31 gitlab.haskell.org unicorn[337]: lib/gitlab/i18n.rb:55:in `with_locale'
Mar 25 15:03:31 gitlab.haskell.org unicorn[337]: lib/gitlab/i18n.rb:61:in `with_user_locale'
Mar 25 15:03:31 gitlab.haskell.org unicorn[337]: app/controllers/application_controller.rb:423:in `set_locale'
Mar 25 15:03:31 gitlab.haskell.org unicorn[337]: lib/gitlab/middleware/rails_queue_duration.rb:24:in `call'
Mar 25 15:03:31 gitlab.haskell.org unicorn[337]: lib/gitlab/metrics/rack_middleware.rb:17:in `block in call'
Mar 25 15:03:31 gitlab.haskell.org unicorn[337]: lib/gitlab/metrics/transaction.rb:55:in `run'
Mar 25 15:03:31 gitlab.haskell.org unicorn[337]: lib/gitlab/metrics/rack_middleware.rb:17:in `call'
Mar 25 15:03:31 gitlab.haskell.org unicorn[337]: lib/gitlab/middleware/multipart.rb:103:in `call'
Mar 25 15:03:31 gitlab.haskell.org unicorn[337]: lib/gitlab/request_profiler/middleware.rb:16:in `call'
Mar 25 15:03:31 gitlab.haskell.org unicorn[337]: ee/lib/gitlab/jira/middleware.rb:17:in `call'
Mar 25 15:03:31 gitlab.haskell.org unicorn[337]: lib/gitlab/middleware/go.rb:20:in `call'
Mar 25 15:03:31 gitlab.haskell.org unicorn[337]: lib/gitlab/etag_caching/middleware.rb:13:in `call'
Mar 25 15:03:31 gitlab.haskell.org unicorn[337]: lib/gitlab/middleware/correlation_id.rb:16:in `block in call'
Mar 25 15:03:31 gitlab.haskell.org unicorn[337]: lib/gitlab/correlation_id.rb:15:in `use_id' Mar 25 15:03:31 gitlab.haskell.org unicorn[337]: lib/gitlab/middleware/correlation_id.rb:15:in `call'
Mar 25 15:03:31 gitlab.haskell.org unicorn[337]: lib/gitlab/middleware/read_only/controller.rb:42:in `call'
Mar 25 15:03:31 gitlab.haskell.org unicorn[337]: lib/gitlab/middleware/read_only.rb:18:in `call'
Mar 25 15:03:31 gitlab.haskell.org unicorn[337]: lib/gitlab/middleware/basic_health_check.rb:25:in `call'
Mar 25 15:03:31 gitlab.haskell.org unicorn[337]: lib/gitlab/request_context.rb:20:in `call'
Mar 25 15:03:31 gitlab.haskell.org unicorn[337]: lib/gitlab/metrics/requests_rack_middleware.rb:29:in `call'
Mar 25 15:03:31 gitlab.haskell.org unicorn[337]: lib/gitlab/middleware/release_env.rb:13:in `call'