GHC merge requestshttps://gitlab.haskell.org/davjam/ghc/-/merge_requests2022-04-11T10:40:54Zhttps://gitlab.haskell.org/davjam/ghc/-/merge_requests/2Draft: Additional Float value tests in Windows (#15670, #20424)2022-04-11T10:40:54ZdavjamDraft: Additional Float value tests in Windows (#15670, #20424)Following !7480 (which also reenabled FloatFnInverses test), added extra tests for asinh 0.0 (should be 0.0, not -0.0) etc.
**Where is the key part of this patch? That is, what should reviewers look at first?**
ghc\testsuite\tests\nume...Following !7480 (which also reenabled FloatFnInverses test), added extra tests for asinh 0.0 (should be 0.0, not -0.0) etc.
**Where is the key part of this patch? That is, what should reviewers look at first?**
ghc\testsuite\tests\numeric\should_run\all.T adds new test file FloatValues.hs
Please take a few moments to verify that your commits fulfill the following:
* [X] are either individually buildable or squashed
* [ ] have commit messages which describe *what they do*
(referring to [Notes][notes] and tickets using `#NNNN` syntax when
appropriate)
* [ ] have added source comments describing your change. For larger changes you
likely should add a [Note][notes] and cross-reference it from the relevant
places.
* [X] add a [testcase to the testsuite](https://gitlab.haskell.org/ghc/ghc/wikis/building/running-tests/adding).
* [ ] if your MR affects library interfaces (e.g. changes `base`) or affects whether GHC will accept user-written code, please add
the ~"user facing" label.
* [ ] updates the users guide if applicable
* [ ] mentions new features in the release notes for the next release
If you have any questions don't hesitate to open your merge request and inquire
in a comment. If your patch isn't quite done yet please do add prefix your MR
title with `WIP:`.
Once your change is ready please remove the `WIP:` tag and wait for review. If
no one has offerred review in a few days then please leave a comment mentioning
@triagers.
[notes]: https://gitlab.haskell.org/ghc/ghc/wikis/commentary/coding-style#comments-in-the-source-codehttps://gitlab.haskell.org/davjam/ghc/-/merge_requests/1DRAFT: Reenabled Float value tests in Windows (#15670, #20424)2022-02-23T16:15:03ZdavjamDRAFT: Reenabled Float value tests in Windows (#15670, #20424)added tests for +/0 etc, and reenabled FloatFnInverses.
This commit does not fix the issues. That needs to be fixed upstream in mingw-w64. However it does turn (back) on tests that should pass once the upstream fix is integrated.added tests for +/0 etc, and reenabled FloatFnInverses.
This commit does not fix the issues. That needs to be fixed upstream in mingw-w64. However it does turn (back) on tests that should pass once the upstream fix is integrated.