When calling as cc
, GCC does not outputs lowercased "gcc" at least in 13.2.1 version here.
$ cc --version
cc (GCC) 13.2.1 20230801
...
This fails the check and outputs the confusing message: configure: $CC is not gcc; assuming it's a reasonably new C compiler
This patch makes it check for upper-cased "GCC" too so that it works correctly:
checking version of gcc... 13.2.1
Thank you for your contribution to GHC!
Please read the checklist below to make sure your contribution fulfills these expectations. Also please answer the following question in your MR description:
Where is the key part of this patch? That is, what should reviewers look at first?
Please take a few moments to address the following points:
base
or causes the
compiler to reject programs), please describe the expected breakage and add
the user-facing label. This will run ghc/head.hackage> to characterise
the effect of your change on Hackage.#NNNN
syntax when appropriate)If you have any questions don't hesitate to open your merge request and inquire
in a comment. If your patch isn't quite done yet please do add prefix your MR
title with WIP:
.
By default a minimal validation pipeline is run on each merge request, the full-ci label can be applied to perform additional validation checks if your MR affects a more unusual configuration.
Once your change is ready please remove the WIP:
tag and wait for review. If
no one has offered a review in a few days then please leave a comment mentioning
@triagers and apply the Blocked on Review label.
Felix Yan (6dd0cfa0) at 25 Feb 19:04
m4: Correctly detect GCC version
Felix Yan (cf756a25) at 25 Feb 19:03
rts: Fix symbol references in Wasm RTS
... and 6432 more commits
It seems with LLVM 15.0.6 here, opt-15 doesn't work with -passes=tbaa
at all:
opt-15: unknown pass name 'tbaa'
@bgamari The motivation for removing it was that, the motivation for adding it was wrong in the first place, as I stated in the OP.
I have no problem keeping it around, though.
Felix Yan (300a937a) at 13 Jul 08:05
ATTR_NOINLINE is not needed for evacuate_large
... and 145 more commits
In #12416, the commit message states that the fix in #17944 didn't succeed. In my experiments on Arch Linux, it was because that the definition in line 61 wasn't updated accordingly.
The inline error is still present here with the change in #17944, but after removing "STATIC_INLINE" from line 61, it's gone.
Thus I think ATTR_NOINLINE is not needed here.
Felix Yan (5efc75da) at 06 Jun 21:48
ATTR_NOINLINE is not needed for evacuate_large
... and 1628 more commits