Skip to content
  • batterseapower's avatar
    Big patch to improve Unicode support in GHC. Validated on OS X and Windows, this · dc58b739
    batterseapower authored
    patch series fixes #5061, #1414, #3309, #3308, #3307, #4006 and #4855.
    
    The major changes are:
    
     1) Make Foreign.C.String.*CString use the locale encoding
    
        This change follows the FFI specification in Haskell 98, which
        has never actually been implemented before.
    
        The functions exported from Foreign.C.String are partially-applied
        versions of those from GHC.Foreign, which allows the user to supply
        their own TextEncoding.
    
        We also introduce foreignEncoding as the name of the text encoding
        that follows the FFI appendix in that it transliterates encoding
        errors.
    
     2) I also changed the code so that mkTextEncoding always tries the
        native-Haskell decoders in preference to those from iconv, even on
        non-Windows. The motivation here is simply that it is better for
        compatibility if we do this, and those are the ones you get for
        the utf* and latin1* predefined TextEncodings anyway.
    
     3) Implement surrogate-byte error handling mode for TextEncoding
    
        This implements PEP383-like behaviour so that we are able to
        roundtrip byte strings through Strings without loss of information.
    
        The withFilePath function now uses this encoding to get to/from CStrings,
        so any code that uses that will get the right PEP383 behaviour automatically.
    
     4) Implement three other coding failure modes: ignore, throw error, transliterate
    
        These mimic the behaviour of the GNU Iconv extensions.
    dc58b739