Commit 71a42356 authored by Ben Gamari's avatar Ben Gamari Committed by Ben Gamari
Browse files

configure: Fix CC version check on Apple compilers

It seems that some Apple LLVM wrappers emit multiple messages containing
the string "version", which we previously used to find the version
number.  For instance,

    Configured with: --prefix=/Applications/
    Apple LLVM version 9.0.0 (clang-900.0.37)
    Target: x86_64-apple-darwin16.7.0
    Thread model: posix
    InstalledDir: /Applications/
    Found CUDA installation: /usr/local/cuda, version 8.0

We now take care to only look at the first occurrence of this string.

New `sed` command due to @merijn.

Test Plan: Validate on all the compilers

Reviewers: austin, hvr

Subscribers: rwbarton, thomie, merijn, erikd

Differential Revision:
parent 6cc232ae
......@@ -1234,7 +1234,9 @@ GccLT44=NO
AC_CACHE_CHECK([version of gcc], [fp_cv_gcc_version],
fp_cv_gcc_version="`$CC -v 2>&1 | grep 'version ' | sed -e 's/.*version [[^0-9]]*\([[0-9.]]*\).*/\1/g'`"
# Be sure only to look at the first occurrence of the "version " string;
# Some Apple compilers emit multiple messages containing this string.
fp_cv_gcc_version="`$CC -v 2>&1 | sed -n -e '1,/version /s/.*version [[^0-9]]*\([[0-9.]]*\).*/\1/p'`"
FP_COMPARE_VERSIONS([$fp_cv_gcc_version], [-lt], [3.0],
[AC_MSG_ERROR([Need at least gcc version 3.0 (3.4+ recommended)])])
# See #2770: gcc 2.95 doesn't work any more, apparently. There probably
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment