From f656fba19d0cefe05643ddea35d080ea332a6584 Mon Sep 17 00:00:00 2001 From: Tamar Christina <tamar@zhox.com> Date: Thu, 13 Jul 2017 21:06:49 +0100 Subject: [PATCH] [skip ci] Temporarily disable split-sections on Windows. Summary: This temporarily disabled split-sections again on Windows because of the overhead in linking it introduces. Unfortunately because BFD is so slow a testsuite run gets almost 2x slower. Simply linking Hello World takes an unacceptable long time. So for now, it'll be disabled as we look into different linkers such as LLD. Test Plan: ./validate Reviewers: austin, bgamari Subscribers: rwbarton, thomie GHC Trac Issues: #12913 Differential Revision: https://phabricator.haskell.org/D3731 --- mk/config.mk.in | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/mk/config.mk.in b/mk/config.mk.in index 88f3b51600a..2e920ca76ef 100644 --- a/mk/config.mk.in +++ b/mk/config.mk.in @@ -357,8 +357,9 @@ SplitObjs = $(if $(and $(filter YES,$(SupportsSplitObjs)),\ # Set SplitSections=YES or NO in your build.mk to override the default. # # This is not supported on Darwin (where you can use subsections-via-symbols -# instead) and Windows is not yet working. (See #11445 and related tickets.) -OsSupportsSplitSections=$(if $(filter $(TargetOS_CPP),darwin),NO,YES) +# instead) and Windows is disabled until we figure the linking performance +# issues related to BFD out. (See #11445, #12913 and related tickets.) +OsSupportsSplitSections=$(if $(filter $(TargetOS_CPP),mingw32 darwin),NO,YES) SupportsSplitSections=$(if $(and $(filter YES,$(OsSupportsSplitSections)),\ $(filter YES,$(LdIsGNULd))),YES,NO) SplitSections ?= $(SupportsSplitSections) -- GitLab