1. 23 Dec, 2018 1 commit
  2. 22 Dec, 2018 10 commits
  3. 21 Dec, 2018 19 commits
  4. 20 Dec, 2018 3 commits
  5. 19 Dec, 2018 7 commits
    • Ryan Scott's avatar
      Fix #16030 by refactoring IfaceSyn's treatment of GADT constructors · 9d9e3557
      Ryan Scott authored
      Summary:
      GHCi's `:info` command was pretty-printined GADT
      constructors suboptimally in the following ways:
      
      1. Sometimes, fields were parenthesized when they did not need it,
         e.g.,
      
      ```lang=haskell
      data Foo a where
        MkFoo :: (Maybe a) -> Foo a
      ```
      
         I fixed this by refactoring some code in `pprIfaceConDecl` to be a
         little smarter with respect to GADT syntax. See `pprFieldArgTy`
         and `pprArgTy`.
      2. With `-fprint-explicit-kinds` enabled, there would be times when
         specified arguments would be printed without a leading `@` in GADT
         return types, e.g.,
      
      ```lang=haskell
      data Bar @k (a :: k) where
        MkBar :: Bar k a
      ```
      
         It turns out that `ppr_tc_app`, the function which pretty-prints
         these return types, was not using the proper machinery to print
         out the arguments, which caused the visibilities to be forgotten
         entirely. I refactored `ppr_tc_app` to do this correctly.
      
      Test Plan: make test TEST=T16030
      
      Reviewers: goldfire, bgamari, simonpj
      
      Reviewed By: simonpj
      
      Subscribers: simonpj, rwbarton, carter
      
      GHC Trac Issues: #16030
      
      Differential Revision: https://phabricator.haskell.org/D5440
      9d9e3557
    • Krzysztof Gogolewski's avatar
      Use unicode arrows with -fprint-unicode-syntax · d555d4be
      Krzysztof Gogolewski authored
      Summary:
      See #8959, this is one more place where we
      can pretty-print Unicode syntax.
      
      Test Plan: validate
      
      Reviewers: nomeata, bgamari
      
      Reviewed By: bgamari
      
      Subscribers: rwbarton, carter
      
      GHC Trac Issues: #8959
      
      Differential Revision: https://phabricator.haskell.org/D5439
      d555d4be
    • chessai's avatar
      don't suggest Rank2Types in error messages (Fixed #16000) · de50f8fd
      chessai authored
      Summary: Rank2Types is deprecated. Don't suggest to users to use it.
      
      Reviewers: bgamari, RyanGlScott, simonpj
      
      Reviewed By: RyanGlScott, simonpj
      
      Subscribers: RyanGlScott, rwbarton, carter
      
      GHC Trac Issues: #16000
      
      Differential Revision: https://phabricator.haskell.org/D5447
      de50f8fd
    • Ben Gamari's avatar
      gitlab-ci: Split build into two halves · 68d6a716
      Ben Gamari authored
      Currently we are having quite some trouble keeping up with our build volume due
      to the number of configurations we have. I've split the pipeline into two
      halves:
      
       * build, which builds just vanilla deb9-linux with make and hadrian
       * full-build, which builds everything else
      
      This will trade-off some latency to more efficient use of our builders.
      68d6a716
    • Ben Gamari's avatar
      gitlab-ci: Fix locale on Darwin only · 9fe30418
      Ben Gamari authored
      Setting LANG causes trouble on Debian.
      9fe30418
    • Gabor Greif's avatar
      909580cc
    • Ben Gamari's avatar
      gitlab-ci: Ensure that locale is set · 074eae25
      Ben Gamari authored
      074eae25