Skip to content
GitLab
Projects
Groups
Snippets
Help
Loading...
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Sign in / Register
Toggle navigation
GHC
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Locked Files
Issues
0
Issues
0
List
Boards
Labels
Service Desk
Milestones
Iterations
Merge Requests
0
Merge Requests
0
Requirements
Requirements
List
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Security & Compliance
Security & Compliance
Dependency List
License Compliance
Operations
Operations
Incidents
Environments
Packages & Registries
Packages & Registries
Package Registry
Container Registry
Analytics
Analytics
CI / CD
Code Review
Insights
Issue
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
Fumiaki Kinoshita
GHC
Commits
20b5dfc2
Commit
20b5dfc2
authored
Feb 13, 2017
by
Gabor Greif
💬
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Typos in notes and comments [ci skip]
parent
7666a9fe
Changes
5
Hide whitespace changes
Inline
Side-by-side
Showing
5 changed files
with
7 additions
and
7 deletions
+7
-7
compiler/simplCore/OccurAnal.hs
compiler/simplCore/OccurAnal.hs
+3
-3
compiler/simplCore/Simplify.hs
compiler/simplCore/Simplify.hs
+1
-1
compiler/typecheck/TcCanonical.hs
compiler/typecheck/TcCanonical.hs
+1
-1
compiler/typecheck/TcHsType.hs
compiler/typecheck/TcHsType.hs
+1
-1
testsuite/tests/simplCore/should_run/T11731.hs
testsuite/tests/simplCore/should_run/T11731.hs
+1
-1
No files found.
compiler/simplCore/OccurAnal.hs
View file @
20b5dfc2
...
...
@@ -1907,7 +1907,7 @@ A: Saturated applications: eg f e1 .. en
In general, given a call (f e1 .. en) we can propagate one-shot info from
f's strictness signature into e1 .. en, but /only/ if n is enough to
saturate the strictness signature. A strict
e
ness signature like
saturate the strictness signature. A strictness signature like
f :: C1(C1(L))LS
...
...
@@ -1924,10 +1924,10 @@ A: Saturated applications: eg f e1 .. en
then the first argument of f will be called at most once.
A': Non-obviously satuated applications: eg build (f (\x y -> expensive))
A': Non-obviously satu
r
ated applications: eg build (f (\x y -> expensive))
In this case, f is only manifestly applied to one argument, so it does not
look saturated. So by
e
the previous point, we should not use its strictness
look saturated. So by the previous point, we should not use its strictness
signature to learn about the one-shotness of \x y. But in this case we can:
build is fully applied, so we may use its strictness signature. From that
...
...
compiler/simplCore/Simplify.hs
View file @
20b5dfc2
...
...
@@ -2283,7 +2283,7 @@ simplAlts env scrut case_bndr alts cont'
;
(
env1
,
case_bndr1
)
<-
simplBinder
env0
case_bndr
;
let
case_bndr2
=
case_bndr1
`
setIdUnfolding
`
evaldUnfolding
env2
=
modifyInScope
env1
case_bndr2
-- See Note [Case
-
binder evaluated-ness]
-- See Note [Case
binder evaluated-ness]
;
fam_envs
<-
getFamEnvs
;
(
alt_env'
,
scrut'
,
case_bndr'
)
<-
improveSeq
fam_envs
env2
scrut
...
...
compiler/typecheck/TcCanonical.hs
View file @
20b5dfc2
...
...
@@ -443,7 +443,7 @@ mk_superclasses_of rec_clss ev cls tys
where
cls_nm
=
className
cls
loop_found
=
not
(
isCTupleClass
cls
)
&&
cls_nm
`
elemNameSet
`
rec_clss
-- Tuples neve
e
r contribute to recursion, and can be nested
-- Tuples never contribute to recursion, and can be nested
rec_clss'
=
rec_clss
`
extendNameSet
`
cls_nm
this_ct
=
CDictCan
{
cc_ev
=
ev
,
cc_class
=
cls
,
cc_tyargs
=
tys
,
cc_pend_sc
=
loop_found
}
...
...
compiler/typecheck/TcHsType.hs
View file @
20b5dfc2
...
...
@@ -1061,7 +1061,7 @@ Trac #11554 shows this example, which made GHC loop:
data A :: Type where
B :: forall (a :: A). P a -> A
In order to check the constructor B, we need have the promoted type A, but in
In order to check the constructor B, we need
to
have the promoted type A, but in
order to get that promoted type, B must first be checked. To prevent looping, a
TyConPE promotion error is given when tcTyVar checks an ATcTyCon in kind mode.
Any ATcTyCon is a TyCon being defined in the current recursive group (see data
...
...
testsuite/tests/simplCore/should_run/T11731.hs
View file @
20b5dfc2
...
...
@@ -10,7 +10,7 @@ wwMe :: Int -> (Int,Int) -> (Int, Int)
wwMe
0
p
=
let
a
=
fst
p
b
=
snd
p
-- This ensure sharing of b, as seen by the demand analyzer
-- This ensure
s
sharing of b, as seen by the demand analyzer
in
foo
p
`
seq
`
-- This ensures that wwMe is strict in the tuple, but that the tuple
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment