From 68f38e40b1cf973442d35344df61bfaf9125b139 Mon Sep 17 00:00:00 2001
From: Ben Gamari <ben@smart-cactus.org>
Date: Mon, 23 Nov 2015 00:01:16 +0100
Subject: [PATCH] Address @epristley's comments
---
ArcanistExternalJsonLinter.php | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/ArcanistExternalJsonLinter.php b/ArcanistExternalJsonLinter.php
index df83e91..ca5d16d 100644
--- a/ArcanistExternalJsonLinter.php
+++ b/ArcanistExternalJsonLinter.php
@@ -144,7 +144,7 @@ final class ArcanistExternalJsonLinter extends ArcanistLinter {
return;
}
- $messages = json_decode($output, true);
+ $messages = phutil_json_decode($output, true);
foreach ($messages as $message) {
if (!empty($message['throw'])) {
@@ -257,7 +257,7 @@ final class ArcanistExternalJsonLinter extends ArcanistLinter {
);
if (idx($message, 'severity')) {
- $severity_name = strtolower(idx($message, 'severity'));
+ $severity_name = phutil_utf8_strtolower(idx($message, 'severity'));
if (!idx($map, $severity_name)) {
throw new ArcanistUsageException(
pht('%s: Unknown severity %s', __CLASS__, $severity_name));
--
GitLab