TcErrors.lhs 50.5 KB
Newer Older
1
\begin{code}
2
{-# LANGUAGE ScopedTypeVariables #-}
Ian Lynagh's avatar
Ian Lynagh committed
3 4 5 6 7 8 9
{-# OPTIONS -fno-warn-tabs #-}
-- The above warning supression flag is a temporary kludge.
-- While working on this module you are encouraged to remove it and
-- detab the module (please do the detabbing in a separate patch). See
--     http://hackage.haskell.org/trac/ghc/wiki/Commentary/CodingStyle#TabsvsSpaces
-- for details

10
module TcErrors( 
11
       reportUnsolved, reportAllUnsolved,
12
       warnDefaulting,
13 14

       solverDepthErrorTcS
15 16 17 18
  ) where

#include "HsVersions.h"

19
import TcRnTypes
20 21 22
import TcRnMonad
import TcMType
import TcType
23
import TypeRep
batterseapower's avatar
batterseapower committed
24
import Type
25
import Kind ( isKind )
26
import Unify            ( tcMatchTys )
27 28 29
import Inst
import InstEnv
import TyCon
30
import TcEvidence
31
import Name
32
import Id 
33 34 35 36
import Var
import VarSet
import VarEnv
import Bag
37 38
import Maybes
import ErrUtils         ( ErrMsg, makeIntoWarning, pprLocErrMsg )
39
import BasicTypes 
40 41 42
import Util
import FastString
import Outputable
43
import SrcLoc
44
import DynFlags
45
import Data.List        ( partition, mapAccumL )
46 47 48 49 50 51 52 53 54 55 56 57
\end{code}

%************************************************************************
%*									*
\section{Errors and contexts}
%*									*
%************************************************************************

ToDo: for these error messages, should we note the location as coming
from the insts, or just whatever seems to be around in the monad just
now?

58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76
Note [Deferring coercion errors to runtime]
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
While developing, sometimes it is desirable to allow compilation to succeed even
if there are type errors in the code. Consider the following case:

  module Main where

  a :: Int
  a = 'a'

  main = print "b"

Even though `a` is ill-typed, it is not used in the end, so if all that we're
interested in is `main` it is handy to be able to ignore the problems in `a`.

Since we treat type equalities as evidence, this is relatively simple. Whenever
we run into a type mismatch in TcUnify, we normally just emit an error. But it
is always safe to defer the mismatch to the main constraint solver. If we do
that, `a` will get transformed into
77

78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94
  co :: Int ~ Char
  co = ...

  a :: Int
  a = 'a' `cast` co

The constraint solver would realize that `co` is an insoluble constraint, and
emit an error with `reportUnsolved`. But we can also replace the right-hand side
of `co` with `error "Deferred type error: Int ~ Char"`. This allows the program
to compile, and it will run fine unless we evaluate `a`. This is what
`deferErrorsToRuntime` does.

It does this by keeping track of which errors correspond to which coercion
in TcErrors. TcErrors.reportTidyWanteds does not print the errors
and does not fail if -fwarn-type-errors is on, so that we can continue
compilation. The errors are turned into warnings in `reportUnsolved`.

95 96 97 98 99
Note [Suppressing error messages]
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
If there are any insolubles, like (Int~Bool), then we suppress all less-drastic
errors (like (Eq a)).  Often the latter are a knock-on effect of the former.

100 101 102 103
\begin{code}
reportUnsolved :: WantedConstraints -> TcM (Bag EvBind)
reportUnsolved wanted
  = do { binds_var <- newTcEvBinds
ian@well-typed.com's avatar
ian@well-typed.com committed
104
       ; defer <- goptM Opt_DeferTypeErrors
105 106 107 108 109 110
       ; report_unsolved (Just binds_var) defer wanted
       ; getTcEvBinds binds_var }

reportAllUnsolved :: WantedConstraints -> TcM ()
-- Report all unsolved goals, even if -fdefer-type-errors is on
-- See Note [Deferring coercion errors to runtime]
Simon Peyton Jones's avatar
Simon Peyton Jones committed
111
reportAllUnsolved wanted = report_unsolved Nothing False wanted
112 113 114 115

report_unsolved :: Maybe EvBindsVar  -- cec_binds
                -> Bool              -- cec_defer
                -> WantedConstraints -> TcM ()
116 117 118
-- Important precondition:
-- WantedConstraints are fully zonked and unflattened, that is,
-- zonkWC has already been applied to these constraints.
119
report_unsolved mb_binds_var defer wanted
120
  | isEmptyWC wanted
121
  = return ()
122
  | otherwise
123
  = do { traceTc "reportUnsolved (before unflattening)" (ppr wanted)
124

125
       ; env0 <- tcInitTidyEnv
126 127 128
                 
            -- If we are deferring we are going to need /all/ evidence around,
            -- including the evidence produced by unflattening (zonkWC)
129
       ; let tidy_env = tidyFreeTyVars env0 free_tvs
130
             free_tvs = tyVarsOfWC wanted
131
             err_ctxt = CEC { cec_encl  = []
132
                            , cec_tidy  = tidy_env
133
                            , cec_defer    = defer
134
                            , cec_suppress = insolubleWC wanted
135
                                  -- See Note [Suppressing error messages]
136
                            , cec_binds    = mb_binds_var }
137

138 139 140
       ; traceTc "reportUnsolved (after unflattening):" $ 
         vcat [ pprTvBndrs (varSetElems free_tvs)
              , ppr wanted ]
141

142
       ; reportWanteds err_ctxt wanted }
143

144 145 146
--------------------------------------------
--      Internal functions
--------------------------------------------
147 148 149 150

data ReportErrCtxt 
    = CEC { cec_encl :: [Implication]  -- Enclosing implications
                	       	       --   (innermost first)
151
                                       -- ic_skols and givens are tidied, rest are not
152
          , cec_tidy  :: TidyEnv
153 154 155 156 157
          , cec_binds :: Maybe EvBindsVar 
                         -- Nothinng <=> Report all errors, including holes; no bindings
                         -- Just ev  <=> make some errors (depending on cec_defer)
                         --              into warnings, and emit evidence bindings
                         --              into 'ev' for unsolved constraints
158

159 160
          , cec_defer :: Bool       -- True <=> -fdefer-type-errors
                                    -- Irrelevant if cec_binds = Nothing
161 162 163
          , cec_suppress :: Bool    -- True <=> More important errors have occurred,
                                    --          so create bindings if need be, but
                                    --          don't issue any more errors/warnings
164 165
      }

166 167 168
reportImplic :: ReportErrCtxt -> Implication -> TcM ()
reportImplic ctxt implic@(Implic { ic_skols = tvs, ic_given = given
                                 , ic_wanted = wanted, ic_binds = evb
Simon Peyton Jones's avatar
Simon Peyton Jones committed
169
                                 , ic_insol = ic_insoluble, ic_info = info })
170
  | BracketSkol <- info
Simon Peyton Jones's avatar
Simon Peyton Jones committed
171 172 173 174
  , not ic_insoluble -- For Template Haskell brackets report only
  = return ()        -- definite errors. The whole thing will be re-checked
                     -- later when we plug it in, and meanwhile there may
                     -- certainly be un-satisfied constraints
175 176

  | otherwise
177
  = reportWanteds ctxt' wanted
178
  where
179
    (env1, tvs') = mapAccumL tidyTyVarBndr (cec_tidy ctxt) tvs
180
    (env2, info') = tidySkolemInfo env1 info
181
    implic' = implic { ic_skols = tvs'
182 183 184
                     , ic_given = map (tidyEvVar env2) given
                     , ic_info  = info' }
    ctxt' = ctxt { cec_tidy  = env2
185
                 , cec_encl  = implic' : cec_encl ctxt
186
                 , cec_binds = case cec_binds ctxt of
187 188 189 190 191
                                 Nothing -> Nothing
                                 Just {} -> Just evb }

reportWanteds :: ReportErrCtxt -> WantedConstraints -> TcM ()
reportWanteds ctxt (WC { wc_flat = flats, wc_insol = insols, wc_impl = implics })
192 193
  = do { reportFlats (ctxt { cec_suppress = False }) (mapBag (tidyCt env) insols)
       ; reportFlats ctxt                            (mapBag (tidyCt env) flats)
194 195 196 197
            -- All the Derived ones have been filtered out of flats 
            -- by the constraint solver. This is ok; we don't want
            -- to report unsolved Derived goals as errors
            -- See Note [Do not report derived but soluble errors]
198
       ; mapBagM_ (reportImplic ctxt) implics }
199
  where
200 201
    env = cec_tidy ctxt

202 203
reportFlats :: ReportErrCtxt -> Cts -> TcM ()
reportFlats ctxt flats    -- Here 'flats' includes insolble goals
Simon Peyton Jones's avatar
Simon Peyton Jones committed
204 205
  = traceTc "reportFlats" (ppr flats) >>
    tryReporters 
206 207 208
      [ -- First deal with things that are utterly wrong
        -- Like Int ~ Bool (incl nullary TyCons)
        -- or  Int ~ t a   (AppTy on one side)
209 210
        ("Utterly wrong",  utterly_wrong,   mkGroupReporter mkEqErr)
      , ("Holes",          is_hole,         mkUniReporter mkHoleError)
211 212 213 214

        -- Report equalities of form (a~ty).  They are usually
        -- skolem-equalities, and they cause confusing knock-on 
        -- effects in other errors; see test T4093b.
Simon Peyton Jones's avatar
Simon Peyton Jones committed
215 216
      , ("Skolem equalities",    skolem_eq,   mkUniReporter mkEqErr1) ]
      reportFlatErrs
217
      ctxt (bagToList flats)
218
  where
Simon Peyton Jones's avatar
Simon Peyton Jones committed
219
    utterly_wrong, skolem_eq :: Ct -> PredTree -> Bool
220 221 222
    utterly_wrong _ (EqPred ty1 ty2) = isRigid ty1 && isRigid ty2 
    utterly_wrong _ _ = False

223 224
    is_hole ct _ = isHoleCt ct

225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245
    skolem_eq _ (EqPred ty1 ty2) = isRigidOrSkol ty1 && isRigidOrSkol ty2 
    skolem_eq _ _ = False

---------------
isRigid, isRigidOrSkol :: Type -> Bool
isRigid ty 
  | Just (tc,_) <- tcSplitTyConApp_maybe ty = isDecomposableTyCon tc
  | Just {} <- tcSplitAppTy_maybe ty        = True
  | isForAllTy ty                           = True
  | otherwise                               = False

isRigidOrSkol ty 
  | Just tv <- getTyVar_maybe ty = isSkolemTyVar tv
  | otherwise                    = isRigid ty

isTyFun_maybe :: Type -> Maybe TyCon
isTyFun_maybe ty = case tcSplitTyConApp_maybe ty of
                      Just (tc,_) | isSynFamilyTyCon tc -> Just tc
                      _ -> Nothing

-----------------
246
reportFlatErrs :: Reporter
247 248 249 250
-- Called once for non-ambigs, once for ambigs
-- Report equality errors, and others only if we've done all 
-- the equalities.  The equality errors are more basic, and
-- can lead to knock on type-class errors
251
reportFlatErrs
252
  = tryReporters
253
      [ ("Equalities", is_equality, mkGroupReporter mkEqErr) ]
254 255 256 257
      (\ctxt cts -> do { let (dicts, ips, irreds) = go cts [] [] []
                       ; mkGroupReporter mkIPErr    ctxt ips   
                       ; mkGroupReporter mkIrredErr ctxt irreds
                       ; mkGroupReporter mkDictErr  ctxt dicts })
258
  where
259 260 261 262 263 264
    is_equality _ (EqPred {}) = True
    is_equality _ _           = False

    go [] dicts ips irreds
      = (dicts, ips, irreds)
    go (ct:cts) dicts ips irreds
Simon Peyton Jones's avatar
Simon Peyton Jones committed
265 266
      | isIPPred (ctPred ct) 
      = go cts dicts (ct:ips) irreds
267
      | otherwise
268 269 270
      = case classifyPredType (ctPred ct) of
          ClassPred {}  -> go cts (ct:dicts) ips irreds
          IrredPred {}  -> go cts dicts ips (ct:irreds)
271
          _             -> panic "reportFlatErrs"
batterseapower's avatar
batterseapower committed
272 273
    -- TuplePreds should have been expanded away by the constraint
    -- simplifier, so they shouldn't show up at this point
274 275
    -- And EqPreds are dealt with by the is_equality test

276 277

--------------------------------------------
278
--      Reporters
279 280
--------------------------------------------

281 282 283 284 285 286
type Reporter = ReportErrCtxt -> [Ct] -> TcM ()

mkUniReporter :: (ReportErrCtxt -> Ct -> TcM ErrMsg) -> Reporter
-- Reports errors one at a time
mkUniReporter mk_err ctxt 
  = mapM_ $ \ct -> 
287
    do { err <- mk_err ctxt ct
288
       ; maybeReportError ctxt err
289
       ; maybeAddDeferredBinding ctxt err ct }
290 291 292 293

mkGroupReporter :: (ReportErrCtxt -> [Ct] -> TcM ErrMsg)
                             -- Make error message for a group
                -> Reporter  -- Deal with lots of constraints
294
-- Group together insts from same location
295 296
-- We want to report them together in error messages

297
mkGroupReporter _ _ [] 
298
  = return ()
299
mkGroupReporter mk_err ctxt (ct1 : rest)
300 301 302
  = do { err <- mk_err ctxt first_group
       ; maybeReportError ctxt err
       ; mapM_ (maybeAddDeferredBinding ctxt err) first_group
303
               -- Add deferred bindings for all
304
       ; mkGroupReporter mk_err ctxt others }
305
  where
306
   loc               = cc_loc ct1
307
   first_group       = ct1 : friends
308
   (friends, others) = partition is_friend rest
309
   is_friend friend  = cc_loc friend `same_loc` loc
310

311
   same_loc :: CtLoc -> CtLoc -> Bool
312 313
   same_loc l1 l2 = ctLocSpan l1 == ctLocSpan l2

314
maybeReportError :: ReportErrCtxt -> ErrMsg -> TcM ()
315
-- Report the error and/or make a deferred binding for it
316
maybeReportError ctxt err
317 318 319
  | cec_defer ctxt  -- We have -fdefer-type-errors
                    -- so warn about all, even if cec_suppress is on
  = reportWarning (makeIntoWarning err)
320 321 322 323 324 325 326 327 328 329 330
  | cec_suppress ctxt
  = return ()
  | otherwise
  = reportError err

maybeAddDeferredBinding :: ReportErrCtxt -> ErrMsg -> Ct -> TcM ()
-- See Note [Deferring coercion errors to runtime]
maybeAddDeferredBinding ctxt err ct
  | CtWanted { ctev_pred = pred, ctev_evar = ev_id } <- cc_ev ct
    -- Only add deferred bindings for Wanted constraints
  , isHoleCt ct || cec_defer ctxt  -- And it's a hole or we have -fdefer-type-errors
331
  , Just ev_binds_var <- cec_binds ctxt  -- We have somewhere to put the bindings
332 333 334 335 336 337 338 339 340 341
  = do { dflags <- getDynFlags
       ; let err_msg = pprLocErrMsg err
             err_fs  = mkFastString $ showSDoc dflags $
                       err_msg $$ text "(deferred type error)"

         -- Create the binding
       ; addTcEvBind ev_binds_var ev_id (EvDelayedError pred err_fs) }

  | otherwise   -- Do not set any evidence for Given/Derived
  = return ()   
342 343 344 345 346 347

tryReporters :: [(String, Ct -> PredTree -> Bool, Reporter)] 
             -> Reporter -> Reporter
-- Use the first reporter in the list whose predicate says True
tryReporters reporters deflt ctxt cts
  = do { traceTc "tryReporters {" (ppr cts) 
348
       ; go ctxt reporters cts
349 350
       ; traceTc "tryReporters }" empty }
  where
351 352 353 354 355 356 357 358 359 360
    go ctxt [] cts = deflt ctxt cts 
    go ctxt ((str, pred, reporter) : rs) cts
      | null yeses  = do { traceTc "tryReporters: no" (text str)
                         ; go ctxt rs cts }
      | otherwise   = do { traceTc "tryReporters: yes" (text str <+> ppr yeses)
                         ; reporter ctxt yeses :: TcM ()
                         ; go (ctxt { cec_suppress = True }) rs nos }
                         -- Carry on with the rest, because we must make
                         -- deferred bindings for them if we have 
                         -- -fdefer-type-errors
Simon Peyton Jones's avatar
Simon Peyton Jones committed
361
                         -- But suppress their error messages
362
      where
363
       (yeses, nos) = partition keep_me cts
364
       keep_me ct = pred ct (classifyPredType (ctPred ct))
365 366

-- Add the "arising from..." part to a message about bunch of dicts
367
addArising :: CtOrigin -> SDoc -> SDoc
368
addArising orig msg = hang msg 2 (pprArising orig)
369

370
pprWithArising :: [Ct] -> (CtLoc, SDoc)
371 372
-- Print something like
--    (Eq a) arising from a use of x at y
373 374
--    (Show a) arising from a use of p at q
-- Also return a location for the error message
375
-- Works for Wanted/Derived only
376 377
pprWithArising [] 
  = panic "pprWithArising"
378 379
pprWithArising (ct:cts)
  | null cts
380
  = (loc, addArising (ctLocOrigin loc) 
dimitris's avatar
dimitris committed
381
                     (pprTheta [ctPred ct]))
382 383
  | otherwise
  = (loc, vcat (map ppr_one (ct:cts)))
384
  where
385
    loc = cc_loc ct
386
    ppr_one ct = hang (parens (pprType (ctPred ct))) 
387
                    2 (pprArisingAt (cc_loc ct))
388

389 390 391 392 393
mkErrorMsg :: ReportErrCtxt -> Ct -> SDoc -> TcM ErrMsg
mkErrorMsg ctxt ct msg 
  = do { let tcl_env = ctLocEnv (cc_loc ct)
       ; err_info <- mkErrInfo (cec_tidy ctxt) (tcl_ctxt tcl_env)
       ; mkLongErrAt (tcl_loc tcl_env) msg err_info }
394

395
type UserGiven = ([EvVar], SkolemInfo, SrcSpan)
396 397

getUserGivens :: ReportErrCtxt -> [UserGiven]
398
-- One item for each enclosing implication
399
getUserGivens (CEC {cec_encl = ctxt})
400
  = reverse $
401 402 403
    [ (givens, info, tcl_loc env) 
    | Implic {ic_given = givens, ic_env = env, ic_info = info } <- ctxt
    , not (null givens) ]
404 405
\end{code}

406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455
Note [Do not report derived but soluble errors]
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
The wc_flats include Derived constraints that have not been solved, but are
not insoluble (in that case they'd be in wc_insols).  We do not want to report
these as errors:

* Superclass constraints. If we have an unsolved [W] Ord a, we'll also have
  an unsolved [D] Eq a, and we do not want to report that; it's just noise.

* Functional dependencies.  For givens, consider
      class C a b | a -> b
      data T a where
         MkT :: C a d => [d] -> T a
      f :: C a b => T a -> F Int
      f (MkT xs) = length xs
  Then we get a [D] b~d.  But there *is* a legitimate call to
  f, namely   f (MkT [True]) :: T Bool, in which b=d.  So we should
  not reject the program.

  For wanteds, something similar
      data T a where
        MkT :: C Int b => a -> b -> T a 
      g :: C Int c => c -> ()
      f :: T a -> ()
      f (MkT x y) = g x
  Here we get [G] C Int b, [W] C Int a, hence [D] a~b.
  But again f (MkT True True) is a legitimate call.

(We leave the Deriveds in wc_flat until reportErrors, so that we don't lose
derived superclasses between iterations of the solver.)

For functional dependencies, here is a real example, 
stripped off from libraries/utf8-string/Codec/Binary/UTF8/Generic.hs

  class C a b | a -> b
  g :: C a b => a -> b -> () 
  f :: C a b => a -> b -> () 
  f xa xb = 
      let loop = g xa 
      in loop xb

We will first try to infer a type for loop, and we will succeed:
    C a b' => b' -> ()
Subsequently, we will type check (loop xb) and all is good. But, 
recall that we have to solve a final implication constraint: 
    C a b => (C a b' => .... cts from body of loop .... )) 
And now we have a problem as we will generate an equality b ~ b' and fail to 
solve it. 


batterseapower's avatar
batterseapower committed
456 457 458 459 460 461 462
%************************************************************************
%*                  *
                Irreducible predicate errors
%*                  *
%************************************************************************

\begin{code}
463 464
mkIrredErr :: ReportErrCtxt -> [Ct] -> TcM ErrMsg
mkIrredErr ctxt cts 
465 466
  = do { (ctxt, binds_msg) <- relevantBindings ctxt ct1
       ; mkErrorMsg ctxt ct1 (msg $$ binds_msg) }
batterseapower's avatar
batterseapower committed
467
  where
468
    (ct1:_) = cts
469
    orig    = ctLocOrigin (cc_loc ct1)
470 471
    givens  = getUserGivens ctxt
    msg = couldNotDeduce givens (map ctPred cts, orig)
batterseapower's avatar
batterseapower committed
472

473
----------------
474
mkHoleError :: ReportErrCtxt -> Ct -> TcM ErrMsg
475
mkHoleError ctxt ct@(CHoleCan { cc_occ = occ })
476 477
  = do { let tyvars = varSetElems (tyVarsOfCt ct)
             tyvars_msg = map loc_msg tyvars
478 479 480
             msg = vcat [ hang (ptext (sLit "Found hole") <+> quotes (ppr occ))
                             2 (ptext (sLit "with type:") <+> pprType (ctEvPred (cc_ev ct)))
                        , ppUnless (null tyvars_msg) (ptext (sLit "Where:") <+> vcat tyvars_msg) ]
481 482
       ; (ctxt, binds_doc) <- relevantBindings ctxt ct
       ; mkErrorMsg ctxt ct (msg $$ binds_doc) }
483
  where
484 485 486
    loc_msg tv 
       = case tcTyVarDetails tv of
          SkolemTv {} -> quotes (ppr tv) <+> skol_msg
487
          MetaTv {}   -> quotes (ppr tv) <+> ptext (sLit "is an ambiguous type variable")
488 489 490
          det -> pprTcTyVarDetails det
       where 
          skol_msg = pprSkol (getSkolemInfo (cec_encl ctxt) tv) (getSrcLoc tv)
491 492

mkHoleError _ ct = pprPanic "mkHoleError" (ppr ct)
493

494
----------------
495 496
mkIPErr :: ReportErrCtxt -> [Ct] -> TcM ErrMsg
mkIPErr ctxt cts
497 498
  = do { (ctxt, bind_msg) <- relevantBindings ctxt ct1
       ; mkErrorMsg ctxt ct1 (msg $$ bind_msg) }
499
  where
500
    (ct1:_) = cts
501
    orig    = ctLocOrigin (cc_loc ct1)
502 503
    preds   = map ctPred cts
    givens  = getUserGivens ctxt
504 505
    msg | null givens
        = addArising orig $
506 507
          sep [ ptext (sLit "Unbound implicit parameter") <> plural cts
              , nest 2 (pprTheta preds) ] 
508
        | otherwise
509
        = couldNotDeduce givens (preds, orig)
510 511 512 513 514 515 516 517 518
\end{code}


%************************************************************************
%*									*
                Equality errors
%*									*
%************************************************************************

519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536
Note [Inaccessible code]
~~~~~~~~~~~~~~~~~~~~~~~~
Consider
   data T a where
     T1 :: T a
     T2 :: T Bool

   f :: (a ~ Int) => T a -> Int
   f T1 = 3
   f T2 = 4   -- Unreachable code

Here the second equation is unreachable. The original constraint
(a~Int) from the signature gets rewritten by the pattern-match to
(Bool~Int), so the danger is that we report the error as coming from
the *signature* (Trac #7293).  So, for Given errors we replace the
env (and hence src-loc) on its CtLoc with that from the immediately
enclosing implication.

537
\begin{code}
538 539 540 541 542 543 544 545 546
mkEqErr :: ReportErrCtxt -> [Ct] -> TcM ErrMsg
-- Don't have multiple equality errors from the same location
-- E.g.   (Int,Bool) ~ (Bool,Int)   one error will do!
mkEqErr ctxt (ct:_) = mkEqErr1 ctxt ct
mkEqErr _ [] = panic "mkEqErr"

mkEqErr1 :: ReportErrCtxt -> Ct -> TcM ErrMsg
-- Wanted constraints only!
mkEqErr1 ctxt ct
547
  | isGiven ev
548
  = do { (ctxt, binds_msg) <- relevantBindings ctxt ct
549
       ; let (given_loc, given_msg) = mk_given (cec_encl ctxt)
550 551
       ; dflags <- getDynFlags
       ; mkEqErr_help dflags ctxt (given_msg $$ binds_msg) 
552 553 554 555 556 557 558
                      (ct { cc_loc = given_loc}) -- Note [Inaccessible code]
                      Nothing ty1 ty2 }

  | otherwise   -- Wanted or derived
  = do { (ctxt, binds_msg) <- relevantBindings ctxt ct
       ; (ctxt, tidy_orig) <- zonkTidyOrigin ctxt (ctLocOrigin (cc_loc ct))
       ; let (is_oriented, wanted_msg) = mk_wanted_extra tidy_orig
559 560
       ; dflags <- getDynFlags
       ; mkEqErr_help dflags ctxt (wanted_msg $$ binds_msg) 
561
                      ct is_oriented ty1 ty2 }
562
  where
563
    ev         = cc_ev ct
564 565 566 567 568 569 570 571 572
    (ty1, ty2) = getEqPredTys (ctEvPred ev)

    mk_given :: [Implication] -> (CtLoc, SDoc)
    -- For given constraints we overwrite the env (and hence src-loc)
    -- with one from the implication.  See Note [Inaccessible code]
    mk_given []           = (cc_loc ct, empty)
    mk_given (implic : _) = (setCtLocEnv (cc_loc ct) (ic_env implic)
                            , hang (ptext (sLit "Inaccessible code in"))
                                 2 (ppr (ic_info implic)))
573

574 575
       -- If the types in the error message are the same as the types
       -- we are unifying, don't add the extra expected/actual message
576 577 578 579 580
    mk_wanted_extra orig@(TypeEqOrigin {})
      = mkExpectedActualMsg ty1 ty2 orig

    mk_wanted_extra (KindEqOrigin cty1 cty2 sub_o)
      = (Nothing, msg1 $$ msg2)
581
      where
582 583 584 585 586 587 588 589
        msg1 = hang (ptext (sLit "When matching types"))
                  2 (vcat [ ppr cty1 <+> dcolon <+> ppr (typeKind cty1)
                          , ppr cty2 <+> dcolon <+> ppr (typeKind cty2) ])
        msg2 = case sub_o of
                 TypeEqOrigin {} -> snd (mkExpectedActualMsg cty1 cty2 sub_o)
                 _ -> empty

    mk_wanted_extra _ = (Nothing, empty)
590

591 592 593 594 595 596 597
mkEqErr_help :: DynFlags -> ReportErrCtxt -> SDoc
             -> Ct          
             -> Maybe SwapFlag   -- Nothing <=> not sure
             -> TcType -> TcType -> TcM ErrMsg
mkEqErr_help dflags ctxt extra ct oriented ty1 ty2
  | Just tv1 <- tcGetTyVar_maybe ty1 = mkTyVarEqErr dflags ctxt extra ct oriented tv1 ty2
  | Just tv2 <- tcGetTyVar_maybe ty2 = mkTyVarEqErr dflags ctxt extra ct swapped  tv2 ty1
598
  | otherwise                        = reportEqErr  ctxt extra ct oriented ty1 ty2
599 600
  where
    swapped = fmap flipSwap oriented
601

602 603 604 605
reportEqErr :: ReportErrCtxt -> SDoc
            -> Ct    
            -> Maybe SwapFlag   -- Nothing <=> not sure
            -> TcType -> TcType -> TcM ErrMsg
606
reportEqErr ctxt extra1 ct oriented ty1 ty2
607 608
  = do { let extra2 = mkEqInfoMsg ct ty1 ty2
       ; mkErrorMsg ctxt ct (vcat [ misMatchOrCND ctxt ct oriented ty1 ty2
609
                                   , extra2, extra1]) }
610

611 612
mkTyVarEqErr :: DynFlags -> ReportErrCtxt -> SDoc -> Ct 
             -> Maybe SwapFlag -> TcTyVar -> TcType -> TcM ErrMsg
simonpj@microsoft.com's avatar
simonpj@microsoft.com committed
613
-- tv1 and ty2 are already tidied
614 615 616
mkTyVarEqErr dflags ctxt extra ct oriented tv1 ty2
  | isUserSkolem ctxt tv1   -- ty2 won't be a meta-tyvar, or else the thing would
                            -- be oriented the other way round; see TcCanonical.reOrient
617
  || isSigTyVar tv1 && not (isTyVarTy ty2)
618 619 620
  = mkErrorMsg ctxt ct (vcat [ misMatchOrCND ctxt ct oriented ty1 ty2
                             , extraTyVarInfo ctxt ty1 ty2
                             , extra ])
621

622 623 624
  -- So tv is a meta tyvar (or started that way before we 
  -- generalised it).  So presumably it is an *untouchable* 
  -- meta tyvar or a SigTv, else it'd have been unified
625
  | not (k2 `tcIsSubKind` k1)   	 -- Kind error
626
  = mkErrorMsg ctxt ct $ (kindErrorMsg (mkTyVarTy tv1) ty2 $$ extra)
627

628
  | OC_Occurs <- occ_check_expand
629 630
  = do { let occCheckMsg = hang (text "Occurs check: cannot construct the infinite type:")
                              2 (sep [ppr ty1, char '~', ppr ty2])
631 632
             extra2 = mkEqInfoMsg ct ty1 ty2
       ; mkErrorMsg ctxt ct (occCheckMsg $$ extra2 $$ extra) }
Simon Peyton Jones's avatar
Simon Peyton Jones committed
633

634 635 636 637 638 639 640 641 642
  | OC_Forall <- occ_check_expand
  = do { let msg = vcat [ ptext (sLit "Cannot instantiate unification variable")
                          <+> quotes (ppr tv1)
                        , hang (ptext (sLit "with a type involving foralls:")) 2 (ppr ty2)
                        , nest 2 (ptext (sLit "Perhaps you want -XImpredicativeTypes")) ]
       ; mkErrorMsg ctxt ct msg }

  -- If the immediately-enclosing implication has 'tv' a skolem, and
  -- we know by now its an InferSkol kind of skolem, then presumably
643 644
  -- it started life as a SigTv, else it'd have been unified, given
  -- that there's no occurs-check or forall problem
645 646 647 648 649 650 651
  | (implic:_) <- cec_encl ctxt
  , Implic { ic_skols = skols } <- implic
  , tv1 `elem` skols
  = mkErrorMsg ctxt ct (vcat [ misMatchMsg oriented ty1 ty2
                             , extraTyVarInfo ctxt ty1 ty2
                             , extra ])

652 653
  -- Check for skolem escape
  | (implic:_) <- cec_encl ctxt   -- Get the innermost context
654 655
  , Implic { ic_env = env, ic_skols = skols, ic_info = skol_info } <- implic
  , let esc_skols = filter (`elemVarSet` (tyVarsOfType ty2)) skols
656
  , not (null esc_skols)
657
  = do { let msg = misMatchMsg oriented ty1 ty2
658 659 660 661 662
             esc_doc = sep [ ptext (sLit "because type variable") <> plural esc_skols
                             <+> pprQuotedList esc_skols
                           , ptext (sLit "would escape") <+>
                             if isSingleton esc_skols then ptext (sLit "its scope")
                                                      else ptext (sLit "their scope") ]
663 664 665 666 667 668 669 670
             tv_extra = vcat [ nest 2 $ esc_doc
                             , sep [ (if isSingleton esc_skols 
                                      then ptext (sLit "This (rigid, skolem) type variable is")
                                      else ptext (sLit "These (rigid, skolem) type variables are"))
                               <+> ptext (sLit "bound by")
                             , nest 2 $ ppr skol_info
                             , nest 2 $ ptext (sLit "at") <+> ppr (tcl_loc env) ] ]
       ; mkErrorMsg ctxt ct (msg $$ tv_extra $$ extra) }
671 672 673

  -- Nastiest case: attempt to unify an untouchable variable
  | (implic:_) <- cec_encl ctxt   -- Get the innermost context
674 675 676 677 678 679 680 681 682 683
  , Implic { ic_env = env, ic_given = given, ic_info = skol_info } <- implic
  = do { let msg = misMatchMsg oriented ty1 ty2
             untch_extra 
                = nest 2 $
                  sep [ quotes (ppr tv1) <+> ptext (sLit "is untouchable")
                      , nest 2 $ ptext (sLit "inside the constraints") <+> pprEvVarTheta given
                      , nest 2 $ ptext (sLit "bound by") <+> ppr skol_info
                      , nest 2 $ ptext (sLit "at") <+> ppr (tcl_loc env) ]
             tv_extra = extraTyVarInfo ctxt ty1 ty2
       ; mkErrorMsg ctxt ct (vcat [msg, untch_extra, tv_extra, extra]) }
684

685
  | otherwise
686
  = reportEqErr ctxt extra ct oriented (mkTyVarTy tv1) ty2
687 688
        -- This *can* happen (Trac #6123, and test T2627b)
        -- Consider an ambiguous top-level constraint (a ~ F a)
Gabor Greif's avatar
typos  
Gabor Greif committed
689
        -- Not an occurs check, because F is a type function.
690
  where         
691
    occ_check_expand = occurCheckExpand dflags tv1 ty2
692 693 694
    k1 	= tyVarKind tv1
    k2 	= typeKind ty2
    ty1 = mkTyVarTy tv1
695

696
mkEqInfoMsg :: Ct -> TcType -> TcType -> SDoc
697 698 699 700 701
-- Report (a) ambiguity if either side is a type function application
--            e.g. F a0 ~ Int    
--        (b) warning about injectivity if both sides are the same
--            type function application   F a ~ F b
--            See Note [Non-injective type functions]
702 703
mkEqInfoMsg ct ty1 ty2
  = tyfun_msg $$ ambig_msg
704 705 706
  where
    mb_fun1 = isTyFun_maybe ty1
    mb_fun2 = isTyFun_maybe ty2
707 708 709 710 711

    ambig_msg | isJust mb_fun1 || isJust mb_fun2 
              = snd (mkAmbigMsg ct)
              | otherwise = empty

712 713 714 715 716 717 718
    tyfun_msg | Just tc1 <- mb_fun1
              , Just tc2 <- mb_fun2
              , tc1 == tc2 
              = ptext (sLit "NB:") <+> quotes (ppr tc1) 
                <+> ptext (sLit "is a type function, and may not be injective")
              | otherwise = empty

Simon Peyton Jones's avatar
Simon Peyton Jones committed
719 720 721 722 723 724 725 726 727 728 729
isUserSkolem :: ReportErrCtxt -> TcTyVar -> Bool
-- See Note [Reporting occurs-check errors]
isUserSkolem ctxt tv
  = isSkolemTyVar tv && any is_user_skol_tv (cec_encl ctxt)
  where
    is_user_skol_tv (Implic { ic_skols = sks, ic_info = skol_info })
      = tv `elem` sks && is_user_skol_info skol_info

    is_user_skol_info (InferSkol {}) = False
    is_user_skol_info _ = True

730
misMatchOrCND :: ReportErrCtxt -> Ct -> Maybe SwapFlag -> TcType -> TcType -> SDoc
Simon Peyton Jones's avatar
Simon Peyton Jones committed
731
-- If oriented then ty1 is actual, ty2 is expected
732 733 734
misMatchOrCND ctxt ct oriented ty1 ty2
  | null givens || 
    (isRigid ty1 && isRigid ty2) || 
735
    isGivenCt ct
736 737 738 739
       -- If the equality is unconditionally insoluble
       -- or there is no context, don't report the context
  = misMatchMsg oriented ty1 ty2
  | otherwise      
740
  = couldNotDeduce givens ([mkEqPred ty1 ty2], orig)
741 742
  where
    givens = getUserGivens ctxt
Simon Peyton Jones's avatar
Simon Peyton Jones committed
743
    orig   = TypeEqOrigin { uo_actual = ty1, uo_expected = ty2 }
744

745
couldNotDeduce :: [UserGiven] -> (ThetaType, CtOrigin) -> SDoc
746
couldNotDeduce givens (wanteds, orig)
747
  = vcat [ addArising orig (ptext (sLit "Could not deduce") <+> pprTheta wanteds)
dimitris's avatar
dimitris committed
748 749
         , vcat (pp_givens givens)]

750
pp_givens :: [UserGiven] -> [SDoc]
dimitris's avatar
dimitris committed
751 752
pp_givens givens 
   = case givens of
753 754 755
         []     -> []
         (g:gs) ->      ppr_given (ptext (sLit "from the context")) g
                 : map (ppr_given (ptext (sLit "or from"))) gs
756 757
    where 
       ppr_given herald (gs, skol_info, loc)
dimitris's avatar
dimitris committed
758
           = hang (herald <+> pprEvVarTheta gs)
759 760
                2 (sep [ ptext (sLit "bound by") <+> ppr skol_info
                       , ptext (sLit "at") <+> ppr loc])
simonpj@microsoft.com's avatar
simonpj@microsoft.com committed
761

762
extraTyVarInfo :: ReportErrCtxt -> TcType -> TcType -> SDoc
763 764
-- Add on extra info about the types themselves
-- NB: The types themselves are already tidied
765 766
extraTyVarInfo ctxt ty1 ty2
  = nest 2 (extra1 $$ extra2)
767
  where
768 769
    extra1 = tyVarExtraInfoMsg (cec_encl ctxt) ty1
    extra2 = tyVarExtraInfoMsg (cec_encl ctxt) ty2
770

771
tyVarExtraInfoMsg :: [Implication] -> Type -> SDoc
772
-- Shows a bit of extra info about skolem constants
773
tyVarExtraInfoMsg implics ty
774
  | Just tv <- tcGetTyVar_maybe ty
Simon Peyton Jones's avatar
Simon Peyton Jones committed
775 776 777
  , isTcTyVar tv, isSkolemTyVar tv
  , let pp_tv = quotes (ppr tv)
 = case tcTyVarDetails tv of
778
    SkolemTv {}   -> pp_tv <+> pprSkol (getSkolemInfo implics tv) (getSrcLoc tv)
Simon Peyton Jones's avatar
Simon Peyton Jones committed
779 780 781 782 783 784 785
    FlatSkol {}   -> pp_tv <+> ptext (sLit "is a flattening type variable")
    RuntimeUnk {} -> pp_tv <+> ptext (sLit "is an interactive-debugger skolem")
    MetaTv {}     -> empty

 | otherwise             -- Normal case
 = empty
 
786 787 788 789 790 791 792 793 794
kindErrorMsg :: TcType -> TcType -> SDoc   -- Types are already tidy
kindErrorMsg ty1 ty2
  = vcat [ ptext (sLit "Kind incompatibility when matching types:")
         , nest 2 (vcat [ ppr ty1 <+> dcolon <+> ppr k1
                        , ppr ty2 <+> dcolon <+> ppr k2 ]) ]
  where
    k1 = typeKind ty1
    k2 = typeKind ty2

795
--------------------
796
misMatchMsg :: Maybe SwapFlag -> TcType -> TcType -> SDoc	   -- Types are already tidy
797
-- If oriented then ty1 is actual, ty2 is expected
798 799 800 801
misMatchMsg oriented ty1 ty2  
  | Just IsSwapped <- oriented
  = misMatchMsg (Just NotSwapped) ty2 ty1
  | Just NotSwapped <- oriented
802 803
  = sep [ ptext (sLit "Couldn't match expected") <+> what <+> quotes (ppr ty2)
        , nest 12 $   ptext (sLit "with actual") <+> what <+> quotes (ppr ty1) ]
804 805 806 807 808 809
  | otherwise
  = sep [ ptext (sLit "Couldn't match") <+> what <+> quotes (ppr ty1)
        , nest 14 $ ptext (sLit "with") <+> quotes (ppr ty2) ]
  where 
    what | isKind ty1 = ptext (sLit "kind")
         | otherwise  = ptext (sLit "type")
810

811
mkExpectedActualMsg :: Type -> Type -> CtOrigin -> (Maybe SwapFlag, SDoc)
812
-- NotSwapped means (actual, expected), IsSwapped is the reverse
813
mkExpectedActualMsg ty1 ty2 (TypeEqOrigin { uo_actual = act, uo_expected = exp })
814 815
  | act `pickyEqType` ty1, exp `pickyEqType` ty2 = (Just NotSwapped,  empty)
  | exp `pickyEqType` ty1, act `pickyEqType` ty2 = (Just IsSwapped, empty)
816 817 818 819 820 821
  | otherwise                                    = (Nothing, msg)
  where
    msg = vcat [ text "Expected type:" <+> ppr exp
               , text "  Actual type:" <+> ppr act ]

mkExpectedActualMsg _ _ _ = panic "mkExprectedAcutalMsg"
822 823
\end{code}

Simon Peyton Jones's avatar
Simon Peyton Jones committed
824 825 826 827 828 829 830 831 832 833 834 835 836 837 838 839 840 841
Note [Reporting occurs-check errors]
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Given (a ~ [a]), if 'a' is a rigid type variable bound by a user-supplied
type signature, then the best thing is to report that we can't unify
a with [a], because a is a skolem variable.  That avoids the confusing
"occur-check" error message.

But nowadays when inferring the type of a function with no type signature,
even if there are errors inside, we still generalise its signature and
carry on. For example
   f x = x:x
Here we will infer somethiing like
   f :: forall a. a -> [a]
with a suspended error of (a ~ [a]).  So 'a' is now a skolem, but not
one bound by the programmer!  Here we really should report an occurs check.

So isUserSkolem distinguishes the two.

842 843 844 845 846 847 848 849 850 851 852 853 854 855 856 857 858 859
Note [Non-injective type functions]
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
It's very confusing to get a message like
     Couldn't match expected type `Depend s'
            against inferred type `Depend s1'
so mkTyFunInfoMsg adds:
       NB: `Depend' is type function, and hence may not be injective

Warn of loopy local equalities that were dropped.


%************************************************************************
%*									*
                 Type-class errors
%*									*
%************************************************************************

\begin{code}
860 861
mkDictErr :: ReportErrCtxt -> [Ct] -> TcM ErrMsg
mkDictErr ctxt cts 
862 863 864 865 866 867 868
  = ASSERT( not (null cts) )
    do { inst_envs <- tcGetInstEnvs
       ; lookups   <- mapM (lookup_cls_inst inst_envs) cts
       ; let (no_inst_cts, overlap_cts) = partition is_no_inst lookups

       -- Report definite no-instance errors, 
       -- or (iff there are none) overlap errors
Gabor Greif's avatar
typos  
Gabor Greif committed
869
       -- But we report only one of them (hence 'head') because they all
870 871
       -- have the same source-location origin, to try avoid a cascade
       -- of error from one location
872
       ; (ctxt, err) <- mk_dict_err ctxt (head (no_inst_cts ++ overlap_cts))
873
       ; mkErrorMsg ctxt ct1 err }
874
  where
875
    ct1:_ = cts
876 877 878 879 880 881 882 883 884 885
    no_givens = null (getUserGivens ctxt)
    is_no_inst (ct, (matches, unifiers, _))
      =  no_givens 
      && null matches 
      && (null unifiers || all (not . isAmbiguousTyVar) (varSetElems (tyVarsOfCt ct)))
           
    lookup_cls_inst inst_envs ct
      = do { tys_flat <- mapM quickFlattenTy tys
                -- Note [Flattening in error message generation]
           ; return (ct, lookupInstEnv inst_envs clas tys_flat) }
886
      where
887
        (clas, tys) = getClassPredTys (ctPred ct)
888

889
mk_dict_err :: ReportErrCtxt -> (Ct, ClsInstLookupResult)
890
            -> TcM (ReportErrCtxt, SDoc)
891 892 893 894
-- Report an overlap error if this class constraint results
-- from an overlap (returning Left clas), otherwise return (Right pred)
mk_dict_err ctxt (ct, (matches, unifiers, safe_haskell)) 
  | null matches  -- No matches but perhaps several unifiers
895
  = do { let (is_ambig, ambig_msg) = mkAmbigMsg ct
896
       ; (ctxt, binds_msg) <- relevantBindings ctxt ct
Simon Peyton Jones's avatar
Simon Peyton Jones committed
897
       ; traceTc "mk_dict_err" (ppr ct $$ ppr is_ambig $$ ambig_msg)
898
       ; return (ctxt, cannot_resolve_msg is_ambig binds_msg ambig_msg) }
899

900 901
  | not safe_haskell   -- Some matches => overlap errors
  = return (ctxt, overlap_msg)
902

903 904 905
  | otherwise
  = return (ctxt, safe_haskell_msg)
  where
906
    orig        = ctLocOrigin (cc_loc ct)
907 908 909 910 911 912
    pred        = ctPred ct
    (clas, tys) = getClassPredTys pred
    ispecs      = [ispec | (ispec, _) <- matches]
    givens      = getUserGivens ctxt
    all_tyvars  = all isTyVarTy tys

913
    cannot_resolve_msg has_ambig_tvs binds_msg ambig_msg
914 915
      = vcat [ addArising orig (no_inst_herald <+> pprParendType pred)
             , vcat (pp_givens givens)
916 917
             , ppWhen (has_ambig_tvs && not (null unifiers && null givens))
               (vcat [ ambig_msg, binds_msg, potential_msg ])
918
             , show_fixes (add_to_ctxt_fixes has_ambig_tvs ++ drv_fixes) ]
919 920

    potential_msg
921 922
      = ppWhen (not (null unifiers) && want_potential orig) $
        hang (if isSingleton unifiers 
923 924 925 926
              then ptext (sLit "Note: there is a potential instance available:")
              else ptext (sLit "Note: there are several potential instances:"))
    	   2 (ppr_insts unifiers)

927 928 929 930 931
    -- Report "potential instances" only when the constraint arises
    -- directly from the user's use of an overloaded function
    want_potential (AmbigOrigin {})   = False
    want_potential _                  = True

932 933 934 935 936 937 938 939 940 941 942 943
    add_to_ctxt_fixes has_ambig_tvs
      | not has_ambig_tvs && all_tyvars
      , (orig:origs) <- mapCatMaybes get_good_orig (cec_encl ctxt)
      = [sep [ ptext (sLit "add") <+> pprParendType pred
               <+> ptext (sLit "to the context of")
	     , nest 2 $ ppr_skol orig $$ 
                        vcat [ ptext (sLit "or") <+> ppr_skol orig 
                             | orig <- origs ] ] ]
      | otherwise = []

    ppr_skol (PatSkol dc _) = ptext (sLit "the data constructor") <+> quotes (ppr dc)
    ppr_skol skol_info      = ppr skol_info
944 945

	-- Do not suggest adding constraints to an *inferred* type signature!
946 947 948
    get_good_orig ic = case ic_info ic of 
                         SigSkol (InfSigCtxt {}) _ -> Nothing
                         origin                    -> Just origin
949

950 951 952
    no_inst_herald
      | null givens && null matches = ptext (sLit "No instance for")
      | otherwise                   = ptext (sLit "Could not deduce")
953

954 955 956
    drv_fixes = case orig of
                   DerivOrigin -> [drv_fix]
                   _           -> []
957

958 959
    drv_fix = hang (ptext (sLit "use a standalone 'deriving instance' declaration,"))
                 2 (ptext (sLit "so you can specify the instance context yourself"))
960

961
    -- Normal overlap error
962
    overlap_msg
963 964
      = ASSERT( not (null matches) )
        vcat [	addArising orig (ptext (sLit "Overlapping instances for") 
batterseapower's avatar
batterseapower committed
965
				<+> pprType (mkClassPred clas tys))
dimitris's avatar
dimitris committed
966

967
             ,  ppUnless (null matching_givens) $
968
                  sep [ptext (sLit "Matching givens (or their superclasses):") 
969
                      , nest 2 (vcat matching_givens)]
dimitris's avatar
dimitris committed
970

971 972 973
    	     ,	sep [ptext (sLit "Matching instances:"),
    		     nest 2 (vcat [pprInstances ispecs, pprInstances unifiers])]

974
             ,  ppWhen (null matching_givens && isSingleton matches && null unifiers) $
975 976 977 978 979 980
                -- Intuitively, some given matched the wanted in their
                -- flattened or rewritten (from given equalities) form
                -- but the matcher can't figure that out because the
                -- constraints are non-flat and non-rewritten so we
                -- simply report back the whole given
                -- context. Accelerate Smart.hs showed this problem.
981
                  sep [ ptext (sLit "There exists a (perhaps superclass) match:") 
982
                      , nest 2 (vcat (pp_givens givens))]
983 984 985 986 987 988 989 990

	     ,	ppWhen (isSingleton matches) $
		parens (vcat [ ptext (sLit "The choice depends on the instantiation of") <+>
	    		          quotes (pprWithCommas ppr (varSetElems (tyVarsOfTypes tys)))
			     , ppWhen (null (matching_givens)) $
                               vcat [ ptext (sLit "To pick the first instance above, use -XIncoherentInstances")
			            , ptext (sLit "when compiling the other instance declarations")]
                        ])]
991 992 993 994
        where
            ispecs = [ispec | (ispec, _) <- matches]

            givens = getUserGivens ctxt
995 996
            matching_givens = mapCatMaybes matchable givens

997
            matchable (evvars,skol_info,loc) 
998 999 1000
              = case ev_vars_matching of
                     [] -> Nothing
                     _  -> Just $ hang (pprTheta ev_vars_matching)
1001 1002
                                    2 (sep [ ptext (sLit "bound by") <+> ppr skol_info
                                           , ptext (sLit "at") <+> ppr loc])
1003
                where ev_vars_matching = filter ev_var_matches (map evVarPred evvars)
batterseapower's avatar
batterseapower committed
1004 1005 1006 1007 1008 1009