• Simon Peyton Jones's avatar
    [project @ 2000-03-23 17:45:17 by simonpj] · 111cee3f
    Simon Peyton Jones authored
    This utterly gigantic commit is what I've been up to in background
    mode in the last couple of months.  Originally the main goal
    was to get rid of Con (staturated constant applications)
    in the CoreExpr type, but one thing led to another, and I kept
    postponing actually committing.   Sorry.
    	Simon, 23 March 2000
    I've tested it pretty thoroughly, but doubtless things will break.
    Here are the highlights
    * Con is gone; the CoreExpr type is simpler
    * NoRepLits have gone
    * Better usage info in interface files => less recompilation
    * Result type signatures work
    * CCall primop is tidied up
    * Constant folding now done by Rules
    * Lots of hackery in the simplifier
    * Improvements in CPR and strictness analysis
    Many bug fixes including
    * Sergey's DoCon compiles OK; no loop in the strictness analyser
    * Volker Wysk's programs don't crash the CPR analyser
    I have not done much on measuring compilation times and binary sizes;
    they could have got worse.  I think performance has got significantly
    better, though, in most cases.
    Removing the Con form of Core expressions
    The big thing is that
      For every constructor C there are now *two* Ids:
    	C is the constructor's *wrapper*. It evaluates and unboxes arguments
    	before calling $wC.  It has a perfectly ordinary top-level defn
    	in the module defining the data type.
    	$wC is the constructor's *worker*.  It is like a primop that simply
    	allocates and builds the constructor value.  Its arguments are the
    	actual representation arguments of the constructor.
    	Its type may be different to C, because:
    		- useless dict args are dropped
    		- strict args may be flattened
      For every primop P there is *one* Id, its (curried) Id
      Neither contructor worker Id nor the primop Id have a defminition anywhere.
      Instead they are saturated during the core-to-STG pass, and the code generator
      generates code for them directly. The STG language still has saturated
      primops and constructor applications.
    * The Const type disappears, along with Const.lhs.  The literal part
      of Const.lhs reappears as Literal.lhs.  Much tidying up in here,
      to bring all the range checking into this one module.
    * I got rid of NoRep literals entirely.  They just seem to be too much trouble.
    * Because Con's don't exist any more, the funny C { args } syntax
      disappears from inteface files.
    * Result type signatures now work
    	f :: Int -> Int = \x -> x
    	-- The Int->Int is the type of f
    	g x y :: Int = x+y
    	-- The Int is the type of the result of (g x y)
    Recompilation checking and make
    * The .hi file for a modules is not touched if it doesn't change.  (It used to
      be touched regardless, forcing a chain of recompilations.)  The penalty for this
      is that we record exported things just as if they were mentioned in the body of
      the module.  And the penalty for that is that we may recompile a module when
      the only things that have changed are the things it is passing on without using.
      But it seems like a good trade.
    * -recomp is on by default
    Foreign declarations
    * If you say
    	foreign export zoo :: Int -> IO Int
      then you get a C produre called 'zoo', not 'zzoo' as before.
      I've also added a check that complains if you export (or import) a C
      procedure whose name isn't legal C.
    Code generation and labels
    * Now that constructor workers and wrappers have distinct names, there's
      no need to have a Foo_static_closure and a Foo_closure for constructor Foo.
      I nuked the entire StaticClosure story.  This has effects in some of
      the RTS headers (i.e. s/static_closure/closure/g)
    Rules, constant folding
    * Constant folding becomes just another rewrite rule, attached to the Id for the
      PrimOp.   To achieve this, there's a new form of Rule, a BuiltinRule (see CoreSyn.lhs).
      The prelude rules are in prelude/PrelRules.lhs, while simplCore/ConFold.lhs has gone.
    * Appending of constant strings now works, using fold/build fusion, plus
      the rewrite rule
    	unpack "foo" c (unpack "baz" c n)  =  unpack "foobaz" c n
      Implemented in PrelRules.lhs
    * The CCall primop is tidied up quite a bit.  There is now a data type CCall,
      defined in PrimOp, that packages up the info needed for a particular CCall.
      There is a new Id for each new ccall, with an big "occurrence name"
    	{__ccall "foo" gc Int# -> Int#}
      In interface files, this is parsed as a single Id, which is what it is, really.
    * There were numerous places where the host compiler's
      minInt/maxInt was being used as the target machine's minInt/maxInt.
      I nuked all of these; everything is localised to inIntRange and inWordRange,
      in Literal.lhs
    * Desugaring record updates was broken: it didn't generate correct matches when
      used withe records with fancy unboxing etc.  It now uses matchWrapper.
    * Significant tidying up in codeGen/SMRep.lhs
    * Add __word, __word64, __int64 terminals to signal the obvious types
      in interface files.  Add the ability to print word values in hex into
      C code.
    * PrimOp.lhs is no longer part of a loop.  Remove PrimOp.hi-boot*
    * isProductTyCon no longer returns False for recursive products, nor
      for unboxed products; you have to test for these separately.
      There's no reason not to do CPR for recursive product types, for example.
      Ditto splitProductType_maybe.
    * New -fno-case-of-case flag for the simplifier.  We use this in the first run
      of the simplifier, where it helps to stop messing up expressions that
      the (subsequent) full laziness pass would otherwise find float out.
      It's much more effective than previous half-baked hacks in inlining.
      Actually, it turned out that there were three places in Simplify.lhs that
      needed to know use this flag.
    * Make the float-in pass push duplicatable bindings into the branches of
      a case expression, in the hope that we never have to allocate them.
      (see FloatIn.sepBindsByDropPoint)
    * Arrange that top-level bottoming Ids get a NOINLINE pragma
      This reduced gratuitous inlining of error messages.
      But arrange that such things still get w/w'd.
    * Arrange that a strict argument position is regarded as an 'interesting'
      context, so that if we see
    	foldr k z (g x)
      then we'll be inclined to inline g; this can expose a build.
    * There was a missing case in CoreUtils.exprEtaExpandArity that meant
      we were missing some obvious cases for eta expansion
      Also improve the code when handling applications.
    * Make record selectors (identifiable by their IdFlavour) into "cheap" operations.
    	  [The change is a 2-liner in CoreUtils.exprIsCheap]
      This means that record selection may be inlined into function bodies, which
      greatly improves the arities of overloaded functions.
    * Make a cleaner job of inlining "lone variables".  There was some distributed
      cunning, but I've centralised it all now in SimplUtils.analyseCont, which
      analyses the context of a call to decide whether it is "interesting".
    * Don't specialise very small functions in Specialise.specDefn
      It's better to inline it.  Rather like the worker/wrapper case.
    * Be just a little more aggressive when floating out of let rhss.
      See comments with Simplify.wantToExpose
      A small change with an occasional big effect.
    * Make the inline-size computation think that
    	case x of I# x -> ...
      is *free*.
    CPR analysis
    * Fix what was essentially a bug in CPR analysis.  Consider
    	letrec f x = let g y = let ... in f e1
    		     if ... then (a,b) else g x
      g has the CPR property if f does; so when generating the final annotated
      RHS for f, we must use an envt in which f is bound to its final abstract
      value.  This wasn't happening.  Instead, f was given the CPR tag but g
      wasn't; but of course the w/w pass gives rotten results in that case!!
      (Because f's CPR-ness relied on g's.)
      On they way I tidied up the code in CprAnalyse.  It's quite a bit shorter.
      The fact that some data constructors return a constructed product shows
      up in their CPR info (MkId.mkDataConId) not in CprAnalyse.lhs
    Strictness analysis and worker/wrapper
    * BIG THING: pass in the demand to StrictAnal.saExpr.  This affects situations
    	f (let x = e1 in (x,x))
      where f turns out to have strictness u(SS), say.  In this case we can
      mark x as demanded, and use a case expression for it.
      The situation before is that we didn't "know" that there is the u(SS)
      demand on the argument, so we simply computed that the body of the let
      expression is lazy in x, and marked x as lazily-demanded.  Then even after
      f was w/w'd we got
    	let x = e1 in case (x,x) of (a,b) -> $wf a b
      and hence
    	let x = e1 in $wf a b
      I found a much more complicated situation in spectral/sphere/Main.shade,
      which improved quite a bit with this change.
    * Moved the StrictnessInfo type from IdInfo to Demand.  It's the logical
      place for it, and helps avoid module loops
    * Do worker/wrapper for coerces even if the arity is zero.  Thus:
    	stdout = coerce Handle (..blurg..)
    	wibble = (...blurg...)
    	stdout = coerce Handle wibble
      This is good because I found places where we were saying
    	case coerce t stdout of { MVar a ->
    	case coerce t stdout of { MVar b ->
      and the redundant case wasn't getting eliminated because of the coerce.