Skip to content
  • Edward Z. Yang's avatar
    Fix #13214 by correctly setting up dep_orphs for signatures. · 26eaa7ec
    Edward Z. Yang authored
    
    
    Prior to this, I hadn't thought about orphan handling at all.
    This commit implements the semantics that if a signature
    (transitively) imports an orphan instance, that instance
    is considered in scope no matter what the implementing module
    is.  (As it turns out, this is the semantics that falls out
    when orphans are recorded transitively.)
    
    This patch fixes a few bugs:
    
    1. Put semantic modules in dep_orphs rather than identity
       modules.
    2. Don't put the implementing module in dep_orphs when
       merging signatures (this is a silly bug that happened
       because we were reusing calculateAvails, which is
       designed for imports. It mostly works for signature
       merging, except this case.)
    3. When renaming a signature, blast in the orphans of the
       implementing module inside Dependencies.
    
    Signed-off-by: default avatarEdward Z. Yang <ezyang@cs.stanford.edu>
    
    Test Plan: validate
    
    Reviewers: bgamari, austin
    
    Reviewed By: bgamari
    
    Subscribers: thomie
    
    Differential Revision: https://phabricator.haskell.org/D3095
    26eaa7ec