Ben Gamari authored Mar 08, 2021 and Marge Bot committed Mar 17, 2021

In #19194 mpickering detailed that there are a LOT of allocations
of IfaceTyConInfo:

There are just two main cases: IfaceTyConInfo IsPromoted IfaceNormalTyCon
and IfaceTyConInfo NotPromoted IfaceNormalTyCon. These should be made into
CAFs and shared. From my analysis, the most common case is
IfaceTyConInfo NotPromoted IfaceNormalTyCon (53 000)
then IfaceTyConInfo IsPromoted IfaceNormalTyCon (28 000).

This patch makes it so these are properly shared by using a smart
constructor.

Fixes #19194.