Skip to content
  • Simon Marlow's avatar
    Fix failure in setnumcapabilities001 (#12728) · acc98510
    Simon Marlow authored and Ben Gamari's avatar Ben Gamari committed
    The value of enabled_capabilities can change across a call to
    requestSync(), and we were erroneously using an old value, causing
    things to go wrong later.  It manifested as an assertion failure, I'm
    not sure whether there are worse consequences or not, but we should
    get this fix into 8.0.2 anyway.
    
    The failure didn't happen for me because it only shows up on machines
    with fewer than 4 processors, due to the new logic to enable -qn
    automatically.  I've bumped the test parameter 8 to make it more
    likely to exercise that code.
    
    Test Plan: Ran setnumcapabilities001 many times
    
    Reviewers: niteria, austin, erikd, rwbarton, bgamari
    
    Reviewed By: bgamari
    
    Subscribers: thomie
    
    Differential Revision: https://phabricator.haskell.org/D2617
    
    GHC Trac Issues: #12728
    acc98510