Skip to content
  • John Ericson's avatar
    Trees That Grow refactor for `ConPat` and `CoPat` · c42754d5
    John Ericson authored and Marge Bot's avatar Marge Bot committed
    - `ConPat{In,Out}` -> `ConPat`
    
    - `CoPat` -> `XPat (CoPat ..)`
    
    Note that `GHC.HS.*` still uses `HsWrap`, but only when `p ~ GhcTc`.
    After this change, moving the type family instances out of `GHC.HS.*` is
    sufficient to break the cycle.
    
    Add XCollectPat class to decide how binders are collected from XXPat based on the pass.
    
    Previously we did this with IsPass, but that doesn't work for Haddock's
    DocNameI, and the constraint doesn't express what actual distinction is being
    made. Perhaps a class for collecting binders more generally is in order, but we
    haven't attempted this yet.
    
    Pure refactor of code around ConPat
    
     - InPat/OutPat synonyms removed
    
     - rename several identifiers
    
     - redundant constraints removed
    
     - move extension field in ConPat to be first
    
     - make ConPat use record syntax more consistently
    
    Fix T6145 (ConPatIn became ConPat)
    
    Add comments from SPJ.
    
    Add comment about haddock's use of CollectPass.
    
    Updates haddock submodule.
    c42754d5