Skip to content
  • spinda's avatar
    Generate .dyn_o files for .hsig files with -dynamic-too · d2b4df15
    spinda authored and Ben Gamari's avatar Ben Gamari committed
    With -dynamic-too, .dyn_o files were not being generated for .hsig
    files.  Normally, this is handled in the pipeline; however, the branch
    for .hsig files called compileEmptyStub directly instead of going
    through runPipeline.  When compiling a Cabal package that included .hsig
    files, this triggered a linker error later on, as it expected a .dyn_o
    file to have been generated for each .hsig.
    
    The fix is to use runPipeline for .hsig files, just as with .hs files.
    Alternately, one could duplicate the logic for handling -dynamic-too in
    the .hsig branch, but simply calling runPipeline ends up being much
    cleaner.
    
    Test Plan: validate
    
    Reviewers: austin, ezyang, bgamari, thomie
    
    Reviewed By: ezyang, thomie
    
    Subscribers: thomie
    
    Differential Revision: https://phabricator.haskell.org/D1084
    
    GHC Trac Issues: #10660
    d2b4df15