Skip to content
GitLab
Projects
Groups
Snippets
Help
Loading...
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Sign in / Register
Toggle navigation
GHC
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Locked Files
Issues
4,319
Issues
4,319
List
Boards
Labels
Service Desk
Milestones
Iterations
Merge Requests
367
Merge Requests
367
Requirements
Requirements
List
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Security & Compliance
Security & Compliance
Dependency List
License Compliance
Operations
Operations
Incidents
Environments
Analytics
Analytics
CI / CD
Code Review
Insights
Issue
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
Glasgow Haskell Compiler
GHC
Commits
19c4203f
Commit
19c4203f
authored
May 26, 2017
by
Gabor Greif
💬
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Typos in comments [ci skip]
parent
ad14efd5
Changes
8
Hide whitespace changes
Inline
Side-by-side
Showing
8 changed files
with
12 additions
and
12 deletions
+12
-12
compiler/llvmGen/Llvm/AbsSyn.hs
compiler/llvmGen/Llvm/AbsSyn.hs
+1
-1
compiler/main/ErrUtils.hs
compiler/main/ErrUtils.hs
+1
-1
compiler/typecheck/TcBinds.hs
compiler/typecheck/TcBinds.hs
+1
-1
compiler/typecheck/TcErrors.hs
compiler/typecheck/TcErrors.hs
+1
-1
compiler/typecheck/TcPatSyn.hs
compiler/typecheck/TcPatSyn.hs
+1
-1
compiler/typecheck/TcSMonad.hs
compiler/typecheck/TcSMonad.hs
+2
-2
compiler/typecheck/TcSimplify.hs
compiler/typecheck/TcSimplify.hs
+2
-2
compiler/typecheck/TcUnify.hs
compiler/typecheck/TcUnify.hs
+3
-3
No files found.
compiler/llvmGen/Llvm/AbsSyn.hs
View file @
19c4203f
...
...
@@ -267,7 +267,7 @@ data LlvmExpression
{- |
Cast the variable from to the to type. This is an abstraction of three
cast operators in Llvm, inttoptr, p
rt
toint and bitcast.
cast operators in Llvm, inttoptr, p
tr
toint and bitcast.
* cast: Cast type
* from: Variable to cast
* to: type to cast to
...
...
compiler/main/ErrUtils.hs
View file @
19c4203f
...
...
@@ -153,7 +153,7 @@ data Severity
|
SevInteractive
|
SevDump
-- ^ Log messag
s
e intended for compiler developers
-- ^ Log message intended for compiler developers
-- No file/line/column stuff
|
SevInfo
...
...
compiler/typecheck/TcBinds.hs
View file @
19c4203f
...
...
@@ -1619,7 +1619,7 @@ decideGeneralisationPlan dflags lbinds closed sig_fn
binds
=
map
unLoc
lbinds
partial_sig_mrs
::
[
Bool
]
-- One for each par
it
al signature (so empty => no partial sigs)
-- One for each par
ti
al signature (so empty => no partial sigs)
-- The Bool is True if the signature has no constraint context
-- so we should apply the MR
-- See Note [Partial type signatures and generalisation]
...
...
compiler/typecheck/TcErrors.hs
View file @
19c4203f
...
...
@@ -2035,7 +2035,7 @@ Conclusion: if there's an insoluble occurs check (isInsolubleOccursCheck)
then report it first.
(NB: there are potentially-soluble ones, like (a ~ F a b), and we don't
w
na
t to be as draconian with them.)
w
an
t to be as draconian with them.)
Note [Expanding type synonyms to make types similar]
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
...
...
compiler/typecheck/TcPatSyn.hs
View file @
19c4203f
...
...
@@ -208,7 +208,7 @@ Consider
pattern P x <- MkT x
This should work. But in the matcher we must match against MkT, and then
instantiate its argument 'x', to get a functi
no
of type (Int -> Int).
instantiate its argument 'x', to get a functi
on
of type (Int -> Int).
Equality is not enough! Trac #13752 was an example.
Note [Checking against a pattern signature]
...
...
compiler/typecheck/TcSMonad.hs
View file @
19c4203f
...
...
@@ -2837,7 +2837,7 @@ unflattenGivens :: IORef InertSet -> TcM ()
-- NB: this is the /only/ way that a fsk (MetaDetails = FlatSkolTv)
-- is filled in. Nothing else does so.
--
-- It's here (rather than in TcFlatten) bec
u
ause the Right Places
-- It's here (rather than in TcFlatten) because the Right Places
-- to call it are in runTcSWithEvBinds/nestImplicTcS, where it
-- is nicely paired with the creation an empty inert_fsks list.
unflattenGivens
inert_var
...
...
@@ -2885,7 +2885,7 @@ demoteUnfilledFmv fmv
{- *********************************************************************
* *
* Instant
aiation etc
* Instant
iation etc.
* *
********************************************************************* -}
...
...
compiler/typecheck/TcSimplify.hs
View file @
19c4203f
...
...
@@ -926,7 +926,7 @@ defaultTyVarsAndSimplify rhs_tclvl mono_tvs candidates
decideQuantifiedTyVars
::
TyCoVarSet
-- Monomorphic tyvars
->
[(
Name
,
TcType
)]
-- Annotated theta and (name,tau) pairs
->
[
TcIdSigInst
]
-- Par
it
al signatures
->
[
TcIdSigInst
]
-- Par
ti
al signatures
->
[
PredType
]
-- Candidates, zonked
->
TcM
[
TyVar
]
-- Fix what tyvars we are going to quantify over, and quantify them
...
...
@@ -1955,7 +1955,7 @@ floatEqualities skols no_given_eqs
=
return
(
emptyBag
,
wanteds
)
-- Note [Float Equalities out of Implications]
|
otherwise
=
do
{
-- First zonk: the inert set (from whence they came)
are
is fully
=
do
{
-- First zonk: the inert set (from whence they came) is fully
-- zonked, but unflattening may have filled in unification
-- variables, and we /must/ see them. Otherwise we may float
-- constraints that mention the skolems!
...
...
compiler/typecheck/TcUnify.hs
View file @
19c4203f
...
...
@@ -687,7 +687,7 @@ So roughly:
(i.e. skolemisation is the next thing we'd do)
* and the ty_actual has no top-level polymorphism (but looking deeply)
then we can revert to simple equality. But we need to be careful.
These examples are allfine:
These examples are all
fine:
* (Char -> forall a. a->a) <= (forall a. Char -> a -> a)
Polymorphism is buried in ty_actual
...
...
@@ -703,8 +703,8 @@ These examples are allfine:
ty_expected isn't really polymorphic
If we prematurely go to equality we'll reject a program we should
accept (e.g.
G
rac #13752). So the test (which is only to improve
error messag
s
e) is very conservative:
accept (e.g.
T
rac #13752). So the test (which is only to improve
error message) is very conservative:
* ty_actual is /definitely/ monomorphic
* ty_expected is /definitely/ polymorphic
-}
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment