Skip to content
GitLab
Projects
Groups
Snippets
Help
Loading...
Help
What's new
10
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Sign in / Register
Toggle navigation
Open sidebar
Glasgow Haskell Compiler
GHC
Commits
4e7d8350
Commit
4e7d8350
authored
Jun 21, 2016
by
Gabor Greif
💬
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Typos in comments [skip ci]
parent
9d62d09a
Changes
6
Hide whitespace changes
Inline
Side-by-side
Showing
6 changed files
with
7 additions
and
7 deletions
+7
-7
compiler/basicTypes/MkId.hs
compiler/basicTypes/MkId.hs
+1
-1
compiler/coreSyn/CoreLint.hs
compiler/coreSyn/CoreLint.hs
+1
-1
compiler/simplCore/OccurAnal.hs
compiler/simplCore/OccurAnal.hs
+1
-1
compiler/simplCore/Simplify.hs
compiler/simplCore/Simplify.hs
+1
-1
compiler/specialise/Specialise.hs
compiler/specialise/Specialise.hs
+2
-2
testsuite/tests/dependent/should_compile/dynamic-paper.hs
testsuite/tests/dependent/should_compile/dynamic-paper.hs
+1
-1
No files found.
compiler/basicTypes/MkId.hs
View file @
4e7d8350
...
...
@@ -393,7 +393,7 @@ mkDataConWorkId wkr_name data_con
-- the simplifier thinks that y is "sure to be evaluated" (because
-- $wMkT is strict) and drops the case. No, $wMkT is not strict.
--
-- When the simplifer sees a pattern
-- When the simplif
i
er sees a pattern
-- case e of MkT x -> ...
-- it uses the dataConRepStrictness of MkT to mark x as evaluated;
-- but that's fine... dataConRepStrictness comes from the data con
...
...
compiler/coreSyn/CoreLint.hs
View file @
4e7d8350
...
...
@@ -891,7 +891,7 @@ checkCaseAlts :: CoreExpr -> OutType -> [CoreAlt] -> LintM ()
-- b2) Check that the others are in increasing order
-- c) Check that there's a default for infinite types
-- NB: Algebraic cases are not necessarily exhaustive, because
-- the simplifer correctly eliminates case that can't
-- the simplif
i
er correctly eliminates case that can't
-- possibly match.
checkCaseAlts
e
ty
alts
=
...
...
compiler/simplCore/OccurAnal.hs
View file @
4e7d8350
...
...
@@ -958,7 +958,7 @@ reOrderNodes depth bndr_set weak_fvs (node : nodes) binds
|
otherwise
=
0
-- Checking for a constructor application
-- Cheap and cheerful; the simplifer moves casts out of the way
-- Cheap and cheerful; the simplif
i
er moves casts out of the way
-- The lambda case is important to spot x = /\a. C (f a)
-- which comes up when C is a dictionary constructor and
-- f is a default method.
...
...
compiler/simplCore/Simplify.hs
View file @
4e7d8350
...
...
@@ -2320,7 +2320,7 @@ knownCon env scrut dc dc_ty_args dc_args bndr bs rhs cont
-------------------
missingAlt
::
SimplEnv
->
Id
->
[
InAlt
]
->
SimplCont
->
SimplM
(
SimplEnv
,
OutExpr
)
-- This isn't strictly an error, although it is unusual.
-- It's possible that the simplifer might "see" that
-- It's possible that the simplif
i
er might "see" that
-- an inner case has no accessible alternatives before
-- it "sees" that the entire branch of an outer case is
-- inaccessible. So we simply put an error case here instead.
...
...
compiler/specialise/Specialise.hs
View file @
4e7d8350
...
...
@@ -398,7 +398,7 @@ Seems quite reasonable. Similar things could be done with instance decls:
Ho hum. Things are complex enough without this. I pass.
Requirements for the simplifer
Requirements for the simplif
i
er
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
The simplifier has to be able to take advantage of the specialisation.
...
...
@@ -1356,7 +1356,7 @@ crash. So we use Refl right off the bat, and do not forall-quantify 'g':
* exprsFreeIdsList returns the Ids bound by the args,
which won't include g
You might wonder if this will match as often, but the simplifer replaces
You might wonder if this will match as often, but the simplif
i
er replaces
complicated Refl coercions with Refl pretty aggressively.
Note [Orphans and auto-generated rules]
...
...
testsuite/tests/dependent/should_compile/dynamic-paper.hs
View file @
4e7d8350
...
...
@@ -2,7 +2,7 @@
Stephanie Weirich, Richard Eisenberg, and Dimitrios Vytiniotis, 2016. -}
-- NB: it includes a negative-recursive function (see delta1), and
-- so will give "simplifer ticks exhausted", at least with -O
-- so will give "simplif
i
er ticks exhausted", at least with -O
{-# LANGUAGE RankNTypes, PolyKinds, TypeOperators,
ScopedTypeVariables, GADTs, FlexibleInstances,
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment