Commit 5e968f92 authored by Ben Gamari's avatar Ben Gamari 🐢

HACKING: Update for Phabricator patch workflow

parent e83af07e
......@@ -49,13 +49,11 @@ $ cp mk/build.mk.sample mk/build.mk
$ ... double-check mk/build.mk ...
```
Now build. If you have multiple cores, **you should always use them to
speed up compilation**:
Now build. The convenient `validate` script will build the tree in a way which
is both quick to build and consistent with our testsuite,
```
$ ./boot
$ ./configure
$ make -jN # <N> is the number of cores you have.
$ ./validate --build-only
```
You can use the `./inplace/bin/ghc-stage2` binary to play with the
......@@ -63,26 +61,13 @@ newly built compiler.
Now, hack on your copy and rebuild (with `make`) as necessary.
Then start by making your commits however you want. When you're done, you
can use `git format-patch` to create a series of `.patch` files you
can give to us. In this example, we'll assume I'm on a `bugfix` branch
and want to submit my patches:
Then start by making your commits however you want. When you're done, you'll
need to submit your patch to [Phabricator](https://phabricator.haskell.org/) for
code review. To do so you will need to
[install Arcanist](https://secure.phabricator.com/book/phabricator/article/arcanist/#installing-arcanist),
Phabricator's CLI tool. Once installed, you can submit your work for code review
using `arc diff`.
```
$ git branch
* bugfix
master
$ git format-patch master -o patches
...
$
```
Now create a trac ticket:
<http://ghc.haskell.org/trac/ghc/newticket?type=bug>
And attach the files in your `patches/` directory. Set the status from
*new* to *patch* and we'll review it as soon as we can!
Useful links:
=============
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment