Skip to content
GitLab
Projects
Groups
Snippets
Help
Loading...
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Sign in / Register
Toggle navigation
GHC
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Locked Files
Issues
4,321
Issues
4,321
List
Boards
Labels
Service Desk
Milestones
Iterations
Merge Requests
366
Merge Requests
366
Requirements
Requirements
List
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Security & Compliance
Security & Compliance
Dependency List
License Compliance
Operations
Operations
Incidents
Environments
Analytics
Analytics
CI / CD
Code Review
Insights
Issue
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
Glasgow Haskell Compiler
GHC
Commits
5e968f92
Commit
5e968f92
authored
Apr 04, 2017
by
Ben Gamari
🐢
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
HACKING: Update for Phabricator patch workflow
parent
e83af07e
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
9 additions
and
24 deletions
+9
-24
HACKING.md
HACKING.md
+9
-24
No files found.
HACKING.md
View file @
5e968f92
...
@@ -49,13 +49,11 @@ $ cp mk/build.mk.sample mk/build.mk
...
@@ -49,13 +49,11 @@ $ cp mk/build.mk.sample mk/build.mk
$ ... double-check mk/build.mk ...
$ ... double-check mk/build.mk ...
```
```
Now build.
If you have multiple cores,
**
you should always use them to
Now build.
The convenient
`validate`
script will build the tree in a way which
speed up compilation
**
:
is both quick to build and consistent with our testsuite,
```
```
$ ./boot
$ ./validate --build-only
$ ./configure
$ make -jN # <N> is the number of cores you have.
```
```
You can use the
`./inplace/bin/ghc-stage2`
binary to play with the
You can use the
`./inplace/bin/ghc-stage2`
binary to play with the
...
@@ -63,26 +61,13 @@ newly built compiler.
...
@@ -63,26 +61,13 @@ newly built compiler.
Now, hack on your copy and rebuild (with
`make`
) as necessary.
Now, hack on your copy and rebuild (with
`make`
) as necessary.
Then start by making your commits however you want. When you're done, you
Then start by making your commits however you want. When you're done, you'll
can use
`git format-patch`
to create a series of
`.patch`
files you
need to submit your patch to
[
Phabricator
](
https://phabricator.haskell.org/
)
for
can give to us. In this example, we'll assume I'm on a
`bugfix`
branch
code review. To do so you will need to
and want to submit my patches:
[
install Arcanist
](
https://secure.phabricator.com/book/phabricator/article/arcanist/#installing-arcanist
)
,
Phabricator's CLI tool. Once installed, you can submit your work for code review
using
`arc diff`
.
```
$ git branch
* bugfix
master
$ git format-patch master -o patches
...
$
```
Now create a trac ticket:
<http://ghc.haskell.org/trac/ghc/newticket?type=bug>
And attach the files in your
`patches/`
directory. Set the status from
*new*
to
*patch*
and we'll review it as soon as we can!
Useful links:
Useful links:
=============
=============
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment