Commit 78833ca6 authored by Rufflewind's avatar Rufflewind Committed by Austin Seipp

Don't overwrite input file by default

Summary:
If the default filename of the output executable coincides with that of main
source file, throw an error instead of silently clobbering the input file.

Reviewers: austin

Reviewed By: austin

Subscribers: thomie

Differential Revision: https://phabricator.haskell.org/D642

GHC Trac Issues: #9930
parent 5d5abdca
......@@ -427,14 +427,22 @@ guessOutputFile = modifySession $ \env ->
ml_hs_file (ms_location ms)
name = fmap dropExtension mainModuleSrcPath
name_exe = do
#if defined(mingw32_HOST_OS)
-- we must add the .exe extention unconditionally here, otherwise
-- when name has an extension of its own, the .exe extension will
-- not be added by DriverPipeline.exeFileName. See #2248
name_exe = fmap (<.> "exe") name
-- we must add the .exe extention unconditionally here, otherwise
-- when name has an extension of its own, the .exe extension will
-- not be added by DriverPipeline.exeFileName. See #2248
name' <- fmap (<.> "exe") name
#else
name_exe = name
name' <- name
#endif
mainModuleSrcPath' <- mainModuleSrcPath
-- #9930: don't clobber input files (unless they ask for it)
if name' == mainModuleSrcPath'
then throwGhcException . UsageError $
"default output name would overwrite the input file; " ++
"must specify -o explicitly"
else Just name'
in
case outputFile dflags of
Just _ -> env
......
......@@ -19,3 +19,6 @@ ghc-e-fail1:
ghc-e-fail2:
'$(TEST_HC)' $(TEST_HC_OPTS) -ignore-dot-ghci -e "type A = A"
T9930fail:
'$(TEST_HC)' $(TEST_HC_OPTS) -ignore-dot-ghci -x hs T9930
......@@ -17,3 +17,6 @@ test('ghc-e-fail1', [exit_code(2), req_interp, ignore_output], run_command,
test('ghc-e-fail2', [exit_code(2), req_interp, ignore_output], run_command,
['$MAKE --no-print-directory -s ghc-e-fail2'])
test('T9930fail', [exit_code(2), ignore_output], run_command,
['$MAKE --no-print-directory -s T9930fail'])
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment