Commit 8669c48d authored by niteria's avatar niteria

Document why closeOverKind is OK for determinism

There's no point in converting the existing call sites to use
deterministic closeOverKinds if they never linearize the set.

Test Plan: it compiles, this is basically just documentation

Reviewers: simonpj, goldfire, simonmar, austin, bgamari

Reviewed By: bgamari

Subscribers: thomie

Differential Revision: https://phabricator.haskell.org/D2191

GHC Trac Issues: #4012
parent e207198f
......@@ -1513,7 +1513,9 @@ coVarsOfCos cos = mapUnionVarSet coVarsOfCo cos
-- | Add the kind variables free in the kinds of the tyvars in the given set.
-- Returns a non-deterministic set.
closeOverKinds :: TyVarSet -> TyVarSet
closeOverKinds = fvVarSet . closeOverKindsFV . varSetElems
closeOverKinds = fvVarSet . closeOverKindsFV . nonDetEltsUFM
-- It's OK to use nonDetEltsUFM here because we immediately forget
-- about the ordering by returning a set.
-- | Given a list of tyvars returns a deterministic FV computation that
-- returns the given tyvars with the kind variables free in the kinds of the
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment