Skip to content
Snippets Groups Projects
Commit 9a7e2ea1 authored by Matthew Pickering's avatar Matthew Pickering Committed by Marge Bot
Browse files

Revert "Refactor SpecConstr to use treat bindings uniformly" 

This reverts commit 415468fe.

This refactoring introduced quite a severe residency regression (900MB
live from 650MB live when compiling mmark), see #21993 for a reproducer
and more discussion.

Ticket #21993
parent 2361b3bc
No related branches found
No related tags found
Checking pipeline status
Hide whitespace changes
Inline Side-by-side
  • Marge Bot 💬 @marge-bot

    mentioned in merge request !8861 (closed)

     ·

    mentioned in merge request !8861 (closed)

    Toggle commit list
  • Dominik Peteler @mmhat ·
    Developer

    @mpickering I just noted that there are two references to scTopBinds (which got removed in this commit) in the note "Forcing specialisation" here and here. Is the note historical or do we need to update it?

  • Matthew Pickering @mpickering ·
    Author Developer

    It seems those references have been there since 7d7d94fb (2017) so I don't think they were updated for the reverted patch. Perhaps it would be good to open a ticket pointing out that the references are wrong but I don't think it's critical to fix.

0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment