Commit 9bf6310d authored by Niklas Hambüchen's avatar Niklas Hambüchen Committed by Ben Gamari

Add TODO about getMonotonicNSec() wrapping that can no longer happen.

Knowing this is important for followup commits, where we will subtract
getProcessElapsedTime() values from each other, in a way that assumes
that there is no wrapping every 49 days.

Reviewers: bgamari, austin, erikd, simonmar, NicolasT

Reviewed By: bgamari

Subscribers: rwbarton, thomie

GHC Trac Issues: #14233

Differential Revision: https://phabricator.haskell.org/D3964
parent 1e9f90af
......@@ -84,6 +84,11 @@ getMonotonicNSec()
}
else // fallback to GetTickCount
{
// TODO: Remove this code path, it cannot be taken because
// `QueryPerformanceFrequency` cannot fail on Windows >= XP
// and GHC no longer supports Windows <= XP.
// See https://ghc.haskell.org/trac/ghc/ticket/14233
// NOTE: GetTickCount is a 32-bit millisecond value, so it wraps around
// every 49 days.
DWORD count = GetTickCount();
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment