Skip to content
GitLab
Projects
Groups
Snippets
Help
Loading...
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Sign in / Register
Toggle navigation
GHC
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Locked Files
Issues
4,274
Issues
4,274
List
Boards
Labels
Service Desk
Milestones
Iterations
Merge Requests
412
Merge Requests
412
Requirements
Requirements
List
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Security & Compliance
Security & Compliance
Dependency List
License Compliance
Operations
Operations
Incidents
Environments
Analytics
Analytics
CI / CD
Code Review
Insights
Issue
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
Glasgow Haskell Compiler
GHC
Commits
bd53b488
Commit
bd53b488
authored
Oct 20, 2017
by
Andreas Klebinger
Committed by
Ben Gamari
Oct 25, 2017
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Add info about Github pull requests.
parent
bf83435b
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
6 additions
and
6 deletions
+6
-6
HACKING.md
HACKING.md
+6
-6
No files found.
HACKING.md
View file @
bd53b488
...
...
@@ -61,12 +61,12 @@ newly built compiler.
Now, hack on your copy and rebuild (with
`make`
) as necessary.
Then start by making your commits however you want. When you're done, you
'll
need to submit your patch to
[
Phabricator
](
https://phabricator.haskell.org/
)
for
code review. To do so you will need to
[
install Arcanist
](
https://secure.phabricator.com/book/phabricator/article/arcanist/#installing-arcanist
)
,
Phabricator's CLI tool. Once installed, you can submit your work for code review
using
`arc diff`
.
Then start by making your commits however you want. When you're done, you
can submit
a pull request on Github for small changes. For larger changes the patch needs to be
submitted to
[
Phabricator
](
https://phabricator.haskell.org/
)
for code review.
The GHC Trac Wiki has a good summary for the
[
overall process
](
https://ghc.haskell.org/trac/ghc/wiki/WorkingConventions/FixingBugs
)
as well as a guide on
[
how to use Phabricator/arcanist
](
https://ghc.haskell.org/trac/ghc/wiki/Phabricator
)
.
Useful links:
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment