1. 24 Nov, 2016 1 commit
  2. 21 Nov, 2016 6 commits
  3. 18 Nov, 2016 1 commit
  4. 17 Nov, 2016 3 commits
    • Facundo Domínguez's avatar
      Have reify work for local variables with functional dependencies. · 231a3ae1
      Facundo Domínguez authored
      It turned out that finalizers were run too early and information
      resulting from simplifying constraints was not available.
      
      This patch runs finalizers after a first call to simplifyTop, and
      then calls simplifyTop a second time to deal with constraints
      that could result from running the finalizers.
      
      Fixes T12777
      
      Test Plan: ./validate
      
      Reviewers: goldfire, simonpj, bgamari, austin
      
      Reviewed By: simonpj
      
      Subscribers: mpickering, mboes, thomie
      
      Differential Revision: https://phabricator.haskell.org/D2659
      
      GHC Trac Issues: #12777
      231a3ae1
    • Ben Gamari's avatar
      testsuite: Rip out hack for #12554 · 4d4f3533
      Ben Gamari authored
      @Phyx is working on correctly fixing (pun intended) the underlying issue
      that prompted this hack. It turns out that `timeout` it the culprit.
      Moreover, this hack breaks on msys python builds, which don't export
      `WindowsError`.
      
      Test Plan: Validate on Windows with `msys` python.
      
      Reviewers: Phyx, austin
      
      Subscribers: thomie, Phyx
      
      Differential Revision: https://phabricator.haskell.org/D2724
      
      GHC Trac Issues: #12554
      4d4f3533
    • Edward Z. Yang's avatar
      Test for type synonym loops on TyCon. · 31398fbc
      Edward Z. Yang authored
      Summary:
      Previously, we tested for type synonym loops by doing
      a syntactic test on the literal type synonym declarations.
      However, in some cases, loops could go through hs-boot
      files, leading to an infinite loop (#12042); a similar
      situation can occur when signature merging.
      
      This commit replaces the syntactic test with a test on
      TyCon, simply by walking down all type synonyms until
      we bottom out, or find we've looped back.  It's a lot
      simpler.
      Signed-off-by: default avatarEdward Z. Yang <ezyang@cs.stanford.edu>
      
      Test Plan: validate
      
      Reviewers: simonpj, austin, bgamari
      
      Subscribers: goldfire, thomie
      
      Differential Revision: https://phabricator.haskell.org/D2656
      
      GHC Trac Issues: #12042
      31398fbc
  5. 16 Nov, 2016 2 commits
  6. 15 Nov, 2016 2 commits
  7. 14 Nov, 2016 2 commits
    • Ben Gamari's avatar
      testsuite: Fix creep of T4029 · cb168900
      Ben Gamari authored
      Ostensibly due to IfaceType rework, but I have my doubts.
      cb168900
    • Simon Marlow's avatar
      Accept output for scc003 · 034e01e4
      Simon Marlow authored
      Looks like e3f341f3 broke it, but we
      wouldn't have noticed because the test isn't run in validate.
      
      I think the change is OK.  We don't get a tick for x' any more, because
      it is converted directly to a case instead of a let-binding, but we
      still get a tick for the "pattern binding" (!x').  This could be better
      - f.(...) isn't all that intuitive - but it's not strictly wrong.
      034e01e4
  8. 13 Nov, 2016 1 commit
    • Ben Gamari's avatar
      Kill Type pretty-printer · 6c0f10fa
      Ben Gamari authored
      Here we consolidate the pretty-printing logic for types in IfaceType. We
      need IfaceType regardless and the printer for Type can be implemented in
      terms of that for IfaceType. See #11660.
      
      Note that this is very much a work-in-progress. Namely I still have yet
      to ponder how to ease the hs-boot file situation, still need to rip out
      more dead code, need to move some of the special cases for, e.g., `*` to
      the IfaceType printer, and need to get it to validate. That being said,
      it comes close to validating as-is.
      
      Test Plan: Validate
      
      Reviewers: goldfire, austin
      
      Subscribers: goldfire, thomie, simonpj
      
      Differential Revision: https://phabricator.haskell.org/D2528
      
      GHC Trac Issues: #11660
      6c0f10fa
  9. 12 Nov, 2016 2 commits
  10. 10 Nov, 2016 2 commits
    • Ryan Scott's avatar
      Prevent GND from inferring an instance context for method-less classes · 03e8d26f
      Ryan Scott authored
      When `GeneralizedNewtypeDeriving` is used with a type class that has no
      methods, it will generate a redundant context, and as a result, it can
      trigger warnings when compiled with `-Wredundant-constraints`. This is a
      simple change in behavior to check beforehand if a class has methods
      when deriving it with GND, and if it has no methods, avoid inferring the
      redundant context.
      
      Beware that the test for #6088, which used to be expected to fail, now
      compiles without issue since it doesn't infer a problematic instance
      context.
      
      Thanks to Simon Peyton Jones for doing the necessary refactoring in
      f05d685a.
      
      Fixes #12814.
      
      Test Plan: ./validate
      
      Reviewers: goldfire, rwbarton, simonpj, austin, bgamari
      
      Reviewed By: simonpj
      
      Subscribers: thomie
      
      Differential Revision: https://phabricator.haskell.org/D2692
      
      GHC Trac Issues: #12814
      03e8d26f
    • Ben Gamari's avatar
      0a122a4c
  11. 07 Nov, 2016 1 commit
    • Simon Marlow's avatar
      Fix hs_try_putmvar003 (#12800) · 91f9e138
      Simon Marlow authored
      Summary:
      There was a race condition on some shared data when creating the
      callback thread.
      
      I couldn't repro the issue without inserting a dummy usleep(100), but
      it's definitely a bug.
      
      Test Plan: validate
      
      Reviewers: bgamari, austin, erikd
      
      Subscribers: thomie
      
      Differential Revision: https://phabricator.haskell.org/D2678
      
      GHC Trac Issues: #12800
      91f9e138
  12. 06 Nov, 2016 2 commits
  13. 05 Nov, 2016 1 commit
  14. 04 Nov, 2016 1 commit
  15. 03 Nov, 2016 3 commits
  16. 02 Nov, 2016 3 commits
    • Ben Gamari's avatar
      Add testcase for #12757 · b5460dd6
      Ben Gamari authored
      Test Plan: Validate, expected to fail
      
      Reviewers: austin
      
      Subscribers: thomie
      
      Differential Revision: https://phabricator.haskell.org/D2665
      
      GHC Trac Issues: #12757
      b5460dd6
    • Ben Gamari's avatar
      testsuite: Simplify kernel32 glue logic · cc4710af
      Ben Gamari authored
      On Windows the testsuite driver calls kernel32 to set the current
      terminal codepage. The previous implementation of this was significantly
      more complex than necessary, and was wrong in the case of MSYS2, which
      requires that we explicitly load the library using the name of its
      DLL, including its file extension.
      
      Test Plan: Validate on Windows
      
      Reviewers: austin, RyanGlScott, Phyx
      
      Reviewed By: RyanGlScott, Phyx
      
      Subscribers: thomie
      
      Differential Revision: https://phabricator.haskell.org/D2641
      
      GHC Trac Issues: #12661
      cc4710af
    • Simon Peyton Jones's avatar
      Fix Trac #12797: approximateWC · 13508bad
      Simon Peyton Jones authored
      This patch makes approximateWC a bit more gung-ho when called
      from the defaulting code.  See Note [ApproximateWC], item (1).
      13508bad
  17. 01 Nov, 2016 1 commit
  18. 31 Oct, 2016 2 commits
    • Tamar Christina's avatar
      Align GHCi's library search order more closely with LDs · 795be0ea
      Tamar Christina authored
      Summary:
      Given a static library and an import library in the same folder. e.g.
      
      ```
      libfoo.a
      libfoo.dll.a
      ```
      
      running `ghci -lfoo` we should prefer the import library `libfoo.dll.a`
      over `libfoo.a` because we prefer having to just load the DLL.
      And not having to do any linking.
      
      This also more closely emulated the behaviour of LD, which has a search order of
      
      ```
      libxxx.dll.a
      xxx.dll.a
      libxxx.a
      cygxxx.dll (*)
      libxxx.dll
      xxx.dll
      ```
      
      Test Plan: ./validate
      
      Reviewers: RyanGlScott, austin, hvr, bgamari, erikd, simonmar
      
      Reviewed By: RyanGlScott
      
      Subscribers: thomie, #ghc_windows_task_force
      
      Differential Revision: https://phabricator.haskell.org/D2651
      
      GHC Trac Issues: #12771
      795be0ea
    • Gabor Greif's avatar
      Typos in comments · 80d4a033
      Gabor Greif authored
      80d4a033
  19. 28 Oct, 2016 2 commits
  20. 27 Oct, 2016 1 commit
  21. 26 Oct, 2016 1 commit