1. 10 Jun, 2016 2 commits
  2. 09 Jun, 2016 14 commits
    • Facundo Domínguez's avatar
      Improve the error messages for static forms. · e9dfb6e5
      Facundo Domínguez authored
      Now the message explains why closed variables are not closed when
      encountered in the body of (static ...).
      
      This required adding to the local environment the free variables of
      the local bindings in scope. Thus we can analyze and explain why a
      variable is not closed when encountered.
      
      Test Plan: ./validate
      
      Reviewers: austin, simonpj, bgamari
      
      Reviewed By: bgamari
      
      Subscribers: mboes, thomie
      
      Differential Revision: https://phabricator.haskell.org/D2167
      
      GHC Trac Issues: #12003
      e9dfb6e5
    • Tamar Christina's avatar
      Fix Ticky histogram on Windows · b020db2a
      Tamar Christina authored
      Summary:
      The histogram types are defined in `Ticky.c` as `StgInt` values.
      
      ```
      EXTERN StgInt RET_NEW_hst[TICKY_BIN_COUNT] INIT({0});
      EXTERN StgInt RET_OLD_hst[TICKY_BIN_COUNT] INIT({0});
      EXTERN StgInt RET_UNBOXED_TUP_hst[TICKY_BIN_COUNT] INIT({0});
      ```
      
      which means they'll be `32-bits` on `x86` and `64-bits` on `x86_64`.
      
      However the `bumpHistogram` in `StgCmmTicky` is incrementing them as if
      they're a `cLong`. A long on Windows `x86_64` is `32-bit`.
      
      As such when then value for the `_hst_1` is being set what it's actually doing
      is setting the value of the high bits of the first entry.
      
      This ends up giving us `0b‭100000000000000000000000000000000‬` or `4294967296`
      as is displayed in the ticket on #8308.
      
      Since `StgInt` is defined using the `WORD` size. Just use that directly in
      `bumpHistogram`.
      
      Also since `cLong` is no longer used after this commit it will also be dropped.
      
      Test Plan: make TEST=T8308
      
      Reviewers: mlen, jstolarek, bgamari, thomie, goldfire, simonmar, austin
      
      Reviewed By: bgamari, thomie
      
      Subscribers: #ghc_windows_task_force
      
      Differential Revision: https://phabricator.haskell.org/D2318
      
      GHC Trac Issues: #8308
      b020db2a
    • thomie's avatar
      Docs: delete PatternGuards documentation · c22ab1a6
      thomie authored
      Since `-XPatternGuards` is enabled by default, invert the logic and
      mention `-XNoPatternGuards` first.
      
      Also, since this is a Haskell 2010 feature, refer to the language report
      instead of explaining it.
      
      In general, I would like to follow the guideline of assuming the latest
      language report as a given, and then only report GHC's deviations and
      extensions relative to that report.
      
      Reviewed by: bgamari
      
      Differential Revision: https://phabricator.haskell.org/D2319
      
      GHC Trac Issues: #12172
      c22ab1a6
    • niteria's avatar
      Remove Ord AltCon · 77b8c29b
      niteria authored
      It uses Ord DataCon which uses Ord Unique which is
      nondeterministic
      
      GHC Trac: #4012
      77b8c29b
    • niteria's avatar
      Remove Ord PatSyn · b2624ee3
      niteria authored
      It's implemented in terms of Unique which is nondeterministic
      
      GHC Trac: #4012
      b2624ee3
    • niteria's avatar
      Remove Ord Class · 70e0a564
      niteria authored
      It was implemented in terms of Unique which is nondeterministic
      
      GHC Trac: #4012
      70e0a564
    • thomie's avatar
      Docs: fix links to ghc-flags · e703a232
      thomie authored
      e703a232
    • thomie's avatar
      Testsuite: delete dead code [skip ci] · 9dbf354f
      thomie authored
      9dbf354f
    • niteria's avatar
      Remove Ord (CoAxiom br) · 68c1c29d
      niteria authored
      It was implemented in terms of Uniques, but fortunately it's unused
      so we can remove it.
      
      GHC Trac: #4012
      68c1c29d
    • niteria's avatar
      Implement Eq TyCon directly · ceaf7f10
      niteria authored
      Eq TyCon is defined in terms of Ord TyCon, but we want to
      remove Ord TyCon, because it's implemented in terms of unique
      comparison, which is nondeterministic.
      
      GHC Trac: #4012
      ceaf7f10
    • Tamar Christina's avatar
      Remove special casing of Windows in generic files · 48385cb2
      Tamar Christina authored
      Summary:
      Remove some Windows specific code from the .m4 files
      and have configure figure it out.
      
      Unfortunately touchy can't be removed since there
      is no mingw build of coreutils. Only msys builds
      which would give us a dependency on the msys runtime.
      
      Reviewers: hvr, austin, thomie, bgamari
      
      Reviewed By: thomie, bgamari
      
      Subscribers: thomie, erikd, #ghc_windows_task_force
      
      Differential Revision: https://phabricator.haskell.org/D2248
      48385cb2
    • Edward Z. Yang's avatar
      Fix #12076 by inlining trivial expressions in CorePrep. · 11ff1df8
      Edward Z. Yang authored
      
      
      Summary:
      This mostly follows the plan detailed by the discussion
      Simon and I had, with one difference: instead of grabbing
      the free variables of the trivial expressions to get the
      embedded Ids, we just use getIdFromTrivialExpr_maybe to extract
      out the Id.  If there is no Id, the expression cannot
      refer to a function (as there are no literal functions)
      and thus we do not need to saturate.
      Signed-off-by: default avatarEdward Z. Yang <ezyang@cs.stanford.edu>
      
      Test Plan: validate
      
      Reviewers: simonpj, austin, bgamari
      
      Subscribers: thomie
      
      Differential Revision: https://phabricator.haskell.org/D2309
      
      GHC Trac Issues: #12076
      11ff1df8
    • Edward Z. Yang's avatar
      acb9e85c
    • Edward Z. Yang's avatar
      Fix #12064 by making IfaceClass typechecking more lazy. · 8f6d2927
      Edward Z. Yang authored
      
      
      Summary:
      Comes with a test based off of prog006.
      Signed-off-by: default avatarEdward Z. Yang <ezyang@cs.stanford.edu>
      
      Test Plan: validate
      
      Reviewers: simonpj, austin, bgamari
      
      Subscribers: thomie
      
      Differential Revision: https://phabricator.haskell.org/D2221
      
      GHC Trac Issues: #12064
      8f6d2927
  3. 08 Jun, 2016 6 commits
    • Ömer Sinan Ağacan's avatar
      Show sources of cost centers in .prof · d7933cbc
      Ömer Sinan Ağacan authored
      This fixes the problem with duplicate cost-centre names that was
      reported a couple of times before. When a module implements a typeclass
      multiple times for different types, methods of different implementations
      get same cost-centre names and are reported like this:
      
          COST CENTRE MODULE            %time %alloc
      
          CAF         GHC.IO.Handle.FD    0.0   32.8
          CAF         GHC.Read            0.0    1.0
          CAF         GHC.IO.Encoding     0.0    1.8
          showsPrec   Main                0.0    1.2
          readPrec    Main                0.0   19.4
          readPrec    Main                0.0   20.5
          main        Main                0.0   20.2
      
                                                  individual      inherited
          COST CENTRE  MODULE  no.     entries  %time %alloc   %time %alloc
      
          MAIN         MAIN     53          0    0.0    0.2     0.0  100.0
           CAF         Main    105          0    0.0    0.3     0.0   62.5
            readPrec   Main    109          1    0.0    0.6     0.0    0.6
            readPrec   Main    107          1    0.0    0.6     0.0    0.6
            main       Main    106          1    0.0   20.2     0.0   61.0
             ==        Main    114          1    0.0    0.0     0.0    0.0
             ==        Main    113          1    0.0    0.0     0.0    0.0
             showsPrec Main    112          2    0.0    1.2     0.0    1.2
             showsPrec Main    111          2    0.0    0.9     0.0    0.9
             readPrec  Main    110          0    0.0   18.8     0.0   18.8
             readPrec  Main    108          0    0.0   19.9     0.0   19.9
      
      It's not possible to tell from the report which `==` took how long. This
      patch adds one more column at the cost of making outputs wider. The
      report now looks like this:
      
          COST CENTRE MODULE           SRC                       %time %alloc
      
          CAF         GHC.IO.Handle.FD <entire-module>             0.0   32.9
          CAF         GHC.IO.Encoding  <entire-module>             0.0    1.8
          CAF         GHC.Read         <entire-module>             0.0    1.0
          showsPrec   Main             Main_1.hs:7:19-22           0.0    1.2
          readPrec    Main             Main_1.hs:7:13-16           0.0   19.5
          readPrec    Main             Main_1.hs:4:13-16           0.0   20.5
          main        Main             Main_1.hs:(10,1)-(20,20)    0.0   20.2
      
                                                                             individual      inherited
          COST CENTRE  MODULE        SRC                      no. entries  %time %alloc   %time %alloc
      
          MAIN         MAIN          <built-in>                53      0    0.0    0.2     0.0  100.0
           CAF         Main          <entire-module>          105      0    0.0    0.3     0.0   62.5
            readPrec   Main          Main_1.hs:7:13-16        109      1    0.0    0.6     0.0    0.6
            readPrec   Main          Main_1.hs:4:13-16        107      1    0.0    0.6     0.0    0.6
            main       Main          Main_1.hs:(10,1)-(20,20) 106      1    0.0   20.2     0.0   61.0
             ==        Main          Main_1.hs:7:25-26        114      1    0.0    0.0     0.0    0.0
             ==        Main          Main_1.hs:4:25-26        113      1    0.0    0.0     0.0    0.0
             showsPrec Main          Main_1.hs:7:19-22        112      2    0.0    1.2     0.0    1.2
             showsPrec Main          Main_1.hs:4:19-22        111      2    0.0    0.9     0.0    0.9
             readPrec  Main          Main_1.hs:7:13-16        110      0    0.0   18.8     0.0   18.8
             readPrec  Main          Main_1.hs:4:13-16        108      0    0.0   19.9     0.0   19.9
           CAF         Text.Read.Lex <entire-module>          102      0    0.0    0.5     0.0    0.5
      
      To fix failing test cases because of different orderings of cost centres
      (e.g. optimized and non-optimized build printing in different order),
      with this patch we also start sorting cost centres before printing. The
      order depends on 1) entries (more entered cost centres come first) 2)
      names (using strcmp() on cost centre names).
      
      Reviewers: simonmar, austin, erikd, bgamari
      
      Reviewed By: simonmar, bgamari
      
      Subscribers: thomie
      
      Differential Revision: https://phabricator.haskell.org/D2282
      
      GHC Trac Issues: #11543, #8473, #7105
      d7933cbc
    • Ömer Sinan Ağacan's avatar
      80cf4cf0
    • Ömer Sinan Ağacan's avatar
      Report term sizes with -v3 even when -ddump is enabled · c2bbc8ba
      Ömer Sinan Ağacan authored
      This is the proper fix for the problem I tried solve with D2310
      (committed as dd332459 and reverted in 44a3c182).
      
      Reviewers: austin, goldfire, bgamari
      
      Reviewed By: bgamari
      
      Subscribers: thomie
      
      Differential Revision: https://phabricator.haskell.org/D2315
      c2bbc8ba
    • Ömer Sinan Ağacan's avatar
      Revert "Desugar: Display resulting program stats with -v2" · 44a3c182
      Ömer Sinan Ağacan authored
      This reverts commit dd332459.
      
      It seems like we already have `endPassIO` calls here, which should print
      term sizes. For some reason they don't sometimes, and we need to
      understand why instead of adding more prints.
      44a3c182
    • Ömer Sinan Ağacan's avatar
      Desugar: Display resulting program stats with -v2 · dd332459
      Ömer Sinan Ağacan authored
      Reviewers: austin, bgamari
      
      Reviewed By: bgamari
      
      Subscribers: thomie
      
      Differential Revision: https://phabricator.haskell.org/D2310
      dd332459
    • niteria's avatar
      Add some determinism tests · d4b548ef
      niteria authored
      These are the tests that I accumulated fixing real issues.
      Each test is a separate thing that was broken and they are
      relatively small.
      
      GHC Trac: #4012
      d4b548ef
  4. 07 Jun, 2016 14 commits
  5. 06 Jun, 2016 4 commits
    • Alan Zimmerman's avatar
      Merge MatchFixity and HsMatchContext · a13cb279
      Alan Zimmerman authored
      Summary:
      MatchFixity was introduced to facilitate use of API Annotations.
      
      HsMatchContext does the same thing with more detail, but is chased
      through all over the place to provide context when processing a Match.
      
      Since we already have MatchFixity in the Match, it may as well provide
      the full context.
      
      updates submodule haddock
      
      Test Plan: ./validate
      
      Reviewers: austin, goldfire, bgamari
      
      Subscribers: thomie, mpickering
      
      Differential Revision: https://phabricator.haskell.org/D2271
      
      GHC Trac Issues: #12105
      
      (cherry picked from commit 306ecad5)
      a13cb279
    • niteria's avatar
      Make UnitIdMap a deterministic map · 1937ef1c
      niteria authored
      This impacts at least the order in which version macros are
      generated. It's pretty hard to track what kind of nondeterminism
      is benign and this should have no performance impact as the number
      of packages should be relatively small.
      
      Test Plan: ./validate
      
      Reviewers: simonmar, austin, bgamari, ezyang
      
      Reviewed By: ezyang
      
      Subscribers: thomie
      
      Differential Revision: https://phabricator.haskell.org/D2308
      
      GHC Trac Issues: #4012
      1937ef1c
    • niteria's avatar
      Kill foldUniqSet · 3e7a876a
      niteria authored
      I planned to just say that we don't care about this part.
      Turns out I was able to document away the uses in the codegenerator.
      
      Test Plan: ./validate
      
      Reviewers: simonmar, austin, bgamari
      
      Subscribers: thomie
      
      Differential Revision: https://phabricator.haskell.org/D2307
      
      GHC Trac Issues: #4012
      3e7a876a
    • niteria's avatar
      Document putDictionary determinism · 46d2da00
      niteria authored
      Summary: Like explained in the comment it's OK here.
      
      Test Plan: ./validate
      
      Reviewers: simonmar, austin, bgamari
      
      Subscribers: thomie
      
      Differential Revision: https://phabricator.haskell.org/D2306
      
      GHC Trac Issues: #4012
      46d2da00