1. 20 Sep, 2019 2 commits
    • Ben Gamari's avatar
    • Alp Mestanogullari's avatar
      ErrUtils: split withTiming into withTiming and withTimingSilent · b3e5c731
      Alp Mestanogullari authored
      'withTiming' becomes a function that, when passed '-vN' (N >= 2) or
      '-ddump-timings', will print timing (and possibly allocations) related
      information. When additionally built with '-eventlog' and executed with
      '+RTS -l', 'withTiming' will also emit both 'traceMarker' and 'traceEvent'
      events to the eventlog.
      'withTimingSilent' on the other hand will never print any timing information,
      under any circumstance, and will only emit 'traceEvent' events to the eventlog.
      As pointed out in !1672, 'traceMarker' is better suited for things that we
      might want to visualize in tools like eventlog2html, while 'traceEvent'
      is better suited for internal events that occur a lot more often and that we
      don't necessarily want to visualize.
      This addresses #17138 by using 'withTimingSilent' for all the codegen bits
      that are expressed as a bunch of small computations over streams of codegen
  2. 19 Sep, 2019 9 commits
    • Ben Gamari's avatar
      testsuite: Add testcase for #17206 · 52173990
      Ben Gamari authored
    • Sebastian Graf's avatar
      Add a regression test for #11822 · 2a8867cf
      Sebastian Graf authored
      The particular test is already fixed, but the issue seems to have
      multiple different test cases lumped together.
    • Sebastian Graf's avatar
      Extract PmTypes module from PmExpr and PmOracle · baf47661
      Sebastian Graf authored
      Apparently ghc-lib-parser's API blew up because the newly induced cyclic
      dependency between TcRnTypes and PmOracle pulled in the other half of
      GHC into the relevant strongly-connected component.
      This patch arranges it so that PmTypes exposes mostly data type
      definitions and type class instances to be used within PmOracle, without
      importing the any of the possibly offending modules DsMonad, TcSimplify
      and FamInst.
    • Ben Gamari's avatar
      CoreUtils: Use mightBeUnliftedType in exprIsTopLevelBindable · 912afaf4
      Ben Gamari authored
      Also add reference from isUnliftedType to mightBeUnliftedType.
    • Richard Eisenberg's avatar
      Test #17077. · c675d08f
      Richard Eisenberg authored
    • Richard Eisenberg's avatar
      Use level numbers for generalisation · f594a68a
      Richard Eisenberg authored
      This fixes #15809, and is covered in
      Note [Use level numbers for quantification] in TcMType.
      This patch removes the "global tyvars" from the
      environment, a nice little win.
    • Richard Eisenberg's avatar
      Refactor kindGeneralize and friends · d9c6b86e
      Richard Eisenberg authored
      This commit should have no change in behavior.(*)
      The observation was that Note [Recipe for checking a signature]
      says that every metavariable in a type-checked type must either
        (A) be generalized
        (B) be promoted
        (C) be zapped.
      Yet the code paths for doing these were all somewhat separate.
      This led to some steps being skipped. This commit shores this
      all up. The key innovation is TcHsType.kindGeneralizeSome, with
      appropriate commentary.
      This commit also sets the stage for #15809, by turning the
      WARNing about bad level-numbers in generalisation into an
      ASSERTion. The actual fix for #15809 will be in a separate
      Other changes:
       * zonkPromoteType is now replaced by kindGeneralizeNone.
         This might have a small performance degradation, because
         zonkPromoteType zonked and promoted all at once. The new
         code path promotes first, and then zonks.
       * A call to kindGeneralizeNone was added in tcHsPartialSigType.
         I think this was a lurking bug, because it did not follow
         Note [Recipe for checking a signature]. I did not try to
         come up with an example showing the bug. This is the (*)
         Because of this change, there is an error message regression
         in partial-sigs/should_fail/T14040a. This problem isn't really
         a direct result of this refactoring, but is a symptom of
         something deeper. See #16775, which addresses the deeper
       * I added a short-cut to quantifyTyVars, in case there's
         nothing to quantify.
       * There was a horribly-outdated Note that wasn't referred
         to. Gone now.
       * While poking around with T14040a, I discovered a small
         mistake in the Coercion.simplifyArgsWorker. Easy to fix,
       * See new Note [Free vars in coercion hole] in TcMType.
         Previously, we were doing the wrong thing when looking
         at a coercion hole in the gather-candidates algorithm.
         Fixed now, with lengthy explanation.
      Metric Decrease:
    • Ben Gamari's avatar
      Simplify: Lazy pattern match · de1723b2
      Ben Gamari authored
    • Simon Peyton Jones's avatar
      Add a missing update of sc_hole_ty (#16312) · c3eaaca6
      Simon Peyton Jones authored
      In simplCast I totally failed to keep the sc_hole_ty field of
      ApplyToTy (see Note [The hole type in ApplyToTy]) up to date.
      When a cast goes by, of course the hole type changes.
      Amazingly this has not bitten us before, but #16312 finally
      triggered it.  Fortunately the fix is simple.
      Fixes #16312.
  3. 17 Sep, 2019 5 commits
  4. 16 Sep, 2019 4 commits
    • Sebastian Graf's avatar
      Encode shape information in `PmOracle` · 7915afc6
      Sebastian Graf authored
      Previously, we had an elaborate mechanism for selecting the warnings to
      generate in the presence of different `COMPLETE` matching groups that,
      albeit finely-tuned, produced wrong results from an end user's
      perspective in some cases (#13363).
      The underlying issue is that at the point where the `ConVar` case has to
      commit to a particular `COMPLETE` group, there's not enough information
      to do so and the status quo was to just enumerate all possible complete
      sets nondeterministically.  The `getResult` function would then pick the
      outcome according to metrics defined in accordance to the user's guide.
      But crucially, it lacked knowledge about the order in which affected
      clauses appear, leading to the surprising behavior in #13363.
      In !1010 we taught the term oracle to reason about literal values a
      variable can certainly not take on. This MR extends that idea to
      `ConLike`s and thereby fixes #13363: Instead of committing to a
      particular `COMPLETE` group in the `ConVar` case, we now split off the
      matching constructor incrementally and record the newly covered case as
      a refutable shape in the oracle. Whenever the set of refutable shapes
      covers any `COMPLETE` set, the oracle recognises vacuosity of the
      uncovered set.
      This patch goes a step further: Since at this point the information
      in value abstractions is merely a cut down representation of what the
      oracle knows, value abstractions degenerate to a single `Id`, the
      semantics of which is determined by the oracle state `Delta`.
      Value vectors become lists of `[Id]` given meaning to by a single
      `Delta`, value set abstractions (of which the uncovered set is an
      instance) correspond to a union of `Delta`s which instantiate the
      same `[Id]` (akin to models of formula).
      Fixes #11528 #13021, #13363, #13965, #14059, #14253, #14851, #15753, #17096, #17149
      Metric Decrease:
    • Sylvain Henry's avatar
    • Sylvain Henry's avatar
      Fix Hadrian build with Stack (#17189) · 7208160d
      Sylvain Henry authored
      Broken by 2b37a79d
    • Ben Gamari's avatar
      Rename GHC.StgToCmm.Con -> GHC.StgToCmm.DataCon · cf7e78a3
      Ben Gamari authored
      Incredibly, Windows disallows the manipulation of any file matching
      Con(\..*)?. The `GHC.StgToCmm.Con` was introduced in the renamings in
      447864a9, breaking the Windows build. Work around this by renaming it to
      Fixes #17187.
  5. 14 Sep, 2019 1 commit
  6. 13 Sep, 2019 10 commits
  7. 12 Sep, 2019 5 commits
  8. 11 Sep, 2019 4 commits
    • Tamar Christina's avatar
      Windows: make openTempFile fully atomic. · 3a7d3923
      Tamar Christina authored
    • Ömer Sinan Ağacan's avatar
      Refactor bad coercion checking in a few places · c76cc0c6
      Ömer Sinan Ağacan authored
      We do bad coercion checking in a few places in the compiler, but they
      all checked it differently:
      - CoreToStg.coreToStgArgs:
        Disallowed lifted-to-unlifted, disallowed changing prim reps even when
        the sizes are the same.
      - StgCmmExpr.cgCase:
        Checked primRepSlot equality. This disallowed Int to Int64 coercions
        on 64-bit systems (and Int to Int32 on 32-bit) even though those are
      - CoreLint:
        Only place where we do this right. Full rules are explained in Note
        [Bad unsafe coercion].
      This patch implements the check explained in Note [Bad unsafe coercion]
      in CoreLint and uses it in CoreToStg.coreToStgArgs and
      This fixes #16952 and unblocks !1381 (which fixes #16893).
      This is the most conservative and correct change I came up with that
      fixes #16952.
      One remaining problem with coercion checking is that it's currently done
      in seemingly random places. What's special about CoreToStg.coreToStgArgs
      and StgCmmExpr.cgCase? My guess is that adding assertions to those
      places caught bugs before so we left assertions in those places. I think
      we should remove these assertions and do coercion checking in CoreLint
      and StgLint only (#17041).
    • Ben Gamari's avatar
      SetLevels: Fix potential panic in lvlBind · 7ef6fe8f
      Ben Gamari authored
      3b31a94d introduced a use of isUnliftedType which can panic in the case
      of levity-polymorphic types. Fix this by introducing mightBeUnliftedType
      which returns whether the type is *guaranteed* to be lifted.
    • John Ericson's avatar
      Remove dead `ncgDebugIsOn` and `NCG_DEBUG` · d9e637df
      John Ericson authored
      Haven't been used since 16206a66.