1. 05 May, 2019 1 commit
  2. 04 May, 2019 5 commits
  3. 03 May, 2019 8 commits
    • Ryan Scott's avatar
      Make equality constraints in kinds invisible · cc495d57
      Ryan Scott authored
      Issues #12102 and #15872 revealed something strange about the way GHC
      handles equality constraints in kinds: it treats them as _visible_
      arguments! This causes a litany of strange effects, from strange
      error messages
      (#12102 (comment 169035))
      to bizarre `Eq#`-related things leaking through to GHCi output, even
      without any special flags enabled.
      This patch is an attempt to contain some of this strangeness.
      In particular:
      * In `TcHsType.etaExpandAlgTyCon`, we propagate through the
        `AnonArgFlag`s of any `Anon` binders. Previously, we were always
        hard-coding them to `VisArg`, which meant that invisible binders
        (like those whose kinds were equality constraint) would mistakenly
        get flagged as visible.
      * In `ToIface.toIfaceAppArgsX`, we previously assumed that the
        argument to a `FunTy` always corresponding to a `Required`
        argument. We now dispatch on the `FunTy`'s `AnonArgFlag` and map
        `VisArg` to `Required` and `InvisArg` to `Inferred`. As a
        consequence, the iface pretty-printer correctly recognizes that
        equality coercions are inferred arguments, and as a result,
        only displays them in `-fprint-explicit-kinds` is enabled.
      * Speaking of iface pretty-printing, `Anon InvisArg` binders were
        previously being pretty-printed like `T (a :: b ~ c)`, as if they
        were required. This seemed inconsistent with other invisible
        arguments (that are printed like `T @{d}`), so I decided to switch
        this to `T @{a :: b ~ c}`.
      Along the way, I also cleaned up a minor inaccuracy in the users'
      guide section for constraints in kinds that was spotted in
      #12102 (comment 136220).
      Fixes #12102 and #15872.
    • Ömer Sinan Ağacan's avatar
      Fix interface version number printing in --show-iface · 87bc954a
      Ömer Sinan Ağacan authored
          Version: Wanted [8, 0, 9, 0, 2, 0, 1, 9, 0, 4, 2, 5],
                   got    [8, 0, 9, 0, 2, 0, 1, 9, 0, 4, 2, 5]
          Version: Wanted 809020190425,
                   got    809020190425
    • Ningning Xie's avatar
    • Vladislav Zavialov's avatar
      Pattern/expression ambiguity resolution · 52fc2719
      Vladislav Zavialov authored
      This patch removes 'EWildPat', 'EAsPat', 'EViewPat', and 'ELazyPat'
      from 'HsExpr' by using the ambiguity resolution system introduced
      earlier for the command/expression ambiguity.
      Problem: there are places in the grammar where we do not know whether we
      are parsing an expression or a pattern, for example:
      	do { Con a b <- x } -- 'Con a b' is a pattern
      	do { Con a b }      -- 'Con a b' is an expression
      Until we encounter binding syntax (<-) we don't know whether to parse
      'Con a b' as an expression or a pattern.
      The old solution was to parse as HsExpr always, and rejig later:
      	checkPattern :: LHsExpr GhcPs -> P (LPat GhcPs)
      This meant polluting 'HsExpr' with pattern-related constructors. In
      other words, limitations of the parser were affecting the AST, and all
      other code (the renamer, the typechecker) had to deal with these extra
      We fix this abstraction leak by parsing into an overloaded
      	class DisambECP b where ...
      	newtype ECP = ECP { runECP_PV :: forall b. DisambECP b => PV (Located b) }
      See Note [Ambiguous syntactic categories] for details.
      Now the intricacies of parsing have no effect on the hsSyn AST when it
      comes to the expression/pattern ambiguity.
    • Alp Mestanogullari's avatar
      Hadrian: generate JUnit testsuite report in Linux CI job · 8f929388
      Alp Mestanogullari authored
      We also keep it as an artifact, like we do for non-Hadrian jobs, and list it
      as a junit report, so that the test results are reported in the GitLab UI for
      merge requests.
    • Ben Gamari's avatar
      testsuite: Mark concprog001 as fragile · 0dde64f2
      Ben Gamari authored
      Due to #16604.
    • Shayne Fletcher's avatar
      Make Extension derive Bounded · 9047f184
      Shayne Fletcher authored
    • Sven Tennie's avatar
      Typeset Big-O complexities with Tex-style notation (#16090) · 4186b410
      Sven Tennie authored
      Use `\min` instead of `min` to typeset it as an operator.
  4. 01 May, 2019 7 commits
    • Ben Gamari's avatar
      Emit GHC timing events to eventlog · ebfa3528
      Ben Gamari authored
    • Ben Gamari's avatar
      ErrUtils: Emit progress messages to eventlog · 1bef62c3
      Ben Gamari authored
    • Alp Mestanogullari's avatar
    • John Ericson's avatar
      Move cGHC_UNLIT_PGM to be "unlit command" in settings · 2988ef5e
      John Ericson authored
      The bulk of the work was done in #712, making settings be make/Hadrian
      controlled. This commit then just moves the unlit command rules in
      make/Hadrian from the `Config.hs` generator to the `settings` generator
      in each build system.
      I think this is a good change because the crucial benefit is *settings*
      don't affect the build: ghc gets one baby step closer to being a regular
      cabal executable, and make/Hadrian just maintains settings as part of
    • John Ericson's avatar
      Remove settings.in · 53d1cd96
      John Ericson authored
      It is no longer needed
    • John Ericson's avatar
      Generate settings by make/hadrian instead of configure · d37d91e9
      John Ericson authored
      This allows it to eventually become stage-specific
    • Sebastian Graf's avatar
      Compute demand signatures assuming idArity · 014ed644
      Sebastian Graf authored
      This does four things:
      1. Look at `idArity` instead of manifest lambdas to decide whether to use LetUp
      2. Compute the strictness signature in LetDown assuming at least `idArity`
         incoming arguments
      3. Remove the special case for trivial RHSs, which is subsumed by 2
      4. Don't perform the W/W split when doing so would eta expand a binding.
         Otherwise we would eta expand PAPs, causing unnecessary churn in the
      NoFib Results
              Program         Allocs    Instrs
       fannkuch-redux          +0.3%      0.0%
                   gg          -0.0%     -0.1%
             maillist          +0.2%     +0.2%
              minimax           0.0%     +0.8%
               pretty           0.0%     -0.1%
              reptile          -0.0%     -1.2%
                  Min          -0.0%     -1.2%
                  Max          +0.3%     +0.8%
       Geometric Mean          +0.0%     -0.0%
  5. 30 Apr, 2019 7 commits
  6. 25 Apr, 2019 6 commits
  7. 24 Apr, 2019 1 commit
  8. 23 Apr, 2019 2 commits
  9. 22 Apr, 2019 3 commits
    • Vladislav Zavialov's avatar
      Stop misusing EWildPat in pattern match coverage checking · 1959bad3
      Vladislav Zavialov authored
      EWildPat is a constructor of HsExpr used in the parser to represent
      wildcards in ambiguous positions:
      * in expression context, EWildPat is turned into hsHoleExpr (see rnExpr)
      * in pattern context, EWildPat is turned into WildPat (see checkPattern)
      Since EWildPat exists solely for the needs of the parser, we could
      remove it by improving the parser.
      However, EWildPat has also been used for a different purpose since
      8a506104: to represent patterns that the coverage checker cannot handle.
      Not only this is a misuse of EWildPat, it also stymies the removal of
    • Alp Mestanogullari's avatar
      Hadrian: use the testsuite driver's config.haddock arg more correctly · 51655fd8
      Alp Mestanogullari authored
      4 haddock tests assume that .haddock files have been produced, by using the
      'req_haddock' modifier. The testsuite driver assumes that this condition is
      satisfied if 'config.haddock' is non-empty, but before this patch Hadrian was
      always passing the path to where the haddock executable should be, regardless
      of whether it is actually there or not.
      Instead, we now pass an empty config.haddock when we can't find all of
      <build root>/docs/html/libraries/<pkg>/<pkg>.haddock>, where <pkg> ranges over
      array, base, ghc-prim, process and template-haskell, and pass the path
      to haddock when all those file exists. This has the (desired) effect of skipping
      the 4 tests (marked as 'missing library') when the docs haven't been built,
      and running the haddock tests when they have.
    • Matthew Pickering's avatar
      Correct off by one error in ghci +c · 1a7a329b
      Matthew Pickering authored
      Fixes #16569