Commits · 61b245a0c8abd365dcaa69b3190cf950603a1960 · Glasgow Haskell Compiler / GHC

08 May, 2018 1 commit

Simon Peyton Jones authored May 04, 2018

This refactoring was provoked by our conversation on
Trac #14152.  No change in behaviour.

61b245a0

06 May, 2018 6 commits

printStackChunk: recognise a few more ret frames · 875b61ea
Ömer Sinan Ağacan authored May 06, 2018

875b61ea
testsuite: Bump T5631 expected allocations · 7271db46
Ben Gamari authored May 05, 2018
```
This was failing on Darwin; I believe this is due to 33de71fa.
```
7271db46
base/changelog: Note stabilization of asinh (#14927 ) · 46548ed1
Ben Gamari authored May 05, 2018

46548ed1

Stable area hyperbolic sine for `Double` and `Float`. · 3ea33411

Justus Sagemüller authored Mar 28, 2018 and

Ben Gamari committed May 05, 2018

This function was unstable, in particular for negative arguments.

https://ghc.haskell.org/trac/ghc/ticket/14927

The reason is that the formula `log (x + sqrt (1 + x*x))` is dominated
by the numerical error of the `sqrt` function when x is strongly negative
(and thus the summands in the `log` mostly cancel). However, the area
hyperbolic sine is an odd function, thus the negative side can as well
be calculated by flipping over the positive side, which avoids this instability.

Furthermore, for _very_ big arguments, the `x*x` subexpression overflows. However,
long before that happens, the square root is anyways completely dominated
by that term, so we can neglect the `1 +` and get

    sqrt (1 + x*x) ≈ sqrt (x*x) = x

and therefore

    asinh x ≈ log (x + x) = log (2*x) = log 2 + log x

which does not overflow for any normal-finite positive argument, but
perfectly matches the exact formula within the floating-point accuracy.

3ea33411

Add hyperbolic functions to test of Float-inverses · d814dd38
Justus Sagemüller authored Mar 28, 2018 and Ben Gamari committed May 05, 2018
```
The area hyperbolic sine is currently broken,
see https://ghc.haskell.org/trac/ghc/ticket/14927.
```
d814dd38

Add test for invertability of `Floating` methods. · be580b42

Justus Sagemüller authored Mar 28, 2018 and

Ben Gamari committed May 05, 2018

These functions have inverses only on part of the real line, but
there they should be reliably inverted – that's basically the whole
point of the functions like `asin`, `atan` etc..

be580b42

05 May, 2018 10 commits

Add 'addWordC#' PrimOp · 6243bba7

Sebastian Graf authored May 05, 2018 and

Ben Gamari committed May 05, 2018

This is mostly for congruence with 'subWordC#' and '{add,sub}IntC#'.
I found 'plusWord2#' while implementing this, which both lacks
documentation and has a slightly different specification than
'addWordC#', which means the generic implementation is unnecessarily
complex.

While I was at it, I also added lacking meta-information on PrimOps
and refactored 'subWordC#'s generic implementation to be branchless.

Reviewers: bgamari, simonmar, jrtc27, dfeuer

Reviewed By: bgamari, dfeuer

Subscribers: dfeuer, thomie, carter

Differential Revision: https://phabricator.haskell.org/D4592

6243bba7

Use unsafeInsertNew to create timers in TimerManager · 418881f7
MitchellSalad authored Apr 30, 2018 and Ben Gamari committed May 05, 2018

418881f7
Do not supply `-mcpu` if `-optlc` provides `-mcpu` already. · cb1ee7e1
Moritz Angermann authored May 04, 2018 and Ben Gamari committed May 05, 2018
```
Reviewers: bgamari

Subscribers: thomie, carter

GHC Trac Issues: #14982

Differential Revision: https://phabricator.haskell.org/D4548
```
cb1ee7e1

testsuite: Add test for · 0f046aae

Ben Gamari authored May 04, 2018 and

Ben Gamari committed May 05, 2018

Subscribers: thomie, carter, RyanGlScott

GHC Trac Issues: #15067

Differential Revision: https://phabricator.haskell.org/D4622

0f046aae

Normalize the element type of ListPat, fix · 361d23a8

Tao He authored May 03, 2018 and

Ben Gamari committed May 05, 2018

The element type of `List` maybe a type family instacen, rather than a
trivial type.  For example in Trac #14547,

```
{-# LANGUAGE TypeFamilies, OverloadedLists #-}

class Foo f where
        type It f
        foo :: [It f] -> f

data List a = Empty | a :! List a deriving Show

instance Foo (List a) where
        type It (List a) = a
        foo [] = Empty
        foo (x : xs) = x :! foo xs
```

Here the element type of `[]` is `It (List a)`, we should also normalize
it as `a`.

Test Plan: make test TEST="T14547"

Reviewers: bgamari

Reviewed By: bgamari

Subscribers: thomie, carter

GHC Trac Issues: #14547

Differential Revision: https://phabricator.haskell.org/D4624

361d23a8

Split TrieMap into a general (TrieMap) and core specific (CoreTrieMap) module. · 426ae988

Andreas Klebinger authored May 03, 2018 and

Ben Gamari committed May 05, 2018

Splitting TrieMap into a general and core specific part allows us to
define instances for TrieMap without creating a transitive dependency on
CoreSyn.

Test Plan: ci

Reviewers: goldfire, bgamari, simonmar, simonpj

Reviewed By: bgamari, simonpj

Subscribers: simonpj, nomeata, thomie, carter

GHC Trac Issues: #15082

Differential Revision: https://phabricator.haskell.org/D4618

426ae988

rel-notes: Note that -hT is now allowed · 49f59430
Ben Gamari authored May 03, 2018
```
See #15086.

[skip-ci]
```
49f59430
Fix typo in user guide about promoted list · 13e8bc0d
Masahiro Sakai authored Apr 26, 2018 and Ben Gamari committed May 05, 2018
```
`:'` in explanation text should be `':` to match code example.
```
13e8bc0d

Update docker images to use GHC 8.4.2 and cabal-install-2.2 · 56e8c6fc

Mark Karpov authored Apr 26, 2018 and

Ben Gamari committed May 05, 2018

The ‘haskell’ images are not being updated and there is no image with GHC
8.4.2, so we probably should not use them anymore. I adapted Dockerfiles
used by those images so the end result is almost the same except we get
newer GHC and cabal-install.

56e8c6fc

testsuite: Bump T9630 allocations as a result of · b750dcc5

Ben Gamari authored May 05, 2018

This patch made the simplifier inline nested function bindings less aggressively
and, while it didn't seem to affect nofib, appears to have regressed T9630
rather considerably.

b750dcc5

04 May, 2018 2 commits

Simplify callSiteInline a little · 33de71fa

Simon Peyton Jones authored May 04, 2018

This patch has virtually no effect on anything (according to a
nofib run).  But it simplifies the definition of interesting_call
by being a bit less gung-ho about inlining nested function
bindings.  See Note [Nested functions]

-----------------------------------------------------------------------
        Program           Size    Allocs   Runtime   Elapsed  TotalMem
-----------------------------------------------------------------------
           anna          +0.2%     -0.0%     0.163     0.163      0.0%
   binary-trees          +0.1%     +0.0%     -4.5%     -4.5%      0.0%
      cacheprof          -0.1%     +0.1%     -4.7%     -4.8%     +2.7%
          fasta          +0.2%      0.0%     +2.6%     +3.0%      0.0%
          fluid          -0.0%     -0.6%     0.011     0.011      0.0%
         gamteb          -0.1%     -0.0%     0.069     0.070      0.0%
            hpg          +0.1%     +0.0%     +0.7%     +0.7%      0.0%
          infer          +0.3%     +0.2%     0.097     0.098      0.0%
         lambda          -0.1%     -0.0%     +2.0%     +2.0%      0.0%
         n-body          +0.1%     -0.1%     -0.1%     -0.1%      0.0%
         simple          -0.2%     -0.2%     +0.6%     +0.6%      0.0%
  spectral-norm          +0.1%     -0.0%     -0.1%     -0.1%      0.0%
            tak          -0.0%     -0.1%     0.024     0.024      0.0%
--------------------------------------------------------------------------------
            Min          -0.4%     -0.6%     -5.3%     -5.3%      0.0%
            Max          +0.3%     +0.2%     +3.3%     +3.3%    +15.0%
 Geometric Mean          -0.0%     -0.0%     -0.3%     -0.3%     +0.2%

33de71fa

Normalize T14999 test output some more · 56974323

niteria authored May 04, 2018

@osa1 reported that the output on his machine has extra newlines:
https://phabricator.haskell.org/D4606#129092. This collapses consecutive
newlines.

56974323

03 May, 2018 15 commits

Enable warning flags to safe-guard against regressions in `base` · 79c4f10e
Herbert Valerio Riedel authored May 03, 2018 and Ben Gamari committed May 03, 2018
```
Test Plan: via CI

Reviewers: bgamari

Subscribers: dfeuer, thomie, carter

Differential Revision: https://phabricator.haskell.org/D4640
```
79c4f10e