1. 09 Jun, 2019 8 commits
    • Richard Eisenberg's avatar
      Fix #16517 by bumping the TcLevel for method sigs · a22e51ea
      Richard Eisenberg authored
      There were actually two bugs fixed here:
      
      1. candidateQTyVarsOfType needs to be careful that it does not
         try to zap metavariables from an outer scope as "naughty"
         quantification candidates. This commit adds a simple check
         to avoid doing so.
      
      2. We weren't bumping the TcLevel in kcHsKindSig, which was used
         only for class method sigs. This mistake led to the acceptance
         of
      
           class C a where
             meth :: forall k. Proxy (a :: k) -> ()
      
         Note that k is *locally* quantified. This patch fixes the
         problem by using tcClassSigType, which correctly bumps the
         level. It's a bit inefficient because tcClassSigType does other
         work, too, but it would be tedious to repeat much of the code
         there with only a few changes. This version works well and is
         simple.
      
      And, while updating comments, etc., I noticed that tcRnType was
      missing a pushTcLevel, leading to #16767, which this patch also
      fixes, by bumping the level. In the refactoring here, I also
      use solveEqualities. This initially failed ghci/scripts/T15415,
      but that was fixed by teaching solveEqualities to respect
      -XPartialTypeSignatures.
      
      This patch also cleans up some Notes around error generation that
      came up in conversation.
      
      Test case: typecheck/should_fail/T16517, ghci/scripts/T16767
      a22e51ea
    • KevinBuhr's avatar
      Handle trailing path separator in package DB names (#16360) · 9d238791
      KevinBuhr authored
      Package DB directories with trailing separator (provided via
      GHC_PACKAGE_PATH or via -package-db) resulted in incorrect calculation of
      ${pkgroot} substitution variable.  Keep the trailing separator while
      resolving as directory or file, but remove it before dropping the last
      path component with takeDirectory.
      
      Closes #16360.
      9d238791
    • Simon Jakobi's avatar
      Small refactorings in ExtractDocs · b9fe91fc
      Simon Jakobi authored
      b9fe91fc
    • Ben Gamari's avatar
      testsuite: Add test for #16514 · 41bf4045
      Ben Gamari authored
      41bf4045
    • chessai's avatar
      Introduce log1p and expm1 primops · f7370333
      chessai authored
      Previously log and exp were primitives yet log1p and expm1 were FFI
      calls. Fix this non-uniformity.
      f7370333
    • Ben Gamari's avatar
      testsuite: Suppress ticks in T4918 output · a018c3a8
      Ben Gamari authored
      As noted in #16741, this test otherwise breaks when `base` is compiled
      with `-g`.
      a018c3a8
    • Matthew Pickering's avatar
      hadrian: Properly partition options in sourceArgs · 970e4802
      Matthew Pickering authored
      Previously if you build the `ghc` package then it would has the default
      opts and the library opts. This is different behaviour to make where the
      library opts are only reserved for things in the `libraries`
      subdirectory (I believe)
      
      Fixes #16716
      970e4802
    • Alexandre R. Baldé's avatar
  2. 08 Jun, 2019 10 commits
  3. 07 Jun, 2019 17 commits
  4. 04 Jun, 2019 5 commits