1. 29 Feb, 2020 5 commits
    • xldenis's avatar
      Rename ghci.sh and build.sh to ghci and build respectively · a999ee96
      xldenis authored
      Convert hadrian buildscripts to unsuffixed, dashed form
      final cleanups
    • Ben Gamari's avatar
      plugins: Ensure that loadInterface plugins can see annotations · 99d2de86
      Ben Gamari authored
      loadInterface replaces the `mi_decls`, `mi_insts`, `mi_fam_insts`,
      `mi_rules`, `mi_anns` fields of ModIface with `undefined` before
      inserting the interface into the EPS. However, we still want to give
      loadInterface plugins access to these fields. Consequently, we want to
      pass the unmodified `ModIface` the plugin.
    • Vladislav Zavialov's avatar
      Monotonic locations (#17632) · 327b29e1
      Vladislav Zavialov authored
      When GHC is parsing a file generated by a tool, e.g. by the C preprocessor, the
      tool may insert #line pragmas to adjust the locations reported to the user.
      As the result, the locations recorded in RealSrcLoc are not monotonic. Elements
      that appear later in the StringBuffer are not guaranteed to have a higher
      line/column number.
      In fact, there are no guarantees whatsoever, as #line pragmas can arbitrarily
      modify locations. This lack of guarantees makes ideas such as #17544
      This patch adds an additional bit of information to every SrcLoc:
      	newtype BufPos = BufPos { bufPos :: Int }
      A BufPos represents the location in the StringBuffer, unaffected by any
      Updates haddock submodule.
      Metric Increase:
    • Ilias Tsitsimpis's avatar
      llvm-targets: Add arm-unknown-linux-gnueabi · 37f12603
      Ilias Tsitsimpis authored
      Add arm-unknown-linux-gnueabi, which is used by Debian's ARM EABI port
      (armel), as an LLVM target.
    • Simon Peyton Jones's avatar
      Improve error handling for VTA + deferred type errors · 66f5d6d6
      Simon Peyton Jones authored
      This fixes #17792
      See Note [VTA for out-of-scope functions] in TcExpr
  2. 28 Feb, 2020 3 commits
  3. 27 Feb, 2020 2 commits
    • Adam Sandberg Eriksson's avatar
    • Sebastian Graf's avatar
      PmCheck: Implement Long-distance information with Covered sets · 74311e10
      Sebastian Graf authored
      data T = A | B | C
      f :: T -> Int
      f A = 1
      f x = case x of
        A -> 2
        B -> 3
        C -> 4
      Clearly, the RHS returning 2 is redundant. But we don't currently see
      that, because our approximation to the covered set of the inner case
      expression just picks up the positive information from surrounding
      pattern matches. It lacks the context sensivity that `x` can't be `A`
      Therefore, we adopt the conceptually and practically superior approach
      of reusing the covered set of a particular GRHS from an outer pattern
      match. In this case, we begin checking the `case` expression with the
      covered set of `f`s second clause, which encodes the information that
      `x` can't be `A` anymore. After this MR, we will successfully warn about
      the RHS returning 2 being redundant.
      Perhaps surprisingly, this was a great simplification to the code of
      both the coverage checker and the desugarer.
      Found a redundant case alternative in `unix` submodule, so we have to
      bump it with a fix.
      Metric Decrease:
  4. 26 Feb, 2020 18 commits
  5. 25 Feb, 2020 3 commits
  6. 24 Feb, 2020 4 commits
    • Ben Gamari's avatar
      Bump directory submodule to · 84dd9610
      Ben Gamari authored
    • Ben Gamari's avatar
      users-guide: Drop old release notes · e3f17413
      Ben Gamari authored
    • Ben Gamari's avatar
      users-guide: Shuffle text · 5aa6c188
      Ben Gamari authored
    • Vladislav Zavialov's avatar
      Remove Ord SrcLoc, Ord SrcSpan · 26e8fff3
      Vladislav Zavialov authored
      Before this patch, GHC relied on Ord SrcSpan to identify source elements, by
      using SrcSpan as Map keys:
      	blackList :: Map SrcSpan ()      -- compiler/GHC/HsToCore/Coverage.hs
      	instanceMap :: Map SrcSpan Name  -- compiler/GHC/HsToCore/Docs.hs
      Firstly, this design is not valid in presence of UnhelpfulSpan, as it
      distinguishes between  UnhelpfulSpan "X"  and  UnhelpfulSpan "Y", but those
      strings are messages for the user, unfit to serve as identifiers for source
      Secondly, this design made it hard to extend SrcSpan with additional data.
      Recall that the definition of SrcSpan is:
      	data SrcSpan =
      	    RealSrcSpan !RealSrcSpan
      	  | UnhelpfulSpan !FastString
      Say we want to extend the RealSrcSpan constructor with additional information:
      	data SrcSpan =
      	    RealSrcSpan !RealSrcSpan !AdditionalInformation
      	  | UnhelpfulSpan !FastString
      	getAdditionalInformation :: SrcSpan -> AdditionalInformation
      	getAdditionalInformation (RealSrcSpan _ a) = a
      Now, in order for  Map SrcSpan  to keep working correctly, we must *ignore* additional
      information when comparing SrcSpan values:
      	instance Ord SrcSpan where
      	  compare (RealSrcSpan r1 _) (RealSrcSpan r2 _) = compare r1 r2
      However, this would violate an important law:
      	a == b  therefore  f a == f b
      Ignoring  AdditionalInformation  in comparisons would mean that with
      f=getAdditionalInformation, the law above does not hold.
      A more robust design is to avoid  Ord SrcSpan  altogether, which is what this patch implements.
      The mappings are changed to use RealSrcSpan instead:
      	blackList :: Set RealSrcSpan         -- compiler/GHC/HsToCore/Coverage.hs
      	instanceMap :: Map RealSrcSpan Name  -- compiler/GHC/HsToCore/Docs.hs
      All SrcSpan comparisons are now done with explicit comparison strategies:
      These strategies are not subject to the law mentioned above and can easily
      discard both the string stored in  UnhelpfulSpan  and  AdditionalInformation.
      Updates haddock submodule.
  7. 23 Feb, 2020 4 commits
  8. 22 Feb, 2020 1 commit