A previous fix to this was wrong: f5879acd
and left some unreachable code behind.  So rather than try to be clever and
do this at the same time as the strongly-connected-component analysis, I'm
doing a separate reachability pass first.

Its marked as broken, as this does not work yet, but we are calling it a
day here soon, so I want this to be recorded (#8959).

using the same check as for unicode quotes.

When printing Haskell source, and UnicodeSyntax is enabled, use the
unicode sytax characters (#8959).

to what I observe on travis and on my validate machine, even though my
local tree produces the previous output.

Implements #9069

Conflicts:
	docs/users_guide/flags.xml

This was a serious bug, exposed by Trac #9175.  The matcher and wrapper
must be LocalIds, like record selectors and dictionary functions, for
the reasons now documented in Note [Exported LocalIds] in Id.lhs

In fixing this I found
 - PatSyn should have an Id inside it (apart from the wrapper and matcher)
   It should be a Name.  Hence psId --> psName, with knock-on consequences

 - Tidying of PatSyns in TidyPgm was wrong

 - The keep-alive set in Desugar.deSugar (now) doesn't need pattern synonyms
   in it

I also cleaned up the interface to PatSyn a little, so there's a tiny knock-on
effect in Haddock; hence the haddock submodule update.

It's very hard to make a test for this bug, so I haven't.

instead of just one matching directly. This is an alternative way to fix
ticket #9177.

and the other way around. This fixes #9177.

See, what did I tell you? Broken!

Signed-off-by: Austin Seipp <austin@well-typed.com>

Signed-off-by: Austin Seipp <austin@well-typed.com>

Fixes #9080



Signed-off-by: Austin Seipp <austin@well-typed.com>

Don't use this yet - it's an experiment, a disaster, whatever. Caveat
emptor. I'll probably delete everything. Do not taunt Happy Fun Ball -
you have been warned.

Signed-off-by: Austin Seipp <austin@well-typed.com>

We simply weren't giving anything like the right instantiating types
to patSynInstArgTys in matchOneConLike.

To get these instantiating types would have involved matching the
result type of the pattern synonym with the pattern type, which is
tiresome.  So instead I changed ConPatOut so that instead of recording
the type of the *whole* pattern (in old field pat_ty), it not records
the *instantiating* types (in new field pat_arg_tys).  Then we canuse
TcHsSyn.conLikeResTy to get the pattern type when needed.

There are lots of knock-on incidental effects, but they mostly made
the code simpler, so I'm happy.

owst authored Apr 10, 2014 and Krzysztof Gogolewski committed Jun 04, 2014

MPTC now also handles the nullary case

This just addresses the specific issue raised in #9165

. However, I've noticed
the Haddock comments need to be improved, which will be addressed by a separate
commit.

Signed-off-by: Herbert Valerio Riedel <hvr@gnu.org>

In the future, some script will use the last column to configure
Git to redirect `push` operations to the respective primary Git
repo.

One way could be via the `pushInsteadOf` facility described in

  https://ghc.haskell.org/trac/ghc/wiki/WorkingConventions/Git/Submodules



Signed-off-by: Herbert Valerio Riedel <hvr@gnu.org>

The type variables in the IfaceEqSpec of a data constructor are really
ordinarly *occurrences*, so they should be IfLclNames just like any
other type variable occurence.

All the initial work on this was done fy 'archblob' (fcsernik@gmail.com);
thank you!

I reviewed the patch, started some tidying, up and then ended up in a huge
swamp of changes, not all of which I can remember now.  But:

* To suppress kind arguments when we have -fno-print-explicit-kinds,
    - IfaceTyConApp argument types are in a tagged list IfaceTcArgs

* To allow overloaded types to be printed with =>, add IfaceDFunTy to IfaceType.

* When printing data/type family instances for the user, I've made them
  print out an informative RHS, which is a new feature. Thus
        ghci> info T
        data family T a
        data instance T Int = T1 Int Int
        data instance T Bool = T2

* In implementation terms, pprIfaceDecl has just one "context" argument,
  of type IfaceSyn.ShowSub, which says
       - How to print the binders of the decl
         see note [Printing IfaceDecl binders] in IfaceSyn
       - Which sub-comoponents (eg constructors) to print

* Moved FastStringEnv from RnEnv to OccName

It all took a ridiculously long time to do.  But it's done!

This was mostly done in an earlier commit, but I missed these two