GitLab

Noticed by uselex.rb:
    last_free_capability: [R]: exported from:
        ./rts/dist/build/Capability.o
    shutdownCapability: [R]: exported from:
        ./rts/dist/build/Capability.o
Signed-off-by: Sergei Trofimovich <siarheit@google.com>

Not used since:

    commit f361281c


    Author: Simon Marlow <marlowsd@gmail.com>
    Date:   Wed Dec 7 11:32:35 2011 +0000

        Do not emit the THREAD_RUNNABLE event; it has no useful semantic content

Noticed by uselex.rb:
    traceEventThreadRunnable: [R]: exported from:
        ./rts/dist/build/Inlines.o
Signed-off-by: Sergei Trofimovich <siarheit@google.com>

Noticed by uselex.rb:
    ccs_mutex: [R]: exported from:
        ./rts/dist/build/Profiling.thr_p_o
    prof_arena: [R]: exported from:
        ./rts/dist/build/Profiling.p_o
Signed-off-by: Sergei Trofimovich <siarheit@google.com>

Noticed by uselex.rb:
    blockedThrowTo: [R]: exported from:
        ./rts/dist/build/RaiseAsync.o
Signed-off-by: Sergei Trofimovich <siarheit@google.com>

While at is mark 'printRetainer' as 'static'.

Noticed by uselex.rb:
    printRetainer: [R]: exported from:
        ./rts/dist/build/RetainerSet.p_o
    traverseAllRetainerSet: [R]: exported from:
        ./rts/dist/build/RetainerSet.p_o
Signed-off-by: Sergei Trofimovich <siarheit@google.com>

Noticed by uselex.rb:
    setProgName: [R]: exported from:
        ./rts/dist/build/RtsFlags.o
Signed-off-by: Sergei Trofimovich <siarheit@google.com>

Noticed by uselex.rb:
    removeFromRunQueue: [R]: exported from:
        ./rts/dist/build/Schedule.o
Signed-off-by: Sergei Trofimovich <siarheit@google.com>

Was never used looking at history available in git.

While at it marked 'mut_user_time_during_RP' as 'static'.

Noticed by uselex.rb:
    mut_user_time_during_heap_census: [R]: exported from:
        ./rts/dist/build/Stats.p_o
Signed-off-by: Sergei Trofimovich <siarheit@google.com>

Noticed by uselex.rb:
    wakeBlockingQueue: [R]: exported from:
        ./rts/dist/build/Threads.o
Signed-off-by: Sergei Trofimovich <siarheit@google.com>

Use of this helper function was removed in:

    commit 3c9fc104


    Author: Brian Brooks <brooks.brian@gmail.com>
    Date:   Thu Jul 10 02:55:33 2014 -0500

        Avoid unnecessary clock_gettime() syscalls in GC stats.

Noticed by uselex.rb:
    getThreadCPUTime: [R]: exported from:
        ./rts/dist/build/posix/GetTime.p_o
Signed-off-by: Sergei Trofimovich <siarheit@google.com>

Noticed by uselex.rb:
    copied: [R]: exported from:
        ./rts/dist/build/sm/GC.o
Signed-off-by: Sergei Trofimovich <siarheit@google.com>

Noticed by uselex.rb:
    scavenge_mutable_list: [R]: exported from:
        ./rts/dist/build/sm/Scav.o
    scavenge_mutable_list1: [R]: exported from:
        ./rts/dist/build/sm/Scav.thr_o
Signed-off-by: Sergei Trofimovich <siarheit@google.com>

Use of these helper functions was removed by
  commit 18896fa2


  Author: Simon Marlow <marlowsd@gmail.com>
  Date:   Wed Feb 2 15:49:55 2011 +0000

Noticed by uselex.rb:
    calcLiveBlocks: [R]: exported from:
        ./rts/dist/build/sm/Storage.o
    calcLiveWords: [R]: exported from:
        ./rts/dist/build/sm/Storage.o
Signed-off-by: Sergei Trofimovich <siarheit@google.com>

Since the whole point of validation is to test the compiler, assertions
should be enabled at least for some part of the build. Previously
assertions were only enabled (1) in stage 2 compiler (2) when "slow"
setting is used. With this patch we enable assertions in stage 1
compiler in all settings, to test them on (1) the compiler itself (2)
the libraries, even with the "fast" setting.

This will make "fast" setting slower, but the difference should be quite
modest - I didn't realize a significant difference in validation times.

Reviewers: bgamari, austin, thomie

Reviewed By: thomie

Differential Revision: https://phabricator.haskell.org/D1890

Fixes #11419

Fixes #11419.

Signed-off-by: Sergei Trofimovich <siarheit@google.com>

Found by uselex.rb:
    fonttab: [R]: exported from: ./utils/hp2ps/dist/build/Dimensions.o
    GetString: [R]: exported from: ./utils/hp2ps/dist/build/HpFile.o
    thestring: [R]: exported from: ./utils/hp2ps/dist/build/HpFile.o
    auxfp: [R]: exported from: ./utils/hp2ps/dist/build/Main.o
    dflag: [R]: exported from: ./utils/hp2ps/dist/build/Main.o
    filter: [R]: exported from: ./utils/hp2ps/dist/build/Main.o
    iflag: [R]: exported from: ./utils/hp2ps/dist/build/Main.o
    mflag: [R]: exported from: ./utils/hp2ps/dist/build/Main.o
    pflag: [R]: exported from: ./utils/hp2ps/dist/build/Main.o
    psfile: [R]: exported from: ./utils/hp2ps/dist/build/Main.o
    tflag: [R]: exported from: ./utils/hp2ps/dist/build/Main.o
    OrderOf: [R]: exported from: ./utils/hp2ps/dist/build/Reorder.o
Signed-off-by: Sergei Trofimovich <siarheit@google.com>

Found by uselex.rb:
    complain: [R]: exported from: ./utils/unlit/dist/build/unlit.o
    egetc: [R]: exported from: ./utils/unlit/dist/build/unlit.o
    myputc: [R]: exported from: ./utils/unlit/dist/build/unlit.o
    readline: [R]: exported from: ./utils/unlit/dist/build/unlit.o
    unlit: [R]: exported from: ./utils/unlit/dist/build/unlit.o
    writeerror: [R]: exported from: ./utils/unlit/dist/build/unlit.o
Signed-off-by: Sergei Trofimovich <siarheit@google.com>

This reverts commit 4f9967aa.

Test Plan:
```
ghci> import GHC.Stack
ghci> SrcLoc "f" "b" "c" 1 2 3 4
SrcLoc {srcLocPackage = "f", srcLocModule = "b", srcLocFile = "c",
srcLocStartLine = 1, srcLocStartCol = 2, srcLocEndLine = 3,
srcLocEndCol = 4}
```

Reviewers: austin, hvr, bgamari

Reviewed By: bgamari

Subscribers: thomie

Projects: #ghc

Differential Revision: https://phabricator.haskell.org/D1886

GHC Trac Issues: #11510

GHC.Conc exports Shutdown

-9e is crazy expensive for very little pay-off. See
http://smart-cactus.org/~ben/posts/2016-02-04-compression-comparison.html
for details.

Also remove the functions and types that became useless after removing
the fields:

- SRT functions
- LiveInfo type and functions
- freeVarsToLiveVars
- unariseLives and unariseSRT

Reviewers: bgamari, simonpj, austin

Reviewed By: simonpj

Subscribers: thomie

Differential Revision: https://phabricator.haskell.org/D1880

George updated the Diff but I didn't noticed until it was too late.

Overhaul the Overhauled Pattern Match Checker

* Changed the representation of Value Set Abstractions. Instead of
using a prefix tree, we now use a list of Value Vector Abstractions.
The set of constraints Delta for every Value Vector Abstraction is the
oracle state so that we solve everything only once.

* Instead of doing everything lazily, we prune at once (and in general
everything is much stricter). Hence, an example written with pattern
guards is checked in almost the same time as the equivalent with
pattern matching.

* Do not store the covered and the divergent sets at all. Since what we
only need is a yes/no (does this clause cover anything? Does it force
any thunk?) We just keep a boolean for each.

* Removed flags `-Wtoo-many-guards` and `-ffull-guard-reasoning`.
Replaced with `fmax-pmcheck-iterations=n`. Still debatable what should
the default `n` be.

* When a guard is for sure not going to contribute anything, we treat
it as such: The oracle is not called and cases `CGuard`, `UGuard` and
`DGuard` from the paper are not happening at all (the generation of a
fresh variable, the unfolding of the pattern list etc.). his combined
with the above seems to be enough to drop the memory increase for test
T783 down to 18.7%.

* Do not export function `dsPmWarn` (it is now called directly from
within `checkSingle` and `checkMatches`).

* Make `PmExprVar` hold a `Name` instead of an `Id`. The term oracle
does not handle type information so using `Id` was a waste of
time/space.

* Added testcases T11195, T11303b (data families) and T11374

The patch addresses at least the following:
Trac #11195, #11276, #11303, #11374, #11162

Test Plan: validate

Reviewers: goldfire, bgamari, hvr, austin

Subscribers: simonpj, thomie

Differential Revision: https://phabricator.haskell.org/D1795

the MIN_VERSION_bytestring() macro is going to be needed
for the upcoming binary update

It's astoundingly difficult to find a good description of zonking. Given
that there is a Stack Overflow question on the matter, I'm clearly not
the only one who feels this way. Hopefully this will clarify the issue.

Test Plan: Read it

Reviewers: goldfire, austin, simonpj

Subscribers: thomie

Differential Revision: https://phabricator.haskell.org/D1859

Summary:
Phab:D866 added the `TypeError` datatype to `Control.Exception` to represent
the error that is thrown when `-fdefer-type-errors` is on, but a changelog
entry for it was never added. In addition, it should probably be a
newtype.

Reviewers: austin, hvr, KaneTW, bgamari

Reviewed By: KaneTW, bgamari

Subscribers: thomie, KaneTW

Differential Revision: https://phabricator.haskell.org/D1873

GHC Trac Issues: #10284

The `substTheta` call didn't have the free variables of the
`prov_theta` in the `in_scope` set. It should be enough to add
`univ_tvs`, as all the `ex_tvs` are already in the domain of
the substitution.

Test Plan: added a testcase

Reviewers: simonpj, bgamari, goldfire, austin

Reviewed By: simonpj, bgamari

Subscribers: thomie

Differential Revision: https://phabricator.haskell.org/D1879

GHC Trac Issues: #11524

Windows uses wchar_t* for paths. The code committed won't compile for
Windows as the types are incorrect and the types in the branches of the
ternary operator aren't consistent.

Test Plan: ./validate --fast

Reviewers: austin, rwbarton, erikd, bgamari

Subscribers: thomie

Differential Revision: https://phabricator.haskell.org/D1878

Summary:
Serialization of BCOs is slow, but we can parallelise it when using
ghci -j<n>.  It parallelises nicely, saving multiple seconds off the
link time in a large example I have.

Test Plan:
* validate
* `ghci -fexternal-interpreter` in `nofib/real/anna`

Reviewers: niteria, bgamari, ezyang, austin, hvr, erikd

Subscribers: thomie

Differential Revision: https://phabricator.haskell.org/D1877

GHC Trac Issues: #11100

Summary:
This makes a big performance difference especially when loading a
large number of modules and using parallel compilation (ghci -jN).

Test Plan:
* validate
* `ghci -fexternal-interpreter` in `nofib/real/anna`

Reviewers: niteria, bgamari, ezyang, austin, hvr, erikd

Subscribers: thomie

Differential Revision: https://phabricator.haskell.org/D1876

GHC Trac Issues: #11100

Summary: This cuts allocations by about a quarter.

Test Plan:
* validate
* `ghci -fexternal-interpreter` in `nofib/real/anna`

Reviewers: niteria, bgamari, ezyang, austin, hvr, erikd

Subscribers: thomie

Differential Revision: https://phabricator.haskell.org/D1875

GHC Trac Issues: #11100