- 05 Dec, 2008 2 commits
-
-
simonpj@microsoft.com authored
See Note [Passing the case binder to join points] in Simplify.lhs The default now is *not* to pass the case binder. There are some nofib results with the above note; the effect is almost always negligible. I don't expect this flag to be used by users (hence no docs). It's just there to let me try the performance effects of switching on and off.
-
simonpj@microsoft.com authored
The new static flag -fsimple-list-literals makes ExplicitList literals be desugared in the straightforward way, rather than using 'build' as now. See SLPJ comments with Note [Desugaring explicit lists]. I don't expect this flag to be used by users (hence no docs). It's just there to let me try the performance effects of switching on and off.
-
- 13 Oct, 2008 1 commit
-
-
dias@eecs.harvard.edu authored
o Fixed bug that emitted the copy-in code for closure entry in the wrong place -- at the initialization of the closure. o Refactored some of the closure entry code. o Added code to check that no LocalRegs are live-in to a procedure -- trip up some buggy programs earlier o Fixed environment bindings for thunks -- we weren't (re)binding the free variables in a thunk o Fixed a bug in proc-point splitting that dropped some updates to the entry block in a procedure. o Fixed improper calls to code that generates CmmLit's for strings o New invariant on cg_loc in CgIdInfo: the expression is always tagged o Code to load free vars on entry to a thunk was (wrongly) placed before the heap check. o Some of the StgCmm code was redundantly passing around Id's along with CgIdInfo's; no more. o Initialize the LocalReg's that point to a closure before allocating and initializing the closure itself -- otherwise, we have problems with recursive closure bindings o BlockEnv and BlockSet types are now abstract. o Update frames: - push arguments in Old call area - keep track of the return sp in the FCode monad - keep the return sp in every call, tail call, and return (because it might be different at different call sites, e.g. tail calls to the gc after a heap check are performed before pushing the update frame) - set the sp appropriately on returns and tail calls o Reduce call, tail call, and return to a single LastCall node o Added slow entry code, using different calling conventions on entry and tail call o More fixes to the calling convention code. The tricky stuff is all about the closure environment: it must be passed in R1, but in non-closures, there is no such argument, so we can't treat all arguments the same way: the closure environment is special. Maybe the right step forward would be to define a different calling convention for closure arguments. o Let-no-escapes need to be emitted out-of-line -- otherwise, we drop code. o Respect RTS requirement of word alignment for pointers My stack allocation can pack sub-word values into a single word on the stack, but it wasn't requiring word-alignment for pointers. It does now, by word-aligning both pointer registers and call areas. o CmmLint was over-aggresively ruling out non-word-aligned memory references, which may be kosher now that we can spill small values into a single word. o Wrong label order on a conditional branch when compiling switches. o void args weren't dropped in many cases. To help prevent this kind of mistake, I defined a NonVoid wrapper, which I'm applying only to Id's for now, although there are probably other good candidates. o A little code refactoring: separate modules for procpoint analysis splitting, stack layout, and building infotables. o Stack limit check: insert along with the heap limit check, using a symbolic constant (a special CmmLit), then replace it when the stack layout is known. o Removed last node: MidAddToContext o Adding block id as a literal: means that the lowering of the calling conventions no longer has to produce labels early, which was inhibiting common-block elimination. Will also make it easier for the non-procpoint-splitting path. o Info tables: don't try to describe the update frame! o Over aggressive use of NonVoid!!!! Don't drop the non-void args before setting the type of the closure!!! o Sanity checking: Added a pass to stub dead dead slots on the stack (only ~10 lines with the dataflow framework) o More sanity checking: Check that incoming pointer arguments are non-stubbed. Note: these checks are still subject to dead-code removal, but they should still be quite helpful. o Better sanity checking: why stop at function arguments? Instead, in mkAssign, check that _any_ assignment to a pointer type is non-null -- the sooner the crash, the easier it is to debug. Still need to add the debugging flag to turn these checks on explicitly. o Fixed yet another calling convention bug. This time, the calls to the GC were wrong. I've added a new convention for GC calls and invoked it where appropriate. We should really straighten out the calling convention stuff: some of the code (and documentation) is spread across the compiler, and there's some magical use of the node register that should really be handled (not avoided) by calling conventions. o Switch bug: the arms in mkCmmLitSwitch weren't returning to a single join point. o Environment shadowing problem in Stg->Cmm: When a closure f is bound at the top-level, we should not bind f to the node register on entry to the closure. Why? Because if the body of f contains a let-bound closure g that refers to f, we want to make sure that it refers to the static closure for f. Normally, this would all be fine, because when we compile a closure, we rebind free variables in the environment. But f doesn't look like a free variable because it's a static value. So, the binding for f remains in the environment when we compile g, inconveniently referring to the wrong thing. Now, I bind the variable in the local environment only if the closure is not bound at the top level. It's still okay to make assumptions about the node holding the closure environment; we just won't find the binding in the environment, so code that names the closure will now directly get the label of the static closure, not the node register holding a pointer to the static closure. o Don't generate bogus Cmm code containing SRTs during the STG -> Cmm pass! The tables made reference to some labels that don't exist when we compute and generate the tables in the back end. o Safe foreign calls need some special treatment (at least until we have the integrated codegen). In particular: o they need info tables o they are not procpoints -- the successor had better be in the same procedure o we cannot (yet) implement the calling conventions early, which means we have to carry the calling-conv info all the way to the end o We weren't following the old convention when registering a module. Now, we use update frames to push any new modules that have to be registered and enter the youngest one on the stack. We also use the update frame machinery to specify that the return should pop the return address off the stack. o At each safe foreign call, an infotable must be at the bottom of the stack, and the TSO->sp must point to it. o More problems with void args in a direct call to a function: We were checking the args (minus voids) to check whether the call was saturated, which caused problems when the function really wasn't saturated because it took an extra void argument. o Forgot to distinguish integer != from floating != during Stg->Cmm o Updating slotEnv and areaMap to include safe foreign calls The dataflow analyses that produce the slotEnv and areaMap give results for each basic block, but we also need the results for a safe foreign call, which is a middle node. After running the dataflow analysis, we have another pass that updates the results to includ any safe foreign calls. o Added a static flag for the debugging technique that inserts instructions to stub dead slots on the stack and crashes when a stubbed value is loaded into a pointer-typed LocalReg. o C back end expects to see return continuations before their call sites. Sorted the flowgraphs appropriately after splitting. o PrimOp calling conventions are special -- unlimited registers, no stack Yet another calling convention... o More void value problems: if the RHS of a case arm is a void-typed variable, don't try to return it. o When calling some primOp, they may allocate memory; if so, we need to do a heap check when we return from the call.
-
- 26 Aug, 2008 1 commit
-
-
Ian Lynagh authored
This allows us to avoid a module import loop: CmdLineParser -> SrcLoc -> Outputable -> StaticFlags -> CmdLineParser
-
- 30 Jul, 2008 1 commit
-
-
Ian Lynagh authored
-
- 11 Jul, 2008 1 commit
-
-
Ian Lynagh authored
These are needed for GLOBAL_VAR's to work properly
-
- 16 Jun, 2008 1 commit
-
-
Ian Lynagh authored
* Allow -ffoo flags to be deprecated * Mark some -ffoo flags as deprecated * Avoid using deprecated flags in error messages, in the build system, etc * Add a flag to en/disable the deprecated flag warning
-
- 14 Jun, 2008 3 commits
-
-
Ian Lynagh authored
-
Ian Lynagh authored
-
Ian Lynagh authored
-
- 05 Jun, 2008 1 commit
-
-
simonpj@microsoft.com authored
Occasionally people write very large recursive groups of definitions. In general we desugar these to a single definition that binds tuple, plus lots of tuple selectors. But that code has quadratic size, which can be bad. This patch adds a new case to the desugaring of bindings, for the situation where there are lots of polymorphic variables, but no dictionaries. (Dictionaries force us into the general case.) See Note [Abstracting over tyvars only]. The extra behaviour can be disabled with the (static) flag -fno-ds-multi-tyvar in case we want to experiment with switching it on or off. There is essentially-zero effect on the nofib suite though. I was provoked into doing this by Trac #1136. In fact I'm not sure it's the real cause of the problem there, but it's a good idea anyway.
-
- 03 Jun, 2008 2 commits
-
-
Simon Marlow authored
From the docs: <para>Suppress any unsolicited debugging output. When GHC has been built with the <literal>DEBUG</literal> option it occasionally emits debug output of interest to developers. The extra output can confuse the testing framework and cause bogus test failures, so this flag is provided to turn it off.</para>
-
Simon Marlow authored
-
- 29 May, 2008 1 commit
-
-
dias@eecs.harvard.edu authored
Several changes in this patch, partially bug fixes, partially new code: o bug fixes in ZipDataflow - added some checks to verify that facts converge - removed some erroneous checks of convergence on entry nodes - added some missing applications of transfer functions o changed dataflow clients to use ZipDataflow, making ZipDataflow0 obsolete o eliminated DFA monad (no need for separate analysis and rewriting monads with ZipDataflow) o started stack layout changes - no longer generating CopyIn and CopyOut nodes (not yet fully expunged though) - still not using proper calling conventions o simple new optimizations: - common block elimination -- have not yet tried to move the Adams opt out of CmmProcPointZ - block concatenation o piped optimization fuel up to the HscEnv - can be limited by a command-line flag - not tested, and probably not yet properly used by clients o added unique supply to FuelMonad, also lifted unique supply to DFMonad
-
- 20 May, 2008 1 commit
-
-
rl@cse.unsw.edu.au authored
We want -Odph to be a dynamic flag and that should imply -fno-method-sharing. This doesn't add a lot of complexity.
-
- 22 Apr, 2008 3 commits
-
-
Ian Lynagh authored
-
Ian Lynagh authored
-
simonpj@microsoft.com authored
-
- 29 Mar, 2008 1 commit
-
-
Ian Lynagh authored
Modules that need it import it themselves instead.
-
- 25 Mar, 2008 1 commit
-
-
Ian Lynagh authored
-
- 09 Mar, 2008 1 commit
-
-
rl@cse.unsw.edu.au authored
This patch removes the ndpFlatten directory and the -fflatten static flag. This code has never worked and has now been superceded by vectorisation.
-
- 28 Feb, 2008 1 commit
-
-
Simon Marlow authored
It turns out that -prof -threaded works (modulo some small changes), because all the data structures used in profiling are only accessed by one thread at a time, at long as we don't use +RTS -N2 or higher. So this patch enables the use of -prof -threaded, but an error is given if you ask for more than one CPU with +RTS -N.
-
- 17 Jan, 2008 1 commit
-
-
simonpj@microsoft.com authored
This patch addresses a problem that Roman found in SpecConstr. Consider: foo :: Maybe Int -> Maybe Int -> Int foo a b = let j b = foo a b in case b of Nothing -> ... Just n -> case a of Just m -> ... j (Just (n+1)) ... Nothing -> ... j (Just (n-1)) ... We want to make specialised versions for 'foo' for the patterns Nothing (Just v) (Just a) (Just b) Two problems, caused by the join point j. First, j does not scrutinise b, so j won't be specialised f for the (Just v) pattern. Second, j is defined where the free var 'a' is not evaluated. Both are solved by brutally inlining j at its call sites. This risks major code bloat, but it's relatively quick to implement. The flag -fspec-inline-join-points causes brutal inlining for a non-recursive binding of a function whose RHS contains calls of a recursive function The (experimental) flag is static for now, and I have not even documented it properly.
-
- 10 Jan, 2008 1 commit
-
-
Clemens Fruhwirth authored
-
- 03 Jan, 2008 1 commit
-
-
simonpj@microsoft.com authored
This flag does nothing, and should have been removed ages ago. (GHC no longer does update-in-place.) MERGE to 6.8 branch
-
- 20 Dec, 2007 1 commit
-
-
simonpj@microsoft.com authored
-
- 27 Nov, 2007 1 commit
-
-
Simon Marlow authored
-
- 16 Nov, 2007 1 commit
-
-
simonpj@microsoft.com authored
This is intended only for debugging use: it makes it easier to compare two variants without the variations between uniques mattering. (Of course, you can't actually feed the output to the C compiler or assembler and expect anything sensible to happen!)
-
- 09 Oct, 2007 1 commit
-
-
Simon Marlow authored
-
- 21 Sep, 2007 1 commit
-
-
Ian Lynagh authored
Fixes building with -Werror (i.e. validate) and GHC < 6.6
-
- 04 Sep, 2007 1 commit
-
-
Ian Lynagh authored
-
- 03 Sep, 2007 1 commit
-
-
Ian Lynagh authored
Older GHCs can't parse OPTIONS_GHC. This also changes the URL referenced for the -w options from WorkingConventions#Warnings to CodingStyle#Warnings for the compiler modules.
-
- 01 Sep, 2007 1 commit
-
-
Ian Lynagh authored
-
- 07 Aug, 2007 1 commit
-
-
Isaac Dupree authored
-
- 17 Jul, 2007 1 commit
-
-
Clemens Fruhwirth authored
-
- 08 Jul, 2007 1 commit
-
-
Simon Marlow authored
Ugly hack; see comments for details
-
- 02 Jul, 2007 1 commit
-
-
Ian Lynagh authored
Use standard isPrefixOf/isSuffixOf instead.
-
- 27 Jun, 2007 1 commit
-
-
andy@galois.com authored
-
- 26 Jun, 2007 1 commit
-
-
andy@galois.com authored
-
- 22 Jun, 2007 1 commit
-
-
andy@galois.com authored
-