1. 13 May, 2018 7 commits
    • Michal Terepeta's avatar
      Fix a few GCC warnings · eb39f988
      Michal Terepeta authored and Ben Gamari's avatar Ben Gamari committed
      GCC 8 now generates warnings for incompatible function pointer casts
      [-Werror=cast-function-type]. Apparently there are a few of those in rts
      code, which makes `./validate` unhappy (since we compile with `-Werror`)
      This commit tries to fix these issues by changing the functions to have
      the correct type (and, if necessary, moving the casts into those
      For instance, hash/comparison function are declared (`Hash.h`) to take
      `StgWord` but we want to use `StgWord64[2]` in `StaticPtrTable.c`.
      Instead of casting the function pointers, we can cast the `StgWord`
      parameter to `StgWord*`. I think this should be ok since `StgWord`
      should be the same size as a pointer.
      Signed-off-by: Michal Terepeta's avatarMichal Terepeta <michal.terepeta@gmail.com>
      Test Plan: ./validate
      Reviewers: bgamari, erikd, simonmar
      Reviewed By: bgamari
      Subscribers: rwbarton, thomie, carter
      Differential Revision: https://phabricator.haskell.org/D4673
    • Sylvain Henry's avatar
      Refactor LitString · 7c665f9c
      Sylvain Henry authored and Ben Gamari's avatar Ben Gamari committed
      Refactor LitString so that the string length is computed at most once
      and then stored.
      Also remove strlen and memcmp wrappers (it seems like they were a
      workaround for a very old GCC when using -fvia-C).
      Bumps haddock submodule.
      Reviewers: bgamari, dfeuer, nickkuk
      Reviewed By: bgamari, nickkuk
      Subscribers: nickkuk, dfeuer, thomie, carter
      Differential Revision: https://phabricator.haskell.org/D4630
    • Ben Gamari's avatar
      Bump array submodule · 21884270
      Ben Gamari authored
    • Ben Gamari's avatar
      TcInteract: Ensure that tycons have representations before solving for Typeable · f0212a93
      Ben Gamari authored and Ben Gamari's avatar Ben Gamari committed
      Summary: This fixes #15067.
      Test Plan: Validate
      Subscribers: thomie, carter, RyanGlScott
      GHC Trac Issues: #15067
      Differential Revision: https://phabricator.haskell.org/D4623
    • Ben Gamari's avatar
      base: Fix handling of showEFloat (Just 0) · 9039f847
      Ben Gamari authored and Ben Gamari's avatar Ben Gamari committed
      Previously `showEFloat (Just 0) pi ""` would produce `3.0e0`. Of
      course, this
      blatantly disrespects the user's request to print with zero digits of
      Fix this.
      This is tested by base's `num008` testcase.
      Test Plan: Validate
      Reviewers: hvr
      Subscribers: rwbarton, thomie, carter
      GHC Trac Issues: #15115
      Differential Revision: https://phabricator.haskell.org/D4665
    • Matthew Pickering's avatar
      Simplify -ddump-json implementation · 6ab7cf99
      Matthew Pickering authored and Ben Gamari's avatar Ben Gamari committed
      This patch takes the much simpler route of whenever the compiler tries
      to output something. We just dump a JSON document there and then.
      I think this should be sufficient to work with and anything more refined
      quickly got complicated as it was necessary to demarcate message scopes
      and so on.
      Reviewers: bgamari, dfeuer
      Reviewed By: bgamari
      Subscribers: Phyx, dfeuer, rwbarton, thomie, carter
      GHC Trac Issues: #14078
      Differential Revision: https://phabricator.haskell.org/D4532
    • Herbert Valerio Riedel's avatar
      Emit info-level log message when package envs are loaded · 00049e2d
      Herbert Valerio Riedel authored
      A common complaint with the new package environment files feature is
      that it's not obvious when package environments have been picked up.
      This patch applies the same strategy that was already used for `.ghci` files
      (which exhibit similar potential for confusion, c.f. #11389) to package
      environment files.
      For instance, this new notification looks like below for a GHCi invocation which
      loads both, a GHCi configuration as well as a package environment:
        GHCi, version 8.5.20180512: http://www.haskell.org/ghc/  :? for help
        Loaded package environment from /tmp/parsec-
        Loaded GHCi configuration from /home/hvr/.ghci
      Addresses #15145
      Reviewed By: bgamari, angerman
      GHC Trac Issues: #15145
      Differential Revision: https://phabricator.haskell.org/D4689
  2. 12 May, 2018 4 commits
  3. 11 May, 2018 2 commits
  4. 10 May, 2018 3 commits
  5. 09 May, 2018 1 commit
    • Simon Marlow's avatar
      Add -fghci-leak-check to check for space leaks · 5fe6aaa3
      Simon Marlow authored
      Space leaks in GHCi emerge from time to time and tend to come back again
      after they get fixed. This is an attempt to limit regressions by
      * adding a reliable detection for some classes of space leaks in GHCi
      * turning on leak checking for all GHCi tests in the test suite, so that
        we'll notice if the leak appears again.
      The idea for detecting space leaks is quite simple:
      * find some data that we expect to be GC'd later, make a weak pointer to it
      * when we expect the data to be dead, do a `performGC` and then check
        the status of the weak pointer.
      It would be nice to apply this trick to lots of things in GHC,
      e.g. ensuring that HsSyn is not retained after the desugarer, or
      ensuring that CoreSyn from the previous simplifier pass is not retained.
      Test Plan: validate
      Reviewers: bgamari, simonpj, erikd, niteria
      Subscribers: thomie, carter
      GHC Trac Issues: #15111
      Differential Revision: https://phabricator.haskell.org/D4658
  6. 08 May, 2018 8 commits
  7. 06 May, 2018 6 commits
  8. 05 May, 2018 9 commits