Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in / Register
  • GHC GHC
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 5,252
    • Issues 5,252
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
  • Merge requests 576
    • Merge requests 576
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Glasgow Haskell CompilerGlasgow Haskell Compiler
  • GHCGHC
  • Issues
  • #14233
Closed
Open
Issue created Sep 14, 2017 by Niklas Hambüchen@nh2Reporter

Remove old GetTickCount() code path for Windows

Windows XP support was dropped since GHC 8.0 as per https://ghc.haskell.org/trac/ghc/wiki/WindowsGhc

In HsWord64 getMonotonicNSec() on Windows we still fall back to the 32-bit GetTickCount() if QueryPerformanceFrequency() is not supported: Code

But Microsoft's documentation says that QueryPerformanceFrequency() is guaranteed to be supported on Windows >= XP:

On systems that run Windows XP or later, the function will always succeed and will thus never return zero.

Thus we can remove the if (!qpc_supported) check and all if (!qpc_frequency.QuadPart) code paths, and replace it with an assertion or a ./configure check.

We can also add a comment that getMonotonicNSec() will indeed always make use of the whole 64-bit domain.

Trac metadata
Trac field Value
Version 8.3
Type Task
TypeOfFailure OtherFailure
Priority normal
Resolution Unresolved
Component Compiler
Test case
Differential revisions
BlockedBy
Related
Blocking
CC bgamari, nh2
Operating system
Architecture
To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
Time tracking