Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in / Register
GHC
GHC
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 4,392
    • Issues 4,392
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
    • Iterations
  • Merge Requests 374
    • Merge Requests 374
  • Requirements
    • Requirements
    • List
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Operations
    • Operations
    • Incidents
    • Environments
  • Analytics
    • Analytics
    • CI / CD
    • Code Review
    • Insights
    • Issue
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Glasgow Haskell Compiler
  • GHCGHC
  • Issues
  • #16654

Closed
Open
Opened May 14, 2019 by David Eichmann@DavidEichmann🏋Maintainer5 of 6 tasks completed5/6 tasks

Parser performance regression after disabling happy's --coerce option

According to @int-index via GHC-devs (https://mail.haskell.org/pipermail/ghc-devs/2019-May/017600.html):

This February I did some changes to the parser that require higher rank types support in ‘happy’. Unfortunately, as I discovered, happy’s --coerce option is severely broken in the presence of higher rank types, so I had to disable it. My benchmarks have shown a 10% slowdown from disabling --coerce (https://gist.github.com/int-index/38af0c5dd801088dc1de59eca4e55df4).

Alongside my changes I submitted a pull request to happy which fixes the issue (https://github.com/simonmar/happy/pull/134), in the hope that it would get merged, released, and I could re-enable --coerce in GHC ‘happy' configuration.

  1. Merge https://github.com/simonmar/happy/pull/134
  2. Release a new ‘happy’
  3. (Optional) Specify in GHC’s build system that it builds only with the latest 'happy' release
  4. Restore the --coerce option in GHC’s build system ‘happy’ configuration
  5. Backport it to the ghc-8.8 branch

We also need to:

  1. Update CI docker images
Edited May 14, 2019 by Vladislav Zavialov
Assignee
Assign to
8.8.1
Milestone
8.8.1 (Past due)
Assign milestone
Time tracking
None
Due date
None
Reference: ghc/ghc#16654